Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200329140459.18155-1-maco@android.com> <20200330010024.GA23640@ming.t460p>
 <CAB0TPYG4N-2Gg95VwQuQBQ8rvjC=4NQJP4syJWS3Q6CO28HzTQ@mail.gmail.com> <20200331074828.GA24372@lst.de>
In-Reply-To: <20200331074828.GA24372@lst.de>
From:   Martijn Coenen <maco@android.com>
Date:   Tue, 31 Mar 2020 13:25:41 +0200
Message-ID: <CAB0TPYEwOd-jYJTkq1DYp=c7uXMKvpSpgpcpZGMwW2QsYkOtSw@mail.gmail.com>
Subject: Re: [PATCH] loop: Add LOOP_SET_FD_WITH_OFFSET ioctl.
To:     Christoph Hellwig <hch@lst.de>
Cc:     Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
        Bart Van Assche <bvanassche@acm.org>,
        Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
        linux-block <linux-block@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, kernel-team@android.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 31, 2020 at 9:48 AM Christoph Hellwig <hch@lst.de> wrote:
> I think the full blown set fd an status would seem a lot more useful,
> or even better a LOOP_CTL_ADD variant that sets up everything important
> on the character device so that we avoid the half set up block devices
> entirely.

Thanks for the feedback, I will work on that then. I think I could do
both - LOOP_SET_FD_AND_STATUS and a new variant of LOOP_CTL_ADD that
calls it - the former could still be useful if the kernel pre-created
a large amount of loop devices.

Martijn