Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3523858ybb; Tue, 31 Mar 2020 07:02:10 -0700 (PDT) X-Google-Smtp-Source: ADFU+vt91+NhOIj8xeorFKGXaVDpMfqO9YKKfgcV4hEGYJWtFxlesYl02T8bpI4BWQRlr+JaEIPc X-Received: by 2002:a9d:6c45:: with SMTP id g5mr13077660otq.347.1585663330574; Tue, 31 Mar 2020 07:02:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585663330; cv=none; d=google.com; s=arc-20160816; b=RkbhC50F+gREGFAQiKyqOOp+F75Ue3xBsJ3kSPS64+fRm+6QvCc26a7zxsWfbB8ruJ aPNQE2CyjVZciBRXUD1g9bENY5mspDsuohCRlmC6UARfrUmHhokqeGop0VttPHGyuofV LM0KhmSAtdQrmOid93eBJiaZ4ipQJLpfPpv/hOhGqxAeslDySC8akKIGmHZZiepnUsJW Gq+tla7can20ohswrFg53MeCy6A8ZIB7IHh0DXHHUiSFpwBP8J1NcCV6TztLfjMIE4X+ cSSWWoUtMm58w4g9fYwoneFxIsMVmZMA1Ym9h/BntRKcASFtMK9ZY9+yC7+i8hIr1IUn OWaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=c2Io50PosNaB8OExcmw/XYDPaGwAImcojBj0LwhtAjE=; b=f0Umt3fU9m+M2Rlf4iQHKw9KIOgUw8iGx2c9sKx4hiNvPRoBEQG7Hv+hJW7Nht1Au7 tWkmA72dZCIBhPW31aRKV14vNmMyfcSBqzbDWN73YxsyJO0yeIp5EG70+QQU5djniFbs pjthDxY1D0sWVtmqEGX21SUA+qZSSkvfcHPEc6JzpdL0HQChnoYfczPkJkCgDATmhm7o 63uOS0dgocB30Dd4SrtowVONcglbSkz0mkO9/xEuQM52HbWKi6sfOeeLKGx9J92gv0nq R6CWpS55XO/lP9Cc3dlUU5sUH0jAf0EmVB/g15YZy1mBcnrhChEGKs5Bn+jtYk6X6EFW nACQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j18si6359017otk.166.2020.03.31.07.01.54; Tue, 31 Mar 2020 07:02:10 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730923AbgCaOAP (ORCPT + 99 others); Tue, 31 Mar 2020 10:00:15 -0400 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]:48939 "EHLO out30-45.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730442AbgCaOAP (ORCPT ); Tue, 31 Mar 2020 10:00:15 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R951e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=zhangliguang@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0TuABiZr_1585663188; Received: from localhost(mailfrom:zhangliguang@linux.alibaba.com fp:SMTPD_---0TuABiZr_1585663188) by smtp.aliyun-inc.com(127.0.0.1); Tue, 31 Mar 2020 21:59:57 +0800 From: luanshi To: Will Deacon , Robin Murphy , Joerg Roedel Cc: linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH] iommu/arm-smmu-v3: move error checking into common path Date: Tue, 31 Mar 2020 21:59:48 +0800 Message-Id: <1585663188-114303-1-git-send-email-zhangliguang@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Move error checking into common path to be consistent with drivers/iommu/arm-smmu.c. Signed-off-by: Liguang Zhang --- drivers/iommu/arm-smmu-v3.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/iommu/arm-smmu-v3.c b/drivers/iommu/arm-smmu-v3.c index aa3ac2a..970f1c9 100644 --- a/drivers/iommu/arm-smmu-v3.c +++ b/drivers/iommu/arm-smmu-v3.c @@ -3889,13 +3889,13 @@ static int arm_smmu_device_probe(struct platform_device *pdev) } smmu->dev = dev; - if (dev->of_node) { + if (dev->of_node) ret = arm_smmu_device_dt_probe(pdev, smmu); - } else { + else ret = arm_smmu_device_acpi_probe(pdev, smmu); - if (ret == -ENODEV) - return ret; - } + + if (ret) + return ret; /* Set bypass mode according to firmware probing result */ bypass = !!ret; -- 1.8.3.1