Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Sa, Nuno" <Nuno.Sa@analog.com>
To:     Rohit Sarkar <rohitsarkar5398@gmail.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
CC:     "Bogdan, Dragos" <Dragos.Bogdan@analog.com>,
        Lars-Peter Clausen <lars@metafoo.de>,
        "Hennerich, Michael" <Michael.Hennerich@analog.com>,
        Stefan Popa <stefan.popa@analog.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 2/2] iio: imu: adis16460: use DEFINE_DEBUGFS_ATTRIBUTE
 instead of DEFINE_SIMPLE_ATTRIBUTE
Thread-Topic: [PATCH v2 2/2] iio: imu: adis16460: use DEFINE_DEBUGFS_ATTRIBUTE
 instead of DEFINE_SIMPLE_ATTRIBUTE
Thread-Index: AQHWB1JK8SqV+m9ll0iy5w3+icdDlKhi01KA
Date:   Tue, 31 Mar 2020 15:28:22 +0000
Message-ID: <BN6PR03MB33478A31AA2CF52CF3A81AB999C80@BN6PR03MB3347.namprd03.prod.outlook.com>
References: <20200328063456.24012-1-rohitsarkar5398@gmail.com>
 <20200331114732.14739-1-rohitsarkar5398@gmail.com>
 <20200331114732.14739-3-rohitsarkar5398@gmail.com>
In-Reply-To: <20200331114732.14739-3-rohitsarkar5398@gmail.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: analog.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 419f1fa2-64e7-42cf-f48d-08d7d58825bd
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Mar 2020 15:28:22.0719
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3kIb64xvnWg/DbeJmc2VqxyQjjfiTDFep1NF51GcXtBl/MfAxNA/Lz0A/dSISkjHLSNfPky3H1YhpNMNDGUPXw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB3044
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676
 definitions=2020-03-31_05:2020-03-31,2020-03-31 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 clxscore=1015 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0
 impostorscore=0 suspectscore=0 mlxlogscore=999 spamscore=0
 lowpriorityscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2003020000 definitions=main-2003310140
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: linux-iio-owner@vger.kernel.org <linux-iio-owner@vger.kernel.org> O=
n
> Behalf Of Rohit Sarkar
> Sent: Dienstag, 31. M=E4rz 2020 13:48
> To: linux-iio@vger.kernel.org
> Cc: Bogdan, Dragos <Dragos.Bogdan@analog.com>; Rohit Sarkar
> <rohitsarkar5398@gmail.com>; Lars-Peter Clausen <lars@metafoo.de>;
> Hennerich, Michael <Michael.Hennerich@analog.com>; Stefan Popa
> <stefan.popa@analog.com>; Jonathan Cameron <jic23@kernel.org>; Hartmut
> Knaack <knaack.h@gmx.de>; Peter Meerwald-Stadler
> <pmeerw@pmeerw.net>; linux-kernel@vger.kernel.org
> Subject: [PATCH v2 2/2] iio: imu: adis16460: use
> DEFINE_DEBUGFS_ATTRIBUTE instead of DEFINE_SIMPLE_ATTRIBUTE
>=20
> debugfs_create_file_unsafe does not protect the fops handed to it
> against file removal. DEFINE_DEBUGFS_ATTRIBUTE makes the fops aware of
> the file lifetime and thus protects it against removal.
>=20
> Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>
> ---
>  drivers/iio/imu/adis16460.c | 27 +++++++++++++++------------
>  1 file changed, 15 insertions(+), 12 deletions(-)
>=20
> diff --git a/drivers/iio/imu/adis16460.c b/drivers/iio/imu/adis16460.c
> index 9539cfe4a259..f96cfd007957 100644
> --- a/drivers/iio/imu/adis16460.c
> +++ b/drivers/iio/imu/adis16460.c
> @@ -87,8 +87,8 @@ static int adis16460_show_serial_number(void *arg,
> u64 *val)
>=20
>  	return 0;
>  }
> -DEFINE_SIMPLE_ATTRIBUTE(adis16460_serial_number_fops,
> -	adis16460_show_serial_number, NULL, "0x%.4llx\n");
> +DEFINE_DEBUGFS_ATTRIBUTE(adis16460_serial_number_fops,
> +		adis16460_show_serial_number, NULL, "0x%.4llx\n");
>=20
>  static int adis16460_show_product_id(void *arg, u64 *val)
>  {
> @@ -105,8 +105,8 @@ static int adis16460_show_product_id(void *arg, u64
> *val)
>=20
>  	return 0;
>  }
> -DEFINE_SIMPLE_ATTRIBUTE(adis16460_product_id_fops,
> -	adis16460_show_product_id, NULL, "%llu\n");
> +DEFINE_DEBUGFS_ATTRIBUTE(adis16460_product_id_fops,
> +		adis16460_show_product_id, NULL, "%llu\n");
>=20
>  static int adis16460_show_flash_count(void *arg, u64 *val)
>  {
> @@ -123,19 +123,22 @@ static int adis16460_show_flash_count(void *arg,
> u64 *val)
>=20
>  	return 0;
>  }
> -DEFINE_SIMPLE_ATTRIBUTE(adis16460_flash_count_fops,
> -	adis16460_show_flash_count, NULL, "%lld\n");
> +DEFINE_DEBUGFS_ATTRIBUTE(adis16460_flash_count_fops,
> +		adis16460_show_flash_count, NULL, "%lld\n");
>=20
>  static int adis16460_debugfs_init(struct iio_dev *indio_dev)
>  {
>  	struct adis16460 *adis16460 =3D iio_priv(indio_dev);
>=20
> -	debugfs_create_file("serial_number", 0400, indio_dev-
> >debugfs_dentry,
> -		adis16460, &adis16460_serial_number_fops);
> -	debugfs_create_file("product_id", 0400, indio_dev->debugfs_dentry,
> -		adis16460, &adis16460_product_id_fops);
> -	debugfs_create_file("flash_count", 0400, indio_dev->debugfs_dentry,
> -		adis16460, &adis16460_flash_count_fops);
> +	debugfs_create_file_unsafe("serial_number", 0400,
> +			indio_dev->debugfs_dentry, adis16460,
> +			&adis16460_serial_number_fops);
> +	debugfs_create_file_unsafe("product_id", 0400,
> +			indio_dev->debugfs_dentry, adis16460,
> +			&adis16460_product_id_fops);
> +	debugfs_create_file_unsafe("flash_count", 0400,
> +			indio_dev->debugfs_dentry, adis16460,
> +			&adis16460_flash_count_fops);
>=20
>  	return 0;
>  }

Tested-by Nuno S=E1 <nuno.sa@analog.com>

> --
> 2.23.0.385.gbc12974a89