Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 31 Mar 2020 11:31:36 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Josh Poimboeuf <jpoimboe@redhat.com>, tglx@linutronix.de,
        linux-kernel@vger.kernel.org, x86@kernel.org, mhiramat@kernel.org,
        mbenes@suse.cz
Subject: Re: [RFC][PATCH] objtool,ftrace: Implement UNWIND_HINT_RET_OFFSET
Message-ID: <20200331113136.01316614@gandalf.local.home>
In-Reply-To: <20200331111652.GH20760@hirez.programming.kicks-ass.net>
References: <20200325174525.772641599@infradead.org>
        <20200325174605.369570202@infradead.org>
        <20200326113049.GD20696@hirez.programming.kicks-ass.net>
        <20200326135620.tlmof5fa7p5wct62@treble>
        <20200326154938.GO20713@hirez.programming.kicks-ass.net>
        <20200326195718.GD2452@worktop.programming.kicks-ass.net>
        <20200327010001.i3kebxb4um422ycb@treble>
        <20200330170200.GU20713@hirez.programming.kicks-ass.net>
        <20200330190205.k5ssixd5hpshpjjq@treble>
        <20200330200254.GV20713@hirez.programming.kicks-ass.net>
        <20200331111652.GH20760@hirez.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 31 Mar 2020 13:16:52 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> @@ -235,8 +237,8 @@ SYM_INNER_LABEL(ftrace_regs_call, SYM_L_GLOBAL)
>  
>  	/* If ORIG_RAX is anything but zero, make this a call to that */
>  	movq ORIG_RAX(%rsp), %rax
> -	cmpq	$0, %rax
> -	je	1f
> +	testq	%rax, %rax
> +	jz	1f
>  
>  	/* Swap the flags with orig_rax */
>  	movq MCOUNT_REG_SIZE(%rsp), %rdi

Hi Peter,

Can you send this change as a separate patch as it has nothing to do with
this current change, and is a clean up patch that stands on its own.

Thanks,

-- Steve