Date: Fri, 24 Feb 2006 02:09:21 -0500 (EST)
From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
cc: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
       linux-kernel@vger.kernel.org, Esben Nielsen <simlo@phys.au.dk>,
       Thomas Gleixner <tglx@linutronix.de>
Subject: Re: 2.6.15-rt17
In-Reply-To: <20060224063822.GC1431@elte.hu>
Message-ID: <Pine.LNX.4.58.0602240206200.19538@gandalf.stny.rr.com>
References: <20060221155548.GA30146@elte.hu> <6bffcb0e0602210916n3ddbd50i@mail.gmail.com>
 <Pine.LNX.4.58.0602220715460.4164@gandalf.stny.rr.com> <20060224063822.GC1431@elte.hu>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1137
Lines: 36


On Fri, 24 Feb 2006, Ingo Molnar wrote:

>
> * Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > +	printk("| This is not a BUG\n");
> > +	printk("| turn off CONFIG_DEBUG_STACK_OVERFLOW if you don't want this\n");
>
> i added the patch below - we want to know about too high stack
> footprints.

Yeah you're right, those should be reported.

>
>  		MAX_STACK-worst_stack_left, (long)MAX_STACK);
> +	fill_ratio = (MAX_STACK-worst_stack_left)*100/(long)MAX_STACK;
> +	printk("| Stack fill ratio: %02ld%%", fill_ratio);
> +	if (fill_ratio >= 90)
> +		printk(" - BUG: that's quite high, please report this!\n");
> +	else
> +		printk(" - that's still OK, no need to report this.\n");
>  	printk("------------|\n");

On the non bug case, I would still state the way to turn it off.  It
becomes quite annoying if there are no bugs, and a non kernel hacker may
not know how to disable it.

-- Steve


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/