DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com.au;
  h=Received:Message-ID:Date:From:User-Agent:X-Accept-Language:MIME-Version:To:CC:Subject:References:In-Reply-To:Content-Type:Content-Transfer-Encoding;
  b=Z2uekhz613ucj2abXI8bhkpvPZ1MlSbEnuJRKeeNYDykWdTf7YwHn4PA+rultPoLB0bQsBb/CKCA9MZ17vx/RhuOT41wkdY1kCcViVl5xIhStOUis8iB9uNLDAGSCIbJrFZB+VZGjCeJSVfAFEKJO0/zn37e6sG1yhmnkM66KIs=  ;
Message-ID: <43FEB370.6030101@yahoo.com.au>
Date: Fri, 24 Feb 2006 18:19:12 +1100
From: Nick Piggin <nickpiggin@yahoo.com.au>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.12) Gecko/20051007 Debian/1.7.12-1
MIME-Version: 1.0
To: Andrew Morton <akpm@osdl.org>
CC: john@johnmccutchan.com, holt@sgi.com, linux-kernel@vger.kernel.org,
       rml@novell.com, arnd@arndb.de, hch@lst.de, dipankar@in.ibm.com
Subject: Re: udevd is killing file write performance.
References: <20060222134250.GE20786@lnx-holt.americas.sgi.com>	<1140626903.13461.5.camel@localhost.localdomain>	<20060222175030.GB30556@lnx-holt.americas.sgi.com>	<1140648776.1729.5.camel@localhost.localdomain>	<20060222151223.5c9061fd.akpm@osdl.org>	<1140651662.2985.2.camel@localhost.localdomain>	<20060223161425.4388540e.akpm@osdl.org>	<20060224054724.GA8593@johnmccutchan.com>	<20060223220053.2f7a977e.akpm@osdl.org>	<43FEB0BF.6080403@yahoo.com.au> <20060223231621.0f5d5b8a.akpm@osdl.org>
In-Reply-To: <20060223231621.0f5d5b8a.akpm@osdl.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1041
Lines: 34

Andrew Morton wrote:
> Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> 
>>@@ -538,7 +579,7 @@ void inotify_dentry_parent_queue_event(s
>>  	struct dentry *parent;
>>  	struct inode *inode;
>>  
>> -	if (!atomic_read (&inotify_watches))
>> +	if (!(dentry->d_flags & DCACHE_INOTIFY_PARENT_WATCHED))
> 
> 
> Yeah, I think that would work.  One would need to wire up d_move() also -
> for when a file is moved from a watched to non-watched directory and
> vice-versa.
> 
> 

Oh yeah of course, good catch. Are there any other cases missing?

... I'll let the others on this thread digest before spitting out
another patch.

John or Robert, is there some kind of inotify test suite around?

Thanks,

-- 
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/