Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750830AbWBXHgi (ORCPT ); Fri, 24 Feb 2006 02:36:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750837AbWBXHgi (ORCPT ); Fri, 24 Feb 2006 02:36:38 -0500 Received: from nproxy.gmail.com ([64.233.182.196]:9091 "EHLO nproxy.gmail.com") by vger.kernel.org with ESMTP id S1750830AbWBXHgh convert rfc822-to-8bit (ORCPT ); Fri, 24 Feb 2006 02:36:37 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=C6lHjz42sMTzRVGSZOVAZSnoXT1XZaA0r48/ltdGSwbIart6zhOJpMDXVp8b6wCSMeSjRrev611akn9x+k60PGxK58lqLR8+KX+x8O1A9R8Hpr7buDb0MtunPQp1w4pj73DJqpYeL2n3HpjUWTc9r3y+9o1ybHCNMXnHIPMuE3w= Message-ID: <84144f020602232336l480f6a4el9f7f708f9c3a61e1@mail.gmail.com> Date: Fri, 24 Feb 2006 09:36:36 +0200 From: "Pekka Enberg" To: "Christoph Lameter" Subject: Re: slab: Remove SLAB_NO_REAP option Cc: "Andrew Morton" , "Alok Kataria" , manfred@colorfullife.com, linux-kernel@vger.kernel.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Content-Disposition: inline References: <20060223020957.478d4cc1.akpm@osdl.org> <1140719812.11455.1.camel@localhost> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1351 Lines: 32 On 2/23/06, Christoph Lameter wrote: > There is a loop but its broken by > > p = l3->slabs_free.next; > if (p == &(l3->slabs_free)) > break; > > One cache_reap() may scan the free list but once its free the code is > skipped. Which is _totally_ redundant for cache_cache. On 2/23/06, Christoph Lameter wrote: > There are potentially large amounts of other caches around that are also > basically static and which also would need any bypass that we may > implement. I don't think its worth it. It doesn't make much sense to create a separate object cache if you're not using it, we're better off converting those to kmalloc(). cache_cache is there to make bootstrapping easier, it is very unlikely that you ever have more than one page allocated for that cache which is why scanning the freelist _at all_ is silly. I think SLAB_NO_REAP should go away but we also must ensure we don't introduce a performance regression while doing that. Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/