Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp3778864ybb;
        Tue, 31 Mar 2020 11:48:43 -0700 (PDT)
X-Google-Smtp-Source: ADFU+vsYaZHXmTVwWhlfYRZ/qd9vgtn4OdeZJMBCIXJExEh+0b6oQNtYeA1Pmzit2+WHVj8c5qZL
X-Received: by 2002:a4a:874f:: with SMTP id a15mr4074635ooi.8.1585680523205;
        Tue, 31 Mar 2020 11:48:43 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1585680523; cv=none;
        d=google.com; s=arc-20160816;
        b=tKrojsJnq60YbnadLC+tRcIWmJkmnZrjyTd+W08nGK50QEIRUfwaLbjtMpn5nXrk1f
         wRbzZdoNia+hM3Jdhia68LeuS3oOAOSN8PW22CORp3LskUD4DSpQEMfIMrZA6DNVMO7S
         kbKpwJuWX0PwfSUZ+demX2KIQHNKT/V43ErXNTebArGlAPDHPll/yCp/31lJDQ7UM8TT
         puQ2yeRbD0tr4Z2QOMJr7i2BT2o1oh8XEPlN4cqIs10BVm6Ll0OkaFlcUZj6rzY4qtPe
         qfdXhMvOzPuyV7AUFIsFP6/P0F5ii4k26Ifd22DQtEoQsv7efa7Jm0cz7Vyofn1kapoA
         AScA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :organization:references:in-reply-to:message-id:subject:cc:to:from
         :date;
        bh=gu/mDvqfwmwnB+mc2dsqGmEAy0axRzll6TOVXESAuWA=;
        b=FdcGi5yYFyItM9AI/5+fqcGINIatacPhxCRMyxu++iZTGNAsQ++fA+IYVJf1uNqnBz
         A/5qhcUBQmvgmCSgJsmLNiux95KLGUC4vlwWjIJf6uVWF/swSTgL7BR4K6Kfu0w2Ul5P
         P3LyVbEsUDRsms22sXQ/ene0zGKavMxBKKHZdbVfUJvpwSYMxLgR7tdYE7bPjIrSfPUF
         5ie+Qy90f3J3Qgu9EwrCyhtKmzZzdbaDOuWImL6xi6yrhQfLv5rhFLfbff1F/GhpM/g3
         Ro+km7SOH3s3nJCfUEX8K4CVNJ4Gm5jmi45ZXmxGisZ1HvLwhN47x8J2whlAeEaY1Hcq
         nIfg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id w65si8405521ooa.42.2020.03.31.11.48.29;
        Tue, 31 Mar 2020 11:48:43 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727841AbgCaSrW (ORCPT <rfc822;rruigrok1@gmail.com> + 99 others);
        Tue, 31 Mar 2020 14:47:22 -0400
Received: from bhuna.collabora.co.uk ([46.235.227.227]:48738 "EHLO
        bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726209AbgCaSrV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 31 Mar 2020 14:47:21 -0400
Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        (Authenticated sender: bbrezillon)
        by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 09D86291976;
        Tue, 31 Mar 2020 19:47:20 +0100 (BST)
Date:   Tue, 31 Mar 2020 20:47:16 +0200
From:   Boris Brezillon <boris.brezillon@collabora.com>
To:     Weijie Gao <weijie.gao@mediatek.com>
Cc:     <linux-mtd@lists.infradead.org>,
        <linux-mediatek@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-mips@vger.kernel.org>,
        <devicetree@vger.kernel.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Boris Brezillon <bbrezillon@kernel.org>,
        Frieder Schrempf <frieder.schrempf@kontron.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Anders Roxell <anders.roxell@linaro.org>,
        Brendan Higgins <brendanhiggins@google.com>,
        Piotr Sroka <piotrs@cadence.com>,
        Mason Yang <masonccyang@mxic.com.tw>,
        Arnd Bergmann <arnd@arndb.de>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 1/2] mtd: rawnand: add driver support for MT7621 nand
 flash controller
Message-ID: <20200331204716.52f611db@collabora.com>
In-Reply-To: <1585678079-5999-1-git-send-email-weijie.gao@mediatek.com>
References: <1585678079-5999-1-git-send-email-weijie.gao@mediatek.com>
Organization: Collabora
X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-redhat-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 1 Apr 2020 02:07:58 +0800
Weijie Gao <weijie.gao@mediatek.com> wrote:

> This patch adds NAND flash controller driver for MediaTek MT7621 SoC.
> 
> The NAND flash controller is similar with controllers described in
> mtk_nand.c, except that the controller from MT7621 doesn't support DMA
> transmission, and some registers' offset and fields are different.
> 

Please don't duplicate driver the driver for those minor differences:
use regmap/reg_field to abstract reg field positions and make the DMA
optional.