Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] compiler.h: fix error in BUILD_BUG_ON() reporting
To:     Joe Perches <joe@perches.com>,
        Vegard Nossum <vegard.nossum@oracle.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-kernel@vger.kernel.org,
        Daniel Santos <daniel.santos@pobox.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Masahiro Yamada <yamada.masahiro@socionext.com>,
        Ian Abbott <abbotti@mev.co.uk>
References: <20200331112637.25047-1-vegard.nossum@oracle.com>
 <dc53b8704ec674cba636b41d7f55bf507a7bd7aa.camel@perches.com>
From:   Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Message-ID: <123d3606-cebf-4261-4b04-7d53d1fcdb07@prevas.dk>
Date:   Tue, 31 Mar 2020 20:56:49 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
In-Reply-To: <dc53b8704ec674cba636b41d7f55bf507a7bd7aa.camel@perches.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.1.149] (5.186.116.45) by AM6P191CA0054.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Tue, 31 Mar 2020 18:56:50 +0000
X-Originating-IP: [5.186.116.45]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2a8fa453-f5d8-4a8d-8d15-08d7d5a54597
X-MS-TrafficTypeDiagnostic: VI1PR10MB1837:
X-Microsoft-Antispam-PRVS: <VI1PR10MB183798126FAE38CE3FF60D5B93C80@VI1PR10MB1837.EURPRD10.PROD.OUTLOOK.COM>
X-MS-Oob-TLC-OOBClassifiers: OLM:8273;
X-Forefront-PRVS: 0359162B6D
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR10MB2765.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(376002)(366004)(396003)(346002)(39850400004)(136003)(54906003)(316002)(110136005)(86362001)(16526019)(478600001)(44832011)(956004)(186003)(66476007)(26005)(31696002)(66946007)(66556008)(31686004)(2616005)(4326008)(4744005)(2906002)(8676002)(16576012)(5660300002)(36756003)(6486002)(8936002)(81166006)(81156014)(8976002)(52116002);DIR:OUT;SFP:1102;
Received-SPF: None (protection.outlook.com: prevas.dk does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 3NBLE4605JJWO0X3QxGiejYnnvwX0YBHHBew345k1lylQ77Wv7VgFIirzPliPdegIOv+r+fN+ftOl6KKsZA2FucwraXDqi33Tu0N8tQ50iKShiZ8IEX/2EFv/70FrbnkKmMac+wiqNPmlei15j1D4Uz+n4afW5PaiweaD1qkA9bUQK+viSj+0zDiOGJHYO6XvQNw6Eeg27IB/1z+Ob7mUnEuDuGf5JqMvou8E58ZQNrK4G2Tmpt9pvryVT07nNhfPWSma4WE09YDkZafHpu6XsHP3yHG2DB4hFujBsZhoOgVkXvGJ1lHZI0SttDi1q8in3tPk37ZP2ttTnRqxEE74Ncj0QvkWu2Jtzj+0cq8b/mZe1NVAQEkg9Id8WzlOqfcKqDaVERcNBCheEB6KPJ04bpl68RKaI79PxfmQBxI+z42XNdgC+7+so6LB2G12kWP
X-MS-Exchange-AntiSpam-MessageData: shhP9JW+g3lUB+VTWvN8zG78579USA5uBHzsXB8ff6FB7EZ0rsHhVOo1cTQzZfTx0pdrzFFGz+KgPyKpslArWSk7BMT3s7GM7fvdudwtLs2Bi3WF0yYMOY5y9yxe05gJgvsA0T0KxPlmQzQd+DSyjQ==
X-OriginatorOrg: prevas.dk
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a8fa453-f5d8-4a8d-8d15-08d7d5a54597
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2020 18:56:51.1463
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: d350cf71-778d-4780-88f5-071a4cb1ed61
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hM55+/LZHLMzdDsAuB12uBPhe0SVDCx3Dnl8jDAhjHbKnMewpTQbYZCPCvaQO+fCGTUZXSRY0Nh+/cFMnhwhi40XBtmy0VZBLIHuv4Wt4pQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB1837
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 31/03/2020 20.20, Joe Perches wrote:
> On Tue, 2020-03-31 at 13:26 +0200, Vegard Nossum wrote:

>>  #define compiletime_assert(condition, msg) \
>> -	_compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
>> +	_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> 
> This might be better using something like __LINE__ ## _ ## __COUNTER__
> 
> as line # is somewhat useful to identify the specific assert in a file.
> 

Eh, if the assert fires, doesn't the compiler's diagnostics already
contain all kinds of location information?

Rasmus