Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
Date:   Tue, 31 Mar 2020 16:33:10 -0300
To:     "Liang, Kan" <kan.liang@linux.intel.com>
Cc:     Jin Yao <yao.jin@linux.intel.com>, jolsa@kernel.org,
        peterz@infradead.org, mingo@redhat.com,
        alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
        ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH] perf/x86/pmu-events: Use CPU_CLK_UNHALTED.THREAD in
 Kernel_Utilization metric
Message-ID: <20200331193310.GO9917@kernel.org>
References: <20200309013125.7559-1-yao.jin@linux.intel.com>
 <3e2ee47f-d351-64c3-b547-993a2b65f871@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3e2ee47f-d351-64c3-b547-993a2b65f871@linux.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Tue, Mar 31, 2020 at 03:30:25PM -0400, Liang, Kan escreveu:
> 
> 
> On 3/8/2020 9:31 PM, Jin Yao wrote:
> > The kernel utilization metric does multiplexing currently and is somewhat
> > unreliable. The problem is that it uses two instances of the fixed counter,
> > and the kernel has to multipleplex which causes errors. So should use
> > CPU_CLK_UNHALTED.THREAD instead.
> > 
> > Before:
> > 
> >    # perf stat -M Kernel_Utilization -- sleep 1
> > 
> >    Performance counter stats for 'sleep 1':
> > 
> >            1,419,425      cpu_clk_unhalted.ref_tsc:k
> >        <not counted>      cpu_clk_unhalted.ref_tsc	(0.00%)
> > 
> > After:
> > 
> >    # perf stat -M Kernel_Utilization -- sleep 1
> > 
> >    Performance counter stats for 'sleep 1':
> > 
> >              746,688      cpu_clk_unhalted.thread:k #      0.7 Kernel_Utilization
> >            1,088,348      cpu_clk_unhalted.thread
> > 
> > Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
> 
> 
> Reviewed-by: Kan Liang <kan.liang@linux.intel.com>

Thanks, applied.

- Arnaldo