Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <8a77ca985214cb0058e4defe4dcaa27a79eafacc.camel@gmail.com>
Subject: Re: [PATCH 2/2] ARM: DTS: Add devicetree file for the Galaxy S2
From:   =?UTF-8?Q?Pawe=C5=82?= Chmiel <pawel.mikolaj.chmiel@gmail.com>
To:     Marek Szyprowski <m.szyprowski@samsung.com>,
        Paul Cercueil <paul@crapouillou.net>
Cc:     Krzysztof Kozlowski <krzk@kernel.org>,
        Kukjin Kim <kgene@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, mark.rutland@arm.com,
        Stenkin Evgeniy <stenkinevgeniy@gmail.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Tue, 31 Mar 2020 21:50:19 +0200
In-Reply-To: <da888000-52b6-b0c6-76ac-8fc535d07a5d@samsung.com>
References: <20200312153411.13535-1-paul@crapouillou.net>
         <20200312153411.13535-2-paul@crapouillou.net> <20200313090011.GB7416@pi3>
         <CGME20200318142549eucas1p1793027850923ebad20b4691cba676671@eucas1p1.samsung.com>
         <D6.31.03891.A6F227E5@epmailinsp8.samsung.com>
         <6c549058-00f9-8526-a272-48c538166ccf@samsung.com>
         <X7728Q.UX8A28S31JO92@crapouillou.net>
         <6ca59c1b-2676-e69d-e4eb-4667a81d155f@samsung.com>
         <d9fe575926342b355f76e1f38fef62f0d7d38075.camel@gmail.com>
         <da888000-52b6-b0c6-76ac-8fc535d07a5d@samsung.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.1-2 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2020-03-31 at 21:29 +0200, Marek Szyprowski wrote:
> Hi
> 
> On 2020-03-31 17:29, Paweł Chmiel wrote:
> > On Tue, 2020-03-31 at 15:55 +0200, Marek Szyprowski wrote:
> > > Hi Paul,
> > > 
> > > On 2020-03-31 15:09, Paul Cercueil wrote:
> > > > Cc: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
> > > > 
> > > > Hi Marek,
> > > > 
> > > > Le mar. 31 mars 2020 à 7:36, Marek Szyprowski
> > > > <m.szyprowski@samsung.com> a écrit :
> > > > > Hi Paul,
> > > > > 
> > > > > On 2020-03-18 15:25, Paul Cercueil wrote:
> > > > > > > >    +    };
> > > > > > > >    +
> > > > > > > >    +    tsp_reg: regulator-1 {
> > > > > > > >    +        compatible = "regulator-fixed";
> > > > > > > >    +        regulator-name = "TSP_FIXED_VOLTAGES";
> > > > > > > >    +        regulator-min-microvolt = <3300000>;
> > > > > > > >    +        regulator-max-microvolt = <3300000>;
> > > > > > > >    +        gpio = <&gpl0 3 GPIO_ACTIVE_HIGH>;
> > > > > > > >    +        startup-delay-us = <70000>;
> > > > > > > >    +        enable-active-high;
> > > > > > > >    +        regulator-boot-on;
> > > > > > > >    +        regulator-always-on;
> > > > > > >   always-on and boot-on should not be needed. You have a consumer
> > > > > > > for this
> > > > > > >   regulator.
> > > > > >   About this: the touchscreen driver does not use a regulator, so I
> > > > > >   believe that's why these properties were here.
> > > > > > 
> > > > > >   I sent patches upstream to address the issue:
> > > > > >   https://protect2.fireeye.com/url?k=e8aedc29-b53072b3-e8af5766-0cc47a336fae-759579fd576d8382&u=https://lkml.org/lkml/2020/3/15/94
> > > > > > 
> > > > > > 
> > > > > >   I believe this means I cannot merge the i9100 devicetree until it is
> > > > > >   acked.
> > > > > One more information - similar change has been already posted, but it
> > > > > looks it got lost then: https://patchwork.kernel.org/patch/10550903/
> > > > I was aware of this patch, but didn't know it was sent upstream.
> > > > 
> > > > This other patch uses two regulators, vdd/avdd but doesn't give any
> > > > reason why.
> > > > 
> > > I've checked the UniversalC210 schematic, which uses the same
> > > touchscreen chip. There are 2 supplies to the touchscreen chip: 2.8V VDD
> > > and 3.3V AVDD. Both are enabled by the same GPIO pin though. There is
> > > however no reset GPIO pin there.
> > Hi
> > Don't remember now how it worked on Galaxy S1, but it looks like it has
> > the same setup - two regulators enabled by one GPIO pin.
> 
> It is quite common for the regulators to share the enable GPIO line, so 
> this is not an issue. Regulator framework supports such configuration 
> for ages. I'm curious about the reset GPIO line, which were made 
> mandatory for the regulators control in your patch. I didn't find it on 
> any schematic of the devices with this touch screen, but I don't have a 
> schematic of the Galaxy S1. IMHO the reset signal is simply derived from 
> the supply regulators with some simple circuit, but I don't have 
> schematic of that part.
Hi
Regarding this change - it was suggested during review of v1 version of
those patches. It's first reply here 
https://patchwork.kernel.org/patch/10524007/

> 
> Best regards