Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 31 Mar 2020 15:13:49 -0600
From:   Rob Herring <robh@kernel.org>
To:     Daniel Lezcano <daniel.lezcano@linaro.org>
Cc:     Amit Kucheria <amit.kucheria@verdurent.com>,
        Lukasz Luba <lukasz.luba@arm.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Matthias Kaehlcke <mka@chromium.org>,
        Zhang Rui <rui.zhang@intel.com>,
        Linux PM list <linux-pm@vger.kernel.org>,
        DTML <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] dt-bindings: thermal: Add yaml bindings for
 thermal zones
Message-ID: <20200331211349.GA18149@bogus>
References: <cover.1585117436.git.amit.kucheria@linaro.org>
 <9c447186008ef2e3f4c3e712458dc0ddcd8a8b03.1585117436.git.amit.kucheria@linaro.org>
 <81b0cbe1-23c8-b4a3-4775-62e7d6c49b6b@arm.com>
 <CAP245DWS=yqNQpbk3Y8_0KjcBurSyQbNW9jqepSz8LC=ruFWhA@mail.gmail.com>
 <CAHLCerMRcPmE70kN1Cyxio4_Dd1OoWT3iZ4vpzYKQVfORS336Q@mail.gmail.com>
 <693bda26-1eed-a886-2ce0-7b3a2ca410d2@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <693bda26-1eed-a886-2ce0-7b3a2ca410d2@linaro.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 30, 2020 at 03:07:53PM +0200, Daniel Lezcano wrote:
> 
> Hi Amit,
> 
> On 30/03/2020 12:34, Amit Kucheria wrote:
> 
> [ ... ]
> 
> >>> I don't know why it's not consistent with the actual code in
> >>> of-thermal.c, where there is even a comment stated: /* For now,
> >>> thermal framework supports only 1 sensor per zone */
> >>>
> >>> I think this is the place where developers should be informed
> >>> about the limitation and not even try to put more sensors into
> >>> the list.
> >>
> >> That is a good point. I'm currently "porting" the existing
> >> binding as described in thermal.txt to yaml. If you look at some
> >> of the example (c) in there, the bindings allow many sensors to a
> >> zone mapping but the thermal core doesn't implement that
> >> functionality.
> >>
> >> So should we fix the core code or change the bindings? Thoughts -
> >> Rob, Daniel, Rui?
> >
> > Rob, Daniel: Any comments? We don't have any concerns for Linux
> > backward compatibility since multiple sensors per zone isn't used
> > anywhere. But asking since bindings are supposed to be
> > OS-agnostic.
> 
> IMO, we should remove it as it is not used anywhere.
> 
> We still have to decide how we aggregate multiple sensors.

The schema only needs to pass what currently exists (assuming no 
errors), so extending it later is fine with me.

Rob