Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 31 Mar 2020 16:41:35 -0700
From:   Bjorn Andersson <bjorn.andersson@linaro.org>
To:     Rishabh Bhatnagar <rishabhb@codeaurora.org>
Cc:     linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
        devicetree@vger.kernel.org, robh@kernel.org,
        psodagud@codeaurora.org, tsoni@codeaurora.org,
        sidgup@codeaurora.org
Subject: Re: [PATCH] dt-bindings: remoteproc: Add interconnect property
Message-ID: <20200331234135.GC267644@minitux>
References: <1585357496-6368-1-git-send-email-rishabhb@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1585357496-6368-1-git-send-email-rishabhb@codeaurora.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri 27 Mar 18:04 PDT 2020, Rishabh Bhatnagar wrote:

> Allow proxy voting/unvoting of bus bandwidth for remote
> processors. This property will specify the bus-master and
> slave so that remoteproc platform driver can make the proxy
> vote for bus bandwidth.
> 
> Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> index 9938918..529b0a0 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> @@ -111,6 +111,17 @@ on the Qualcomm ADSP Hexagon core.
>  	qcom,sm8150-slpi-pas:
>  		    must be "lcx", "lmx", "load_state"
>  
> +- interconnect:

This should be plural; "interconnects".

> +	Usage: optional
> +	Value type: <prop-encoded-array>
> +	Definition: Specifies the interconnect bus-master and bus-slave for
> +		    bandwidth voting during proxy vote/unvote.
> +
> +- interconnect-names:
> +	Usage: optional
> +	Value type: <stringlist>
> +	Definition: The interconnect name depends on the compatible string

This should be elaborated upon, similar to e.g. power-domain-names.

Regards,
Bjorn

> +
>  - memory-region:
>  	Usage: required
>  	Value type: <phandle>
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project