Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Jiaxun Yang <jiaxun.yang@flygoat.com>
To:     linux-mips@vger.kernel.org
Cc:     Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Rob Herring <robh+dt@kernel.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Huacai Chen <chenhc@lemote.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Andrew Murray <amurray@thegoodpenguin.co.uk>,
        Paul Burton <paulburton@kernel.org>, linux-pci@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Message-ID: <20200401030658.1174045-2-jiaxun.yang@flygoat.com>
Subject: [PATCH v2 1/5] PCI: OF: Don't remap iospace on unsupported platform
Date:   Wed,  1 Apr 2020 11:06:45 +0800
In-Reply-To: <20200401030658.1174045-1-jiaxun.yang@flygoat.com>
References: <20200401030658.1174045-1-jiaxun.yang@flygoat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=utf8
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

There are some platforms doesn't support iospace remapping
like MIPS. However, our PCI code will try to remap iospace
unconditionally and reject io resources on these platforms.

So we should remove iospace remapping check and use a range
check instead on these platforms.

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
 drivers/pci/of.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/pci/of.c b/drivers/pci/of.c
index 81ceeaa6f1d5..36e8761b66c6 100644
--- a/drivers/pci/of.c
+++ b/drivers/pci/of.c
@@ -547,12 +547,21 @@ int pci_parse_request_of_pci_ranges(struct device *de=
v,
=20
 =09=09switch (resource_type(res)) {
 =09=09case IORESOURCE_IO:
+#if defined(PCI_IOBASE) && defined(CONFIG_MMU)
 =09=09=09err =3D devm_pci_remap_iospace(dev, res, iobase);
 =09=09=09if (err) {
 =09=09=09=09dev_warn(dev, "error %d: failed to map resource %pR\n",
 =09=09=09=09=09 err, res);
 =09=09=09=09resource_list_destroy_entry(win);
 =09=09=09}
+#else
+=09=09=09/* Simply check if IO is inside the range */
+=09=09=09if (res->end > IO_SPACE_LIMIT) {
+=09=09=09=09dev_warn(dev, "resource %pR out of the IO range\n",
+=09=09=09=09=09res);
+=09=09=09=09resource_list_destroy_entry(win);
+=09=09=09}
+#endif
 =09=09=09break;
 =09=09case IORESOURCE_MEM:
 =09=09=09res_valid |=3D !(res->flags & IORESOURCE_PREFETCH);
--=20
2.26.0.rc2