Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp278353ybb; Tue, 31 Mar 2020 23:15:52 -0700 (PDT) X-Google-Smtp-Source: APiQypK8TwRY/vkHy0LHR004c/4YFsqg27FJ1MkrGM7Na816mdGCNLwJNkfExHZKJz3sMrtMjVM+ X-Received: by 2002:aca:1c02:: with SMTP id c2mr1638994oic.125.1585721752092; Tue, 31 Mar 2020 23:15:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585721752; cv=none; d=google.com; s=arc-20160816; b=X1IOxHSBdSIKGxsIQUkET9tJK/MD3OcFX7LxBgSJO1yTi7wL30sR18Fu6Zui9fAFxt vio6vWhvVYw0tif1XhfHjG+ka6QJFaeoqFBM1+KGvPUEBWOrFslpw5IexLqSKzHFZ76x fCCpDOrD6VyaPzg4sBvxwuVApgOKIfpmGqBCrn0RDDTr2tlVRwZsdeFakBmABbgr192v AD17l8YA8LjHoGL2OzD5O3HGwgO8yDeBWCtO4ebIBAI6VvH2UZWHH/BCVJKBl5M3aI3g MIyI2Ciz8xmFvKjfYDzS8syhWqRqvhHVsRX0DR7ulfHQF8a/3zbTASZEeo07JF7al7Fh v5iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :mime-version:references:in-reply-to:date:subject:cc:to:from; bh=RKAxdUZXWEFX/+la9oiEb2bdz2Xx8mQhtoPfFav6rkg=; b=0Mv0i35Vm1KmlgnY0c61JSz7asKePEHt6ZqaZacVsL73r57bQFvhfngcwX/iweok5L M8BRkR5alb0cOkpIDBhJI7TmgpmtkdbqMEJgwrXwwrlz8NMPdvxlfSJpixeShrhycbxk l7sYjrAbVnXroI5TuERhs+KMaQMfvk4Sdme2+gGezNNiSbFNGxGMJOl+kbb/u2boTUxq 5C3WwgvuYsDHFJNZbgcrurpP8OsGM8XOnLt3zCxIuwQo1gbcHmPlZK5O8YUC3H5kLmQ6 3aYV3P8iR8PUrXYjpfRCEhBT5W4VzPqJWcx5PXuJlikLvcTRlebqgjFBZOy3aJ/zwPfe vjdg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l6si418917otq.134.2020.03.31.23.15.39; Tue, 31 Mar 2020 23:15:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731937AbgDAGOX (ORCPT + 99 others); Wed, 1 Apr 2020 02:14:23 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:60672 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731895AbgDAGOW (ORCPT ); Wed, 1 Apr 2020 02:14:22 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03163eiu025235 for ; Wed, 1 Apr 2020 02:14:21 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 304k3h392h-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 01 Apr 2020 02:14:21 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 1 Apr 2020 07:14:12 +0100 Received: from b06avi18878370.portsmouth.uk.ibm.com (9.149.26.194) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 1 Apr 2020 07:14:07 +0100 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0316EDFl47448430 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 1 Apr 2020 06:14:13 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3E0E3A404D; Wed, 1 Apr 2020 06:14:13 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A2E02A4051; Wed, 1 Apr 2020 06:14:09 +0000 (GMT) Received: from bangoria.ibmuc.com (unknown [9.199.48.114]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 1 Apr 2020 06:14:09 +0000 (GMT) From: Ravi Bangoria To: mpe@ellerman.id.au, mikey@neuling.org Cc: apopple@linux.ibm.com, paulus@samba.org, npiggin@gmail.com, christophe.leroy@c-s.fr, naveen.n.rao@linux.vnet.ibm.com, peterz@infradead.org, jolsa@kernel.org, oleg@redhat.com, fweisbec@gmail.com, mingo@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, ravi.bangoria@linux.ibm.com Subject: [PATCH v2 08/16] powerpc/watchpoint: Disable all available watchpoints when !dawr_force_enable Date: Wed, 1 Apr 2020 11:43:01 +0530 X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200401061309.92442-1-ravi.bangoria@linux.ibm.com> References: <20200401061309.92442-1-ravi.bangoria@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 20040106-0012-0000-0000-0000039C1A69 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20040106-0013-0000-0000-000021D928E6 Message-Id: <20200401061309.92442-9-ravi.bangoria@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676 definitions=2020-03-31_07:2020-03-31,2020-03-31 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 impostorscore=0 mlxlogscore=655 lowpriorityscore=0 malwarescore=0 mlxscore=0 bulkscore=0 clxscore=1015 suspectscore=0 adultscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004010049 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Instead of disabling only first watchpoint, disable all available watchpoints while clearing dawr_force_enable. Signed-off-by: Ravi Bangoria --- arch/powerpc/kernel/dawr.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/kernel/dawr.c b/arch/powerpc/kernel/dawr.c index 311e51ee09f4..5c882f07ac7d 100644 --- a/arch/powerpc/kernel/dawr.c +++ b/arch/powerpc/kernel/dawr.c @@ -50,9 +50,13 @@ int set_dawr(struct arch_hw_breakpoint *brk, int nr) return 0; } -static void set_dawr_cb(void *info) +static void disable_dawrs(void *info) { - set_dawr(info, 0); + struct arch_hw_breakpoint null_brk = {0}; + int i; + + for (i = 0; i < nr_wp_slots(); i++) + set_dawr(&null_brk, i); } static ssize_t dawr_write_file_bool(struct file *file, @@ -74,7 +78,7 @@ static ssize_t dawr_write_file_bool(struct file *file, /* If we are clearing, make sure all CPUs have the DAWR cleared */ if (!dawr_force_enable) - smp_call_function(set_dawr_cb, &null_brk, 0); + smp_call_function(disable_dawrs, NULL, 0); return rc; } -- 2.21.1