Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp390119ybb; Wed, 1 Apr 2020 01:59:30 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuPervifsJDeXLCqzZVwRIdmUQvHxhxnXu9ENdamk5HGrQ19kEOVPnrgfQSeviZB5DsJWqS X-Received: by 2002:a9d:525:: with SMTP id 34mr6003268otw.80.1585731570443; Wed, 01 Apr 2020 01:59:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585731570; cv=none; d=google.com; s=arc-20160816; b=KvSLLVcPkAfBQzqwxUEl0gdJKSruyIBQp9YPs/pK2YYr0SxBQEOhf9rwPKx5ISNXRT 7rFfLb7e5km+myqWcXPtYrZ5f3kUjZhosxKs3DuiqPkbg40349wLnAhd/LnbngbA62Da NkCMv10rPFME7sYbVSevCcWNNU42X5GsfY3Q+yboW0ybjFaQBO6uKzjOScg1LLEERNlq gGFEyuCfg1yVetzr4uynGy/xr/aysVJnV4c8UBxVzwqrO2y9EfDZ71IpgCcgj7XOK6vd eAuxLw0/dhip5Jv4cWvKZ/H+lVo4uztvhzlfFvynEXiiMz3qp2v8hxOKhb5+LWuarEvl QUqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date:from :references:cc:to:subject; bh=Mrp0t6mXW0QRrEOrb6VQPpzfmAFGcAb9CQoXw0Dz89w=; b=jTyMFc3Do5/cZN7jNjOntlba0dCdffaQJj23phCKF8mWjd4QA1Egl1wjSEd1D3drK0 drhDHRs8yC0s4aLWxuOP1gGBwWzVx0maHGm9jAK+Oido5UVhRuM7PipV65gqeo7HD5FF djfI2RfvyJuYdAZlwAirUAv54Ii0vpzZv3BMnTNXvuBalrKsBruUHdRLDK0Fu2Hp+Djh z1LuDkiXrODnhPYo0XAuOU+bkl2DK2BAznulnuTlpRKN1cXqtnMY61lqjLGwombcT8/d MbO72JsRBMjNK5G0WIT9avdCc7CllSD9JHVt3e8cTsl7VGBpyB9jGSXolk1skJgwhYU3 juWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r6si538035oti.159.2020.04.01.01.59.17; Wed, 01 Apr 2020 01:59:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732110AbgDAI5i (ORCPT + 99 others); Wed, 1 Apr 2020 04:57:38 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:27368 "EHLO mx0b-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726974AbgDAI5i (ORCPT ); Wed, 1 Apr 2020 04:57:38 -0400 Received: from pps.filterd (m0127361.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0318Y8Qt125161 for ; Wed, 1 Apr 2020 04:57:36 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 304mcb5vh2-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 01 Apr 2020 04:57:36 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 1 Apr 2020 09:57:21 +0100 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp01.uk.ibm.com (192.168.101.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Wed, 1 Apr 2020 09:57:16 +0100 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0318vSDq13565964 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 1 Apr 2020 08:57:28 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 832A542052; Wed, 1 Apr 2020 08:57:28 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 249FA42049; Wed, 1 Apr 2020 08:57:25 +0000 (GMT) Received: from [9.199.48.114] (unknown [9.199.48.114]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 1 Apr 2020 08:57:24 +0000 (GMT) Subject: Re: [PATCH v2 06/16] powerpc/watchpoint: Provide DAWR number to __set_breakpoint To: Christophe Leroy Cc: mpe@ellerman.id.au, mikey@neuling.org, apopple@linux.ibm.com, paulus@samba.org, npiggin@gmail.com, naveen.n.rao@linux.vnet.ibm.com, peterz@infradead.org, jolsa@kernel.org, oleg@redhat.com, fweisbec@gmail.com, mingo@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Ravi Bangoria References: <20200401061309.92442-1-ravi.bangoria@linux.ibm.com> <20200401061309.92442-7-ravi.bangoria@linux.ibm.com> <89f43001-0fa4-1394-4158-878fca4962e3@c-s.fr> From: Ravi Bangoria Date: Wed, 1 Apr 2020 14:27:24 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <89f43001-0fa4-1394-4158-878fca4962e3@c-s.fr> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 20040108-4275-0000-0000-000003B77DD0 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20040108-4276-0000-0000-000038CCD00F Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.676 definitions=2020-03-31_07:2020-03-31,2020-03-31 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 bulkscore=0 mlxscore=0 adultscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 malwarescore=0 phishscore=0 mlxlogscore=719 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004010073 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/1/20 12:33 PM, Christophe Leroy wrote: > > > Le 01/04/2020 à 08:12, Ravi Bangoria a écrit : >> Introduce new parameter 'nr' to __set_breakpoint() which indicates >> which DAWR should be programed. Also convert current_brk variable >> to an array. >> >> Signed-off-by: Ravi Bangoria >> --- >>   arch/powerpc/include/asm/debug.h         |  2 +- >>   arch/powerpc/include/asm/hw_breakpoint.h |  2 +- >>   arch/powerpc/kernel/hw_breakpoint.c      |  8 ++++---- >>   arch/powerpc/kernel/process.c            | 14 +++++++------- >>   arch/powerpc/kernel/signal.c             |  2 +- >>   arch/powerpc/xmon/xmon.c                 |  2 +- >>   6 files changed, 15 insertions(+), 15 deletions(-) >> >> diff --git a/arch/powerpc/include/asm/debug.h b/arch/powerpc/include/asm/debug.h >> index 7756026b95ca..6228935a8b64 100644 >> --- a/arch/powerpc/include/asm/debug.h >> +++ b/arch/powerpc/include/asm/debug.h >> @@ -45,7 +45,7 @@ static inline int debugger_break_match(struct pt_regs *regs) { return 0; } >>   static inline int debugger_fault_handler(struct pt_regs *regs) { return 0; } >>   #endif >> -void __set_breakpoint(struct arch_hw_breakpoint *brk); >> +void __set_breakpoint(struct arch_hw_breakpoint *brk, int nr); > > Same, I think it would make more sense to have nr as first argument. Sorry, didn't get your point. How will that help? Ravi