Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp473999ybb; Wed, 1 Apr 2020 03:51:16 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuIi/DkdADelRoiu1KXmH32FrD/Y5xkKZpZ3HMf9OyxyHLB1pi2PgmEvg0YfAIJlW2e0MiN X-Received: by 2002:a9d:ef6:: with SMTP id 109mr15188965otj.43.1585738276386; Wed, 01 Apr 2020 03:51:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585738276; cv=none; d=google.com; s=arc-20160816; b=FsqgRx3jaPWIFWwEAbaYi+IbTprBfVBv1bPfNb7xS5Aud1u29bPna5Qezv2w5VzHgm ZONk6SzRUx9q1l+iWEZ1rNX6tCVXXk85Jp1ISd7hgi29P26EWDp3E2uBEb1I4q5atwDH BRNcp0rZVE8glf7/DIV7BR2EPDy6uGA/7hdJnRb23MuPSvexs47xW/fXRtEacTRTsNPR NaHbCoGLZzrJWypUnW9/ThhBlttxphAvBaNfXRRWTigEnTuJQRN8Oyr70h6udUc3ixLZ KTUlaWtnceicxc9lyd2wxveP271CiQTxm+bzZB6YJrhnM2J71pqw/YKefJtc68NMpZ6+ RTQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=8pJCj0G/6LXyT9rREmUTe03ld7u8N9926+dPdFwhPNU=; b=xc8GSpc/280xAKuHs42yI+KwR3g29i3HhNNGb1KJxgDSgIGWpMXdNHsZsj4T6hBEHA Rhs+ksJ66z5ftdjkkK3u8guccxu2tg8FIcnjECoqOEXIvdJQP5Xsm+B/WO6qu37qLZJM aH56wBDkTGhdDlZq3OytxOVGSL4VLNYLlu8U2iVYWwoFXSCNCFwQ2fVV5iqXJjR3P63/ NBe7GV/eSoowZB38OZ2g8nEdQgbTXZWQDRSGRqP1Ic8/Hn3UpGTZm1I/TjzdnHx/TpN7 I5Wrjl7s+ARtopChLZBLXz9wD25J+9fGtvpw/86tvHWpPF7QydqXamyrwrtKt75x7D5Q d+wg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s13si707457otg.35.2020.04.01.03.51.03; Wed, 01 Apr 2020 03:51:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732067AbgDAKtd (ORCPT + 99 others); Wed, 1 Apr 2020 06:49:33 -0400 Received: from foss.arm.com ([217.140.110.172]:48630 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726974AbgDAKtd (ORCPT ); Wed, 1 Apr 2020 06:49:33 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AA5471FB; Wed, 1 Apr 2020 03:49:32 -0700 (PDT) Received: from [10.37.12.63] (unknown [10.37.12.63]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1A4CC3F68F; Wed, 1 Apr 2020 03:49:21 -0700 (PDT) Subject: Re: [PATCH v5 4/5] thermal: devfreq_cooling: Refactor code and switch to use Energy Model To: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-imx@nxp.com Cc: Morten.Rasmussen@arm.com, Dietmar.Eggemann@arm.com, javi.merino@arm.com, cw00.choi@samsung.com, b.zolnierkie@samsung.com, rjw@rjwysocki.net, sudeep.holla@arm.com, viresh.kumar@linaro.org, nm@ti.com, sboyd@kernel.org, rui.zhang@intel.com, amit.kucheria@verdurent.com, daniel.lezcano@linaro.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, rostedt@goodmis.org, qperret@google.com, bsegall@google.com, mgorman@suse.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, kernel@pengutronix.de, khilman@kernel.org, agross@kernel.org, bjorn.andersson@linaro.org, robh@kernel.org, matthias.bgg@gmail.com, steven.price@arm.com, tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com, airlied@linux.ie, daniel@ffwll.ch, liviu.dudau@arm.com, lorenzo.pieralisi@arm.com, patrick.bellasi@matbug.net, orjan.eide@arm.com, rdunlap@infradead.org, mka@chromium.org References: <20200318114548.19916-1-lukasz.luba@arm.com> <20200318114548.19916-5-lukasz.luba@arm.com> From: Lukasz Luba Message-ID: Date: Wed, 1 Apr 2020 11:49:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200318114548.19916-5-lukasz.luba@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/18/20 11:45 AM, Lukasz Luba wrote: > The overhauled Energy Model (EM) framework support also devfreq devices. > The unified API interface of the EM can be used in the thermal subsystem to > not duplicate code. The power table now is taken from EM structure and > there is no need to maintain calculation for it locally. In case when the > EM is not provided by the device a simple interface for cooling device is > used. > > There is also an improvement in code related to enabling/disabling OPPs, > which prevents from race condition with devfreq governors. > > [lkp: Reported the build warning] > Reported-by: kbuild test robot > Reviewed-by: Steven Rostedt (VMware) # for tracing code > Signed-off-by: Lukasz Luba > --- > drivers/thermal/devfreq_cooling.c | 474 ++++++++++++++++-------------- > include/linux/devfreq_cooling.h | 39 +-- > include/trace/events/thermal.h | 19 +- > 3 files changed, 277 insertions(+), 255 deletions(-) > Gentle ping. Daniel or Amit could you have a look at this patch? Regards, Lukasz