Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 1 Apr 2020 13:12:17 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Li Yueyi <liyueyi@live.com>
Cc:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        liyueyi <liyueyi@xiaomi.com>
Subject: Re: [PATCH] kthread: set kthread state to TASK_IDLE.
Message-ID: <20200401111217.GC20713@hirez.programming.kicks-ass.net>
References: <DM6PR11MB3531D3B164357B2DC476102DDFC90@DM6PR11MB3531.namprd11.prod.outlook.com>
 <20200401093904.GX20713@hirez.programming.kicks-ass.net>
 <DM6PR11MB3531904888FBD86F4ED43009DFC90@DM6PR11MB3531.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DM6PR11MB3531904888FBD86F4ED43009DFC90@DM6PR11MB3531.namprd11.prod.outlook.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

On Wed, Apr 01, 2020 at 10:40:28AM +0000, Li Yueyi wrote:
> I create a kthread to do some work will trigger system restart, i don`t wake it up immediately but wakeup it in a HW irq handler.
> So this kthread sleeps in TASK_UNINTERRUPTIBLE state until the HW irq coming up.
> 
> Did i do something wrong?
> Should i wake it up immediately and then call wait_event_xxxx function to sleep it?

This!