Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   <ansuelsmth@gmail.com>
To:     "'Rob Herring'" <robh@kernel.org>
Cc:     "'Stanimir Varbanov'" <svarbanov@mm-sol.com>,
        "'Andy Gross'" <agross@kernel.org>,
        "'Bjorn Andersson'" <bjorn.andersson@linaro.org>,
        "'Bjorn Helgaas'" <bhelgaas@google.com>,
        "'Mark Rutland'" <mark.rutland@arm.com>,
        "'Lorenzo Pieralisi'" <lorenzo.pieralisi@arm.com>,
        "'Andrew Murray'" <amurray@thegoodpenguin.co.uk>,
        "'Philipp Zabel'" <p.zabel@pengutronix.de>,
        <linux-arm-msm@vger.kernel.org>, <linux-pci@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20200320183455.21311-1-ansuelsmth@gmail.com> <20200320183455.21311-8-ansuelsmth@gmail.com> <20200331173241.GA25681@bogus>
In-Reply-To: <20200331173241.GA25681@bogus>
Subject: R: [PATCH 08/12] devicetree: bindings: pci: add phy-tx0-term-offset to qcom,pcie
Date:   Wed, 1 Apr 2020 14:09:54 +0200
Message-ID: <013b01d6081e$74e3b710$5eab2530$@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Language: it
Thread-Index: AQF7DJ39byRpk4MoIUXZtcQDafvd5gI+20GLAtWBGGmo8YCbwA==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> -----Messaggio originale-----
> Da: Rob Herring <robh@kernel.org>
> Inviato: marted=EC 31 marzo 2020 19:33
> A: Ansuel Smith <ansuelsmth@gmail.com>
> Cc: Stanimir Varbanov <svarbanov@mm-sol.com>; Andy Gross
> <agross@kernel.org>; Bjorn Andersson <bjorn.andersson@linaro.org>;
> Bjorn Helgaas <bhelgaas@google.com>; Mark Rutland
> <mark.rutland@arm.com>; Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>;
> Andrew Murray <amurray@thegoodpenguin.co.uk>; Philipp Zabel
> <p.zabel@pengutronix.de>; linux-arm-msm@vger.kernel.org; linux-
> pci@vger.kernel.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Oggetto: Re: [PATCH 08/12] devicetree: bindings: pci: add =
phy-tx0-term-
> offset to qcom,pcie
>=20
> On Fri, Mar 20, 2020 at 07:34:50PM +0100, Ansuel Smith wrote:
> > Document phy-tx0-term-offset propriety to qcom pcie driver
>=20
> propriety?
>=20
> >
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/pci/qcom,pcie.txt | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt
> b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
> > index 6efcef040741..8c1d014f37b0 100644
> > --- a/Documentation/devicetree/bindings/pci/qcom,pcie.txt
> > +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
> > @@ -254,6 +254,12 @@
> >  			- "perst-gpios"	PCIe endpoint reset signal line
> >  			- "wake-gpios"	PCIe endpoint wake signal line
> >
> > +- phy-tx0-term-offset:
>=20
> Needs a vendor prefix.
>=20

So I should change to qcom,phy-tx0-term-offset  right?

> > +	Usage: optional
> > +	Value type: <u32>
> > +	Definition: If not defined is 0. In ipq806x is set to 7. In newer
> > +				revision (v2.0) the offset is zero.
> > +
> >  * Example for ipq/apq8064
> >  	pcie@1b500000 {
> >  		compatible =3D "qcom,pcie-apq8064", "qcom,pcie-ipq8064",
> "snps,dw-pcie";
> > @@ -293,6 +299,7 @@
> >  		reset-names =3D "axi", "ahb", "por", "pci", "phy", "ext";
> >  		pinctrl-0 =3D <&pcie_pins_default>;
> >  		pinctrl-names =3D "default";
> > +		phy-tx0-term-offset =3D <7>;
> >  	};
> >
> >  * Example for apq8084
> > --
> > 2.25.1
> >