Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 1 Apr 2020 14:26:06 +0200
From:   Peter Zijlstra <peterz@infradead.org>
To:     Daniel Bristot de Oliveira <bristot@redhat.com>
Cc:     John Mathew <john.mathew@unikie.com>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, corbet@lwn.net, mingo@redhat.com,
        juri.lelli@redhat.com, vincent.guittot@linaro.org,
        dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com,
        mgorman@suse.de, tsbogend@alpha.franken.de,
        lukas.bulwahn@gmail.com, x86@kernel.org,
        linux-mips@vger.kernel.org, tglx@linutronix.de,
        mostafa.chamanara@basemark.com
Subject: Re: [RFC PATCH 2/3] docs: scheduler: Add scheduler overview
 documentation
Message-ID: <20200401122606.GF20713@hirez.programming.kicks-ass.net>
References: <20200401100029.1445-1-john.mathew@unikie.com>
 <20200401100029.1445-3-john.mathew@unikie.com>
 <20200401103520.GA20713@hirez.programming.kicks-ass.net>
 <9614b346-a848-3e01-eea7-6237b759dad6@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9614b346-a848-3e01-eea7-6237b759dad6@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 01, 2020 at 01:47:04PM +0200, Daniel Bristot de Oliveira wrote:
> On 4/1/20 12:35 PM, Peter Zijlstra wrote:
> >> +Scheduler State Transition
> >> +==========================
> >> +
> >> +A very high level scheduler state transition flow with a few states can be
> >> +depicted as follows.
> >> +
> >> +.. kernel-render:: DOT
> >> +   :alt: DOT digraph of Scheduler state transition
> >> +   :caption: Scheduler state transition
> >> +
> >> +   digraph sched_transition {
> >> +      node [shape = point,  label="exisiting task\n calls fork()"]; fork
> >> +      node [shape = box, label="TASK_NEW\n(Ready to run)"] tsk_new;
> >> +      node [shape = box, label="TASK_RUNNING\n(Ready to run)"] tsk_ready_run;
> >> +      node [shape = box, label="TASK_RUNNING\n(Running)"] tsk_running;
> >> +      node [shape = box, label="TASK_DEAD\nEXIT_ZOMBIE"] exit_zombie;
> >> +      node [shape = box, label="TASK_INTERRUPTIBLE\nTASK_UNINTERRUPTIBLE\nTASK_WAKEKILL"] tsk_int;
> >> +      fork -> tsk_new [ label = "task\nforks" ];
> >> +      tsk_new -> tsk_ready_run;
> >> +      tsk_ready_run -> tsk_running [ label = "schedule() calls context_switch()" ];
> >> +      tsk_running -> tsk_ready_run [ label = "task is pre-empted" ];
> >> +      subgraph int {
> >> +         tsk_running -> tsk_int [ label = "task needs to wait for event" ];
> >> +         tsk_int ->  tsk_ready_run [ label = "event occurred" ];
> >> +      }
> >> +      tsk_int ->  exit_zombie [ label = "task exits via do_exit()" ];
> >> +   }
> > And that is a prime example of why I hates RST, it pretty much mandates
> > you view this with something other than a text editor.
> 
> The good thing about the dot format is that we can convert it to many other
> formats, including text:

Oh, I know and love dot files, I generate them occasionally. But they
stink as end-result, which is what it is here.

If you can't read a document (or worse comment) in a code editor it's
broken (and yes, I know some subsystems have a different opinion here).