Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] kthread: set kthread state to TASK_IDLE.
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        liyueyi <liyueyi@xiaomi.com>
References: <DM6PR11MB3531D3B164357B2DC476102DDFC90@DM6PR11MB3531.namprd11.prod.outlook.com>
 <20200401093904.GX20713@hirez.programming.kicks-ass.net>
 <DM6PR11MB3531904888FBD86F4ED43009DFC90@DM6PR11MB3531.namprd11.prod.outlook.com>
 <20200401111217.GC20713@hirez.programming.kicks-ass.net>
From:   Yueyi Li <liyueyi@live.com>
Message-ID: <DM6PR11MB3531E5C5F509766C47CFF880DFC90@DM6PR11MB3531.namprd11.prod.outlook.com>
Date:   Wed, 1 Apr 2020 20:27:00 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
In-Reply-To: <20200401111217.GC20713@hirez.programming.kicks-ass.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [192.168.0.6] (123.123.4.113) by HK2PR0401CA0012.apcprd04.prod.outlook.com (2603:1096:202:2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20 via Frontend Transport; Wed, 1 Apr 2020 12:27:18 +0000
X-Microsoft-Original-Message-ID: <461a0710-6bb6-ead4-5547-9bf7d6ba1769@live.com>
X-TMN:  [crgSFpb+6MmX2byfO7XtMQIJRdvZ8pp0]
X-MS-PublicTrafficType: Email
X-IncomingHeaderCount: 50
X-EOPAttributedMessage: 0
X-MS-Office365-Filtering-Correlation-Id: 489820e0-ea73-45cd-013c-08d7d6380635
X-MS-TrafficTypeDiagnostic: DM6NAM10HT156:
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: HC7+9lJySebkLqJ95egMGB3jXbzRylzxqiTufXo4vLgRb7NMV5O2xPenN5YUZS1Edoxe0bQmYx9zMxfqxFUiAiUpRDTxUkLUfFY53Rck+QhqWbR+UcFfdAU/fM42GkWVOHZWAPlQxD0CfviqsVG5scVldPf/YQYz7/Iy60caU3pZ2s9sNH4rMq7GbBywR2fb
X-MS-Exchange-AntiSpam-MessageData: z5NYoVp1e+MEVR+tXbLH4yO/gI2d1jGx235iELTHRib4NaJ03+4TJATRqP3xpsBQmMl4t3iVsgS0+gP5KSjCdZc/gXe+Cz/zZNKlMhrgj2/1vNgGZggdR58FslCQeQ1tnIYMYcbMw+j/H2AdZQMQFQ==
X-OriginatorOrg: live.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 489820e0-ea73-45cd-013c-08d7d6380635
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2020 12:27:21.0801
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-FromEntityHeader: Internet
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM10HT156
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2020/4/1 19:12, Peter Zijlstra wrote:
> 
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
> 
> On Wed, Apr 01, 2020 at 10:40:28AM +0000, Li Yueyi wrote:
>> I create a kthread to do some work will trigger system restart, i don`t wake it up immediately but wakeup it in a HW irq handler.
>> So this kthread sleeps in TASK_UNINTERRUPTIBLE state until the HW irq coming up.
>>
>> Did i do something wrong?
>> Should i wake it up immediately and then call wait_event_xxxx function to sleep it?
> 
> This!
> Oh~, Sorry about top-posting and....thanks for your answer!