Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 67440C433F2
Subject: Re: [RFT PATCH v2 07/10] drivers: qcom: rpmh-rsc: Warning if
 tcs_write() used for non-active
To:     Douglas Anderson <dianders@chromium.org>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     mka@chromium.org, Rajendra Nayak <rnayak@codeaurora.org>,
        evgreen@chromium.org, Lina Iyer <ilina@codeaurora.org>,
        swboyd@chromium.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20200311231348.129254-1-dianders@chromium.org>
 <20200311161104.RFT.v2.7.I8e187cdfb7a31f5bb7724f1f937f2862ee464a35@changeid>
From:   Maulik Shah <mkshah@codeaurora.org>
Message-ID: <339a7a7b-af4e-d6a9-4b48-2a603ea10172@codeaurora.org>
Date:   Wed, 1 Apr 2020 18:10:18 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <20200311161104.RFT.v2.7.I8e187cdfb7a31f5bb7724f1f937f2862ee464a35@changeid>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On 3/12/2020 4:43 AM, Douglas Anderson wrote:
> tcs_write() is documented to only be useful for writing
> RPMH_ACTIVE_ONLY_STATE.  Let's be loud if someone messes up.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> Changes in v2: None
>
>   drivers/soc/qcom/rpmh-rsc.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/drivers/soc/qcom/rpmh-rsc.c b/drivers/soc/qcom/rpmh-rsc.c
> index 93f5d1fb71ca..ba489d18c20e 100644
> --- a/drivers/soc/qcom/rpmh-rsc.c
> +++ b/drivers/soc/qcom/rpmh-rsc.c
> @@ -573,6 +573,12 @@ static int tcs_write(struct rsc_drv *drv, const struct tcs_request *msg)
>   	unsigned long flags;
>   	int ret;
>   
> +	/*
> +	 * It only makes sense to grab a whole TCS for ourselves if we're
> +	 * triggering right away, which we only do for ACTIVE_ONLY.
> +	 */
> +	WARN_ON(msg->state != RPMH_ACTIVE_ONLY_STATE);
> +

Unnecessary check, we will never hit this warning. Lets not add such check.

Saying that you can modify this change to drop below check  from 
rpmh_rsc_write_ctrl_data() as that never hit.

         /* Data sent to this API will not be sent immediately */
         if (msg->state == RPMH_ACTIVE_ONLY_STATE)
                 return -EINVAL;

we always call rpmh_rsc_write_ctrl_data() for RPMH_SLEEP_STATE and 
RPMH_WAKE_ONLY_STATE.

Thanks,
Maulik
>   	/* TODO: get_tcs_for_msg() can return -EAGAIN and nobody handles */
>   	tcs = get_tcs_for_msg(drv, msg);
>   	if (IS_ERR(tcs))

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation