Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp585055ybb; Wed, 1 Apr 2020 06:04:37 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvYCBqua3XKKoYux3qmhJSAVLFFGINaHxLhvlemDerpgyydoa960Rhr1KbNvV2t3SxqYJAd X-Received: by 2002:a9d:6e05:: with SMTP id e5mr16457174otr.277.1585746277360; Wed, 01 Apr 2020 06:04:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585746277; cv=none; d=google.com; s=arc-20160816; b=zEowlTr7T0GRjWDJZIDa0ihFHPdlJFmP4Vb7O3jHjQLIN3PnNF6BoDVSbrLa9zbkIX zJV8iaymEUvMboTuSBu9bC+O0a/ZI/tyNgE7NavS5Rjbm007wMEgPDTR2QlJZztL+Tr6 R/kXaEg4Wi/cSPvC+FXrYMd4y1Btge2iQGBoD9dnnOTNMyGU4csweUUcnagRgvXIw9SL LB1m2OOXGSw27PktIT4hcXSnbWctaUQbwa1PP9uRB+RkAGoHfy1pyEq62ZcwA8ue1Fpq yT/XYybKPiPIK+DPiBHoFBp+v7prRxrxCz1eaQMWELzub4KOKPen+x/EmhdqXm4EFxwi wkEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organisation:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=5sA+YLrXPSNiivp5q8T49TJBY5KWFJmMVPDMzPvYWkg=; b=lNs86ikDWHGphsgjAd1LvXQZkdZvsXElBbLI7vRABkI0Dz/4c8ln/3u7J6yAOGkyuq 5IyqjbV3YutRfBTeIR78HBwhkqhD9Yui4dwO1zGA8TlZFD0uOMk6gZBlS91P/IRL8kpE +5H5Id/UucS3XZzJJhybwFH7blqqFDaIDgn0p9piydbzd8jlqh0f3Rl3oTKx6895peAm ULXLF+XuIaRI/EabOCRn1Jc/aeGkSQf4EyieHjIi1Uv2wXZglecFx09aF3YlbkmWWSnF +CPQAiJLqdtK35I7v1GVyEoAziFtHMaBth8aPBY+3hb6/vwKQN2h5YRvWPnDpQbHHnds dPEA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i14si877904otk.123.2020.04.01.06.04.19; Wed, 01 Apr 2020 06:04:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732685AbgDAND0 (ORCPT + 99 others); Wed, 1 Apr 2020 09:03:26 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:58774 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732252AbgDANDZ (ORCPT ); Wed, 1 Apr 2020 09:03:25 -0400 Received: from penelope.horms.nl (ip4dab7138.direct-adsl.nl [77.171.113.56]) by kirsty.vergenet.net (Postfix) with ESMTPA id AFBE225B779; Thu, 2 Apr 2020 00:03:22 +1100 (AEDT) Received: by penelope.horms.nl (Postfix, from userid 7100) id 28A1C67C; Wed, 1 Apr 2020 15:03:20 +0200 (CEST) Date: Wed, 1 Apr 2020 15:03:20 +0200 From: Simon Horman To: Pablo Neira Ayuso Cc: Julian Anastasov , Haishuang Yan , netdev@vger.kernel.org, lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ipvs: optimize tunnel dumps for icmp errors Message-ID: <20200401130319.GG29376@vergenet.net> References: <1584278741-13944-1-git-send-email-yanhaishuang@cmss.chinamobile.com> <20200326140229.emeplg75xszpd7rs@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200326140229.emeplg75xszpd7rs@salvia> Organisation: Horms Solutions BV User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 26, 2020 at 03:02:29PM +0100, Pablo Neira Ayuso wrote: > On Wed, Mar 18, 2020 at 01:36:32PM +0200, Julian Anastasov wrote: > > > > Hello, > > > > On Sun, 15 Mar 2020, Haishuang Yan wrote: > > > > > After strip GRE/UDP tunnel header for icmp errors, it's better to show > > > "GRE/UDP" instead of "IPIP" in debug message. > > > > > > Signed-off-by: Haishuang Yan > > > > Looks good to me, thanks! > > > > Acked-by: Julian Anastasov > > > > Simon, this is for -next kernels... > > Simon, if no objection, I'm going to include this in the next nf-next > pull request. > Sorry for being slow, I have no objections.