Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 07/10] objtool: check: Allow save/restore hint in non
 standard function symbols
To:     Miroslav Benes <mbenes@suse.cz>
Cc:     linux-kernel@vger.kernel.org, jpoimboe@redhat.com,
        peterz@infradead.org, raphael.gault@arm.com
References: <20200327152847.15294-1-jthierry@redhat.com>
 <20200327152847.15294-8-jthierry@redhat.com>
 <alpine.LSU.2.21.2004011552290.15809@pobox.suse.cz>
From:   Julien Thierry <jthierry@redhat.com>
Message-ID: <b5c6d9a6-02ce-dce3-952b-4d044cb63b7f@redhat.com>
Date:   Wed, 1 Apr 2020 15:06:46 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <alpine.LSU.2.21.2004011552290.15809@pobox.suse.cz>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 4/1/20 2:54 PM, Miroslav Benes wrote:
> On Fri, 27 Mar 2020, Julien Thierry wrote:
> 
>> The kernel code base provides CODE_SYM_START/END to declare assembly
>> code sequences that don't follow function standard calling conventions.
>>
>> As non-C/non-standard code, these sequences can very much benefit from
>> unwind hints. However, when a restore unwind_hint is used in a
>> non-function code sequence, objtool will crash when looking for the
>> corresponding save hint.
>>
>> Record the code symbol an instruction belongs to and look for save hints
>> belonging to the same code symbol as the restore hint.
>>
>> Signed-off-by: Julien Thierry <jthierry@redhat.com>
> 
> Looks ok, but save/restore hints are about to go away. See
> https://lore.kernel.org/lkml/20200331222703.GH2452@worktop.programming.kicks-ass.net/
> 

Ah, just as I started bringing unwind hints to the arm64 side...

I'll have to scratch my head a bit more over this then. Thanks for 
bringing it to my attention.

Thanks,

-- 
Julien Thierry