Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp751233ybb; Wed, 1 Apr 2020 08:59:33 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtvn+s66AiPBWXApLCNpO+65iE+twfVx05Iht2sHxYsGblDzzX628rUEqFXRKQlY2sCjnst X-Received: by 2002:a4a:e08b:: with SMTP id w11mr17542212oos.62.1585756773139; Wed, 01 Apr 2020 08:59:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585756773; cv=none; d=google.com; s=arc-20160816; b=M0ACEWibM87LFI0BIJ7x4UAjz6T/IDKV3oPwp8XqAztvLAiDhWHUdPumBIvk6/VqET K4GncQQYFHFonNNh3G2C6HsQj2LWtIYrDAQETbsEqa8mrcqW7XpNqUxobnyc9B4qOXH0 2PfKDUeVNivwghhPFACWhR4wMGtK5m+HiMab35J86e3ie4l9KVaLjOWJMercBraqqR4K p1c086F+V+k/V2mYju8NoaUedZKZoqmPIOeXMhmNHfcEfko9yjONJxkf2GmyeqI0winM 6mMoOEjAx9W1rzao8TimPc3uUriy61IMrUaQ4YMjdz+4S6T7hcve91jZbjacyFRz5/uY Yrow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :reply-to:message-id:subject:cc:to:from:date; bh=DpipVVs29wW5W5eCoCrAgaDdjSU1iuc+Wq7kZzIgk2g=; b=UDViANSf3H01eI94ERjhnAXCPCdYOClth3P16tDnaP6xy7A1TdZjP/QHRphwMmYI9s Az+nSG8IhjZSrYXDatDqRu3OU6x/9uRHGMnva2y3bQJYjlAYl05H4VUrHF/VHLxuJPSj lIxKdE1pef0mA5sIUcR3IJjg6rVdTyYjqJq7QypmC1Prr/QjEiztY4L3FeNwduEQon0k qU8n9wTrgibbH3t5QsaRN3nGLrnwKcsF4JbSbO7blsw+UPDQtmUaLgvxCXcJcUUiyRON TKuigwnMbsVjR8DWvL6oNtQGbDSvIdHSDAujkJMy4Tu2HP5ksy3EOCDtV4OZstCGHU71 mFZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a9si966219otr.186.2020.04.01.08.59.19; Wed, 01 Apr 2020 08:59:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733227AbgDAP6U (ORCPT + 99 others); Wed, 1 Apr 2020 11:58:20 -0400 Received: from mx2.suse.de ([195.135.220.15]:46698 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732980AbgDAP6U (ORCPT ); Wed, 1 Apr 2020 11:58:20 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 75C37AC92; Wed, 1 Apr 2020 15:58:18 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 65771DA727; Wed, 1 Apr 2020 17:57:44 +0200 (CEST) Date: Wed, 1 Apr 2020 17:57:44 +0200 From: David Sterba To: Jules Irenge Cc: linux-kernel@vger.kernel.org, boqun.feng@gmail.com, Chris Mason , Josef Bacik , David Sterba , "open list:BTRFS FILE SYSTEM" Subject: Re: [PATCH 5/7] btrfs: Add missing annotation for btrfs_lock_cluster() Message-ID: <20200401155744.GU5920@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Jules Irenge , linux-kernel@vger.kernel.org, boqun.feng@gmail.com, Chris Mason , Josef Bacik , David Sterba , "open list:BTRFS FILE SYSTEM" References: <0/7> <20200331204643.11262-1-jbi.octave@gmail.com> <20200331204643.11262-6-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200331204643.11262-6-jbi.octave@gmail.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 31, 2020 at 09:46:41PM +0100, Jules Irenge wrote: > Sparse reports a warning at btrfs_lock_cluster() > > warning: context imbalance in btrfs_lock_cluster() > - wrong count > > The root cause is the missing annotation at btrfs_lock_cluster() > Add the missing __acquires(&cluster->refill_lock) annotation. > > Signed-off-by: Jules Irenge Thanks, I'll add it to devel queue.