Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp752539ybb; Wed, 1 Apr 2020 09:00:50 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvilTSllIz+DlccdEnkeg9m1gRu5ggJNXoTsRM/qimWihLBJAzBDJCwQxkfCffdXdTRxQfE X-Received: by 2002:a4a:9c8d:: with SMTP id z13mr17611660ooj.50.1585756850445; Wed, 01 Apr 2020 09:00:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585756850; cv=none; d=google.com; s=arc-20160816; b=MJImDIDOuH+MCib15juztqOM8cBaffv1nNdEXcgHLt4QFHU0lWDoJfzZhaZExlpd/s k2al9DewBVt2qExCBqEsSYGYQmxl2vo0gXY819IOGoZnJXUXjDvwoMAspln/FLpSpzu+ rNI781R+i+Y+E5Nb/Cel57ojokaqz40Y0rucdlT4u9L5rOgDU7kCn/VtmZyIdONZJ2HP jKIhoipkH5zQ3AB3AlFXg4/a0wOfsWxj/EN+v2+oog8Pwzn52Sz0F8ERNM5L6MS/g7wV CzSHW4IHdO7f+TFlxg0f+cXF58HLoTpVpMPojcfQCXFQGloIwRQJwqhTqxtCoOysJHhB TsmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:ironport-sdr:ironport-sdr; bh=zg9NtiNwT8llWiqg6WC5C8UGrYhxZD1P7kxs4mLOlAk=; b=MMGNDiUhTmXHtOrME585TaVGEBZlcuzP4EmZK28BWReQmGxjywBGFQJwg5blmvE6f9 4L9LzI2OIoE0m7Li/ekuLFMAKiMQ8ycUamOWq4LSJoqY0SzVdhb101F+cYA/ppd+vw3H odCEbz6oOE66kASOhqQ14rVWcd+20fjYQ/MkKpUnYz52lLnhIopB7EQIjwp2IiosE6VU uPafEHi8T8u3iWxjN9n6iumT1THACTwFjzvucW3hJ2AZLuD1qd5m+8Nvr8/PDyu6fFjz qnZgEK6wu7yR7HJILc+bPmw98n5a4lWHSW6OJyKTkEyWpmZekPpX81EKGcRjPuCPaHiB MdxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d10si908923otc.287.2020.04.01.09.00.36; Wed, 01 Apr 2020 09:00:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733193AbgDAP7y (ORCPT + 99 others); Wed, 1 Apr 2020 11:59:54 -0400 Received: from mga18.intel.com ([134.134.136.126]:30397 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733088AbgDAP7y (ORCPT ); Wed, 1 Apr 2020 11:59:54 -0400 IronPort-SDR: gcYTy3hWCS0yvfPxvnqTc0zilER19c5BZLCXxKzQumUKk0PF8LtezAuQlKAoSB4/66mFSdFCmE tcJBM5BS2LEg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2020 08:59:53 -0700 IronPort-SDR: /dRVQ3HhcSP6LMP7LWA7jzfcYR845BctVHtxdSsb9DvF/zIObODCMg97exc+KTbYoOTsmcEEeA xEav+PC/2/Ew== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,332,1580803200"; d="scan'208";a="450606822" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by fmsmga006.fm.intel.com with ESMTP; 01 Apr 2020 08:59:52 -0700 Date: Wed, 1 Apr 2020 09:05:40 -0700 From: Jacob Pan To: Auger Eric Cc: "Liu, Yi L" , "Tian, Kevin" , Lu Baolu , "iommu@lists.linux-foundation.org" , LKML , Joerg Roedel , David Woodhouse , Alex Williamson , Jean-Philippe Brucker , "Raj, Ashok" , Christoph Hellwig , Jonathan Cameron , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function Message-ID: <20200401090540.135fd760@jacob-builder> In-Reply-To: References: <1584746861-76386-1-git-send-email-jacob.jun.pan@linux.intel.com> <1584746861-76386-9-git-send-email-jacob.jun.pan@linux.intel.com> <3215b83c-81f7-a30f-fe82-a51f29d7b874@redhat.com> <20200331135807.4e9976ab@jacob-builder> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 1 Apr 2020 09:32:37 +0200 Auger Eric wrote: > >> devtlb > >> descriptor, that is why Eric suggests {0, 0, 1}. > > > > I think it should be {0, 0, 1} :-) addr field and S field are must, > > pasid field depends on G bit. > > On my side, I understood from the spec that addr/S are always used > whatever the granularity, hence the above suggestion. > > As a comparison, for PASID based IOTLB invalidation, it is clearly > stated that if G matches PASID selective invalidation, address field > is ignored. This is not written that way for PASID-based device TLB > inv. > > I misread the S bit. It all makes sense now. Thanks for the proposal and explanation. Jacob