Received: by 2002:a17:90a:1609:0:0:0:0 with SMTP id n9csp836857pja; Wed, 1 Apr 2020 09:35:23 -0700 (PDT) X-Google-Smtp-Source: ADFU+vubm52Q3KM5gQLLF6imArDsScS79VgsdGFVHj4yVEKTrcKA/JWlpj7cjAbohpnNrJZTeMfF X-Received: by 2002:a9d:68d0:: with SMTP id i16mr17158720oto.291.1585758922871; Wed, 01 Apr 2020 09:35:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585758922; cv=none; d=google.com; s=arc-20160816; b=HvbcvVErEXkFNSoUDbOdmCJoUwDJH3chN2nsOq5vvFVQNwFdrZCgOeK2vHkNjuVSTP UX52CIpNy8wG47FBSzNaAXw5n8WWHE4pkHtmkmr2Ini3vDovsgamuHIGdKcN4bk0gRyW 8NHr43uxWYmb/KeRVc+6NpIC2KbaSM/b9Mkh5B6QeADaVzwXq+IuxnMfyR9wEEYD4yc9 HTmS4ZWZEjRnJzFlq9A0TtqkREOLidMGHWRpL4dBvJo6jUcq6Az8NbHEyLMj1k00Bblt 1xN6hNusLcta1OJVc6jrkS1HgPSsIKjSAKl/KIfJVP2QIN53MWAWdKDoGTMqjxmOYJqd XDTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=m31hYCLlD3Om7Su7rFmatYsMDJAOgyyKmPsZnvTeSmY=; b=FVDYYb0RO2Vn8OMq73Z+09CxNd+kQ5AKkRjqzEqQ5eRBxmZVxXn65rGtCc9YGdBkkE tdxGcTCBKvD5QKDHHX5mzjY+CE9XOQVjs2tgkZZOm2G+ymtNRN3OBiq/coe+XH4umAUd Yfa7sJZjE6bRmautB5hckKhblaayQgkNrBkzMD7SVlu1rvHQXIudJG9p8EzlRAN4vwpX 8XxpqMLzOYKCAAkhGd+Fbc2mQvaL6QifeW+AgW5Lpo6mNYef4mpst4LBZqqW4+cNTdRb 9Bt8HVkwIjru0rVPkU85L4nMDmh113iWsRSXyCMZa1Xb6w/OsN1yFfi0lM2bhb3N2nIB NZNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kPLRtIJi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b11si1064072oii.11.2020.04.01.09.35.09; Wed, 01 Apr 2020 09:35:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kPLRtIJi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388630AbgDAQeO (ORCPT + 99 others); Wed, 1 Apr 2020 12:34:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:60838 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387945AbgDAQeL (ORCPT ); Wed, 1 Apr 2020 12:34:11 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CB33C214DB; Wed, 1 Apr 2020 16:34:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585758850; bh=D6XO2jVZkyfQ46/D8Ey/p4CwYEdv7SUQHRt2TrQ8e5E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kPLRtIJiFZPCGpGUo2pbU+GKPPbcvBfI7acT/CW+AndN5e0bSuskYRWubWGNtgIMg hNOvuP2/UjlmqZVwJ0AUWUpR5JAaaybE7ZhRwzEtCvx5D3yAQ9vFkPpGE76ePVR5NA 0N+88XOKffMdxn5P32221hFoXcRznRYnamHjTQhg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hangbin Liu , Xin Long , Steffen Klassert Subject: [PATCH 4.4 63/91] xfrm: add the missing verify_sec_ctx_len check in xfrm_add_acquire Date: Wed, 1 Apr 2020 18:17:59 +0200 Message-Id: <20200401161534.574864759@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200401161512.917494101@linuxfoundation.org> References: <20200401161512.917494101@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Xin Long commit a1a7e3a36e01ca6e67014f8cf673cb8e47be5550 upstream. Without doing verify_sec_ctx_len() check in xfrm_add_acquire(), it may be out-of-bounds to access uctx->ctx_str with uctx->ctx_len, as noticed by syz: BUG: KASAN: slab-out-of-bounds in selinux_xfrm_alloc_user+0x237/0x430 Read of size 768 at addr ffff8880123be9b4 by task syz-executor.1/11650 Call Trace: dump_stack+0xe8/0x16e print_address_description.cold.3+0x9/0x23b kasan_report.cold.4+0x64/0x95 memcpy+0x1f/0x50 selinux_xfrm_alloc_user+0x237/0x430 security_xfrm_policy_alloc+0x5c/0xb0 xfrm_policy_construct+0x2b1/0x650 xfrm_add_acquire+0x21d/0xa10 xfrm_user_rcv_msg+0x431/0x6f0 netlink_rcv_skb+0x15a/0x410 xfrm_netlink_rcv+0x6d/0x90 netlink_unicast+0x50e/0x6a0 netlink_sendmsg+0x8ae/0xd40 sock_sendmsg+0x133/0x170 ___sys_sendmsg+0x834/0x9a0 __sys_sendmsg+0x100/0x1e0 do_syscall_64+0xe5/0x660 entry_SYSCALL_64_after_hwframe+0x6a/0xdf So fix it by adding the missing verify_sec_ctx_len check there. Fixes: 980ebd25794f ("[IPSEC]: Sync series - acquire insert") Reported-by: Hangbin Liu Signed-off-by: Xin Long Signed-off-by: Steffen Klassert Signed-off-by: Greg Kroah-Hartman --- net/xfrm/xfrm_user.c | 3 +++ 1 file changed, 3 insertions(+) --- a/net/xfrm/xfrm_user.c +++ b/net/xfrm/xfrm_user.c @@ -2175,6 +2175,9 @@ static int xfrm_add_acquire(struct sk_bu err = verify_newpolicy_info(&ua->policy); if (err) + goto free_state; + err = verify_sec_ctx_len(attrs); + if (err) goto bad_policy; /* build an XP */