Received: by 2002:a17:90a:1609:0:0:0:0 with SMTP id n9csp845228pja; Wed, 1 Apr 2020 09:44:11 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtNJRBhj4tcuMgWbG8+mn8xKMj0QREQMSDZAS1+HVxztO5nSgcroms/L5zCFX9y+5bv9TrD X-Received: by 2002:a9d:728e:: with SMTP id t14mr13576373otj.63.1585759451806; Wed, 01 Apr 2020 09:44:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585759451; cv=none; d=google.com; s=arc-20160816; b=BcB/9Kaoq/v0UixYNWR20sFW7MFu82zyYMOgK00v0R2sTtF+hcUZrK7tGN+dfH37IK yZXRpO8ByUvVDazV9+c254LiHy2K/zu5cz8WnicBAIqC30fwPg2Ht+5NwgtU23IFeva1 nyZ0Jp5H+EjkCuNMx6I3kAoYCbQ2pygTMn+CUOiNJJKQYC5rI6IuHs/SarqNSyb4tcUR 5OsZ6d0FTG8B5lCE9xEdT14ynazwqAKIAA83VVAuX48RtgNFCEji+DswYU0IU68/f+rO 7Ix2WWntjMOshb5iE82/9TGKa0u0w+J5AyJej4zlb+rka4/a3/dczumPuNidL7HWsGhZ oYug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=FUKrFDwmeE2n75VnM2ogXyhbUmFK5A7LV3kzHADAilg=; b=eI9E9tLsNXGdYvBx+fAxBN8FLf1F8j9qRQFEJjYIkA2H+WzXI8VNW++sK3pgyY3MUY fPVRQ1xzYi8CBwcrBRVMvHW0NxDbKbgDbtlJVOf/I4x1uXaSX6rMSdKfKMbdPxQK7DzM h3Q2GY7jnUIFFp2TlrdlP62nBfX6FEQjv9BuF44/yQ+jhnPOm9/5uojeYx1rMAx6xf9l 2ZJwhg2CG7P2d6YGv9eMBJEQcndXGjpMts6+cG7NdLaU6MROX6xQKf01kWbu/vLyKrgw djXzcvpyzii36NdL47qoODDluqQ8D9z8O1ZrKRboFqGUKbDoZlnFvn3GPTZGumuR8Dwx I0Zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pTD8gst1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j184si1089913oih.216.2020.04.01.09.43.59; Wed, 01 Apr 2020 09:44:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pTD8gst1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389341AbgDAQnS (ORCPT + 99 others); Wed, 1 Apr 2020 12:43:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:44060 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388059AbgDAQnQ (ORCPT ); Wed, 1 Apr 2020 12:43:16 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B873520787; Wed, 1 Apr 2020 16:43:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585759396; bh=nhJQxQCFLz20+3m0GlqbdNdv+16PiSrAntecgskSFgI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pTD8gst1Y0uWQqF7QRBMRZIZvCZLbOWfxwsdpSkNN0h1wmmCIOje6X9ZWpyLfGkzt x3bHtfh4OHNbCEtwaRvNmn20zq6l8ZqOIClsyAOATTyAn2tMD8lJ2yHyCwSdBTsOM8 z/QHcuPa5S2VGAs2wuPdtomFgK3wjCPIKyPe9Pfc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, yangerkun , Oliver Hartkopp , "David S. Miller" Subject: [PATCH 4.14 066/148] slcan: not call free_netdev before rtnl_unlock in slcan_open Date: Wed, 1 Apr 2020 18:17:38 +0200 Message-Id: <20200401161559.991409909@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200401161552.245876366@linuxfoundation.org> References: <20200401161552.245876366@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oliver Hartkopp [ Upstream commit 2091a3d42b4f339eaeed11228e0cbe9d4f92f558 ] As the description before netdev_run_todo, we cannot call free_netdev before rtnl_unlock, fix it by reorder the code. This patch is a 1:1 copy of upstream slip.c commit f596c87005f7 ("slip: not call free_netdev before rtnl_unlock in slip_open"). Reported-by: yangerkun Signed-off-by: Oliver Hartkopp Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/can/slcan.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/net/can/slcan.c +++ b/drivers/net/can/slcan.c @@ -621,7 +621,10 @@ err_free_chan: tty->disc_data = NULL; clear_bit(SLF_INUSE, &sl->flags); slc_free_netdev(sl->dev); + /* do not call free_netdev before rtnl_unlock */ + rtnl_unlock(); free_netdev(sl->dev); + return err; err_exit: rtnl_unlock();