Received: by 2002:a17:90a:1609:0:0:0:0 with SMTP id n9csp845441pja; Wed, 1 Apr 2020 09:44:24 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuwGPUoA4thtN3UHKv5liLW6/BiRd+ObZgiv9a9VGtnIdB3ZXlEqUWQDRaFExOtwOjqZkKC X-Received: by 2002:a05:6830:1da4:: with SMTP id z4mr17479131oti.5.1585759463769; Wed, 01 Apr 2020 09:44:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585759463; cv=none; d=google.com; s=arc-20160816; b=tORmgXKv5ECzuCMsNFQYvM3JoBp9G5dcN0wETWV5OKIPUJ9EKYIi5soKXDHMlKjpD8 9HW3x0OVs7OEVDiStAVAjhd+aVtFuZANOa7Q4O0kqaBcvzxuLYTur+1bGmpGVGJCPCyF xeA7L50+STX2bEKnaheDPck0tF6IiFcTvitd3RTBFmcTtKjWvUmd5+HYoAhhvW1YNNaD Gi+/sGt/SAmDGgkj9cSz2eXLTN98b5mYlTX4v43s6/vQJhyO4ct9UJRj4eNyFuGZVUJ+ fXBk1caZICJKgQZguqtDYISFGBfWeCZFGk9zpltv7Rs7kfMd3SruuYLxn1ljkGTFe2zZ Lw1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=gVrwxrQPWggmliG06TayfxGQ3hcP6ZorVlusxuqvTeo=; b=Mus7d/aKu3P+DoUfYpFR218QcSdSQJgr4CXd/lRVsciXReHaIdN+RAVAPadfGszhIC EqYHRRHdHhAyizp3LqPem+kqixPR30UWVX2OcHvITtM+BYAOfr3tNLfa2pXnoDjgsCrg Ill2R9nLi8BOB9/ROviliXf8gzDA1QQtzs8On+vuq+h1D0p3VbWVlJMP8HxVQFIRCvTv HDR3qIyPJtfv9Uhf/qXuWEXyoJEJjZl9cQ8yd8afrpN+RtCVdZ4B/2OpRJTe0h1J/yxY r/ziI1GOZFDvzU7lzOHzAiaVm65nZck+3Gzmkmdv1SiKesmFggm64xTvGVGFOtrZetS4 iZCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="uMN/i5A+"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y25si1229209otj.304.2020.04.01.09.44.10; Wed, 01 Apr 2020 09:44:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="uMN/i5A+"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389616AbgDAQnZ (ORCPT + 99 others); Wed, 1 Apr 2020 12:43:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:44164 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389459AbgDAQnY (ORCPT ); Wed, 1 Apr 2020 12:43:24 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 122302063A; Wed, 1 Apr 2020 16:43:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585759403; bh=+4TU2j85QaBbPTyUaEv5pNZ13HPIguW05u2KrMkHw/w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uMN/i5A+XGiVHPr6o4RABs2aYLIgShs6j5Z6Cj5nCSx2Q8rjVpY52/b4FkzrkeaQ0 bHBxCAxg/8jaDvmSSr8+aD+VhvLzfHAvbfPfd4FclsSK+g8mJGE71V/uYsX43GZMln jPUtVBfYp+sSdsVqEFY62lOqqSpPOlJEpuUnknD4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andrew Smith , =?UTF-8?q?Ren=C3=A9=20van=20Dorst?= , Vivien Didelot , Florian Fainelli , "David S. Miller" Subject: [PATCH 4.14 068/148] net: dsa: mt7530: Change the LINK bit to reflect the link status Date: Wed, 1 Apr 2020 18:17:40 +0200 Message-Id: <20200401161600.097576252@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200401161552.245876366@linuxfoundation.org> References: <20200401161552.245876366@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Ren? van Dorst" [ Upstream commit 22259471b51925353bd7b16f864c79fdd76e425e ] Andrew reported: After a number of network port link up/down changes, sometimes the switch port gets stuck in a state where it thinks it is still transmitting packets but the cpu port is not actually transmitting anymore. In this state you will see a message on the console "mtk_soc_eth 1e100000.ethernet eth0: transmit timed out" and the Tx counter in ifconfig will be incrementing on virtual port, but not incrementing on cpu port. The issue is that MAC TX/RX status has no impact on the link status or queue manager of the switch. So the queue manager just queues up packets of a disabled port and sends out pause frames when the queue is full. Change the LINK bit to reflect the link status. Fixes: b8f126a8d543 ("net-next: dsa: add dsa support for Mediatek MT7530 switch") Reported-by: Andrew Smith Signed-off-by: René van Dorst Reviewed-by: Vivien Didelot Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/dsa/mt7530.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/dsa/mt7530.c +++ b/drivers/net/dsa/mt7530.c @@ -549,7 +549,7 @@ mt7530_mib_reset(struct dsa_switch *ds) static void mt7530_port_set_status(struct mt7530_priv *priv, int port, int enable) { - u32 mask = PMCR_TX_EN | PMCR_RX_EN; + u32 mask = PMCR_TX_EN | PMCR_RX_EN | PMCR_FORCE_LNK; if (enable) mt7530_set(priv, MT7530_PMCR_P(port), mask);