Received: by 2002:a17:90a:1609:0:0:0:0 with SMTP id n9csp846921pja; Wed, 1 Apr 2020 09:45:51 -0700 (PDT) X-Google-Smtp-Source: APiQypKmUgkevKQUsZ4OPUKtMuWtok25KE97co2BCZTpdPRqUBaUEdZq1s6KiYiuRA3isR9dMGNm X-Received: by 2002:a05:6808:56:: with SMTP id v22mr3323698oic.116.1585759551072; Wed, 01 Apr 2020 09:45:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585759551; cv=none; d=google.com; s=arc-20160816; b=xbRKsVJXYzFwqn1kYTV/t14XOnmY/RHrQsFNWb/OA8Qv3mu/Alg4DqHdNocsuQrCYz L/h7AC5dxIR2/kVa7ZBvlGiEJm81H1ayaKiUGc9khr4lszTHmbpapHZXo2wLqmo2bYGi KPcQ46Dfg8zS/LMVrAMS0Iqnv4/W8CecqrNPx0en8xxxK9jfspbpVXfqW1o1710czHme oJYS8hbGO1Px6XLGWcCycHs+UF5k84ZD5ncAm04YEx3bxbktkbI+otavrIBQXdtj/zBQ 8YP7iwT48TtiKbYDLvxdwNQkyFVsgUeCuNozPqE+6s0zwQOnV/7LRsw7E8ZXvTt9Ogyf s8ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=CMa/OcPFInAFJ3+bkVY4JbGR05Jy3B56ln8dq8uXT60=; b=iWtIHrwiFvrl+kITw3xbgSXYvEE+O0bXpxnD83/D3iCyyfbG9vh/FKEDiqZ5M3dexd 5F9CIdfyuMY57vzr6vOlmT96SnbBwRq3Y02U5PE1Jz5y9nmEuGlrXN0Ic6bvO2PnSeVn wVAR3v1GcuVAehrRhjcH4nUx9cp55alUPWGY6oRDqGg6CAbTsWqG9YMdsJrRIRsHLxDl NIkdn11pYH1NJ01R7zBrqqaehIIK2ilSRyS6nsN4tDWkamODyKYAbSpI4qOHPpZj7AlC /j3tKQmvW69dELffj2JzqUuCOFgRvkJJxwpLeWzKtHrY/bvssahjBNNJ+XAMyAWwKfid 5enw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=d+pEHltA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l9si1033849otf.51.2020.04.01.09.45.37; Wed, 01 Apr 2020 09:45:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=d+pEHltA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389704AbgDAQoN (ORCPT + 99 others); Wed, 1 Apr 2020 12:44:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:45152 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389690AbgDAQoL (ORCPT ); Wed, 1 Apr 2020 12:44:11 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E8B812063A; Wed, 1 Apr 2020 16:44:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585759450; bh=r6mZS/jQtNDV6rtNX/kWpwXuUMyanIzXgkJvrL6OGnk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d+pEHltABp/5rhQSoPF4Jm0K82zau8x97cwof1cGXf9LXjrA0KsYt8tvqo9Pvq7+Z eu0770LA3Y0CaE5z/ZjZO1ZQWkXcqyZRp0rCyY7GR+ObA9PNKj86tSABKzarwo8bkh gTN57Zd/INGCzR7HXGaEVpbcEFhH/EYaHQbaLQtQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dajun Jin , Andrew Lunn , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 076/148] drivers/of/of_mdio.c:fix of_mdiobus_register() Date: Wed, 1 Apr 2020 18:17:48 +0200 Message-Id: <20200401161600.621429294@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200401161552.245876366@linuxfoundation.org> References: <20200401161552.245876366@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dajun Jin [ Upstream commit 209c65b61d94344522c41a83cd6ce51aac5fd0a4 ] When registers a phy_device successful, should terminate the loop or the phy_device would be registered in other addr. If there are multiple PHYs without reg properties, it will go wrong. Signed-off-by: Dajun Jin Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/of/of_mdio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c index fe26697d3bd72..69da2f6896dae 100644 --- a/drivers/of/of_mdio.c +++ b/drivers/of/of_mdio.c @@ -259,6 +259,7 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np) rc = of_mdiobus_register_phy(mdio, child, addr); if (rc && rc != -ENODEV) goto unregister; + break; } } } -- 2.20.1