Received: by 2002:a17:90a:1609:0:0:0:0 with SMTP id n9csp847114pja; Wed, 1 Apr 2020 09:46:02 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtU6sD+Ug8fOXzhLHUV76eis8iMX2EUlNQ77kZfXrfUI3WZh5I8dujEqmoTUaTz6mQU/jF8 X-Received: by 2002:a4a:940e:: with SMTP id h14mr7526920ooi.26.1585759562336; Wed, 01 Apr 2020 09:46:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585759562; cv=none; d=google.com; s=arc-20160816; b=Jh0rO+sp8CiI9WWin2RFt2rYAyd6l1iPFKLdLdmPxoQn/gVHIGMAQ2nKzncepME24N A/8awmdKM3Ra3yUIZrT2LJJFbqyfrhqQvqhfsJ0eO301HgokijKWEFReXVDEIoFGDOWA Vj0GdiRnXfj2V0n4JlJPIWGtIWLWakgb3tKjlKwcDJCV0ZImuwbQQ/HotS30P9+lNUmo 2Qy+lNI528pMo32HHstUBx2YPIh0OjvjM0zFLqtjJmLP77b0t0LOLIOpzDNmOGqxvvry vMT6hLsjf/acv9VROooC93N0xNwhuGMxxFLoftCotOudptWrrX/Wm8/LQ7fdryiF5Fdj kttQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=TgW0hOSiaST44fQbTQc9raHOoJDm/Z/+uyrxuin1ZKg=; b=mZou5zhgmhW/+nhWZn9Kov+2Tw14HyxMddBWdt55mHMG93jE7fteXjedlwruOfILI4 g2jPcKlc8LscSKYg1h+2RWwwVabVp7UZ09JkeqV5w8PSW9ECtItcZYro+p7dAz1oB9bf 1h7e25iwG5PbljwULDDXC/pwKC1/7EGnEVwxivZ37FOCWrIXKLru+TrcpkQ9L1vzkHrW w7CzOUAXp/ngJBK2c5qCUjyI4RfeGgvWEqMtIuXdouKU1iTQ3m4wHxe9Ow14Ik/FoLMN 2TefDoG/v6uxar8NPuhA/h1QUqjEMsjuKeAGVIt5WFXmpDRH38G6d7Toknu9pRd0cPIJ LPrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=thn0UUtJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l4si924063otf.195.2020.04.01.09.45.47; Wed, 01 Apr 2020 09:46:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=thn0UUtJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388133AbgDAQn5 (ORCPT + 99 others); Wed, 1 Apr 2020 12:43:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:44850 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389512AbgDAQn4 (ORCPT ); Wed, 1 Apr 2020 12:43:56 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EF92F2063A; Wed, 1 Apr 2020 16:43:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585759435; bh=jh4q+6jp3bwJQC4FPQjc+xd9xxgENTXWRRQ6FFlQtsM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=thn0UUtJQgFdny3eYszMUNRaruVhHMjCpcdkmqDurpQmeu7GlEE7oF+FzZhLJ0U66 p7nfsK4rB/nRBoT2hqBsv5cdDqlNL1NQZ8it4JpJHoOYFioD/9LoX9s9KpaU5COTAH Gs3XvnwAED7JJySc/XLjhZ0Rlg7BRSxs8/ZnGtfk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Qian Cai , Andrew Morton , David Hildenbrand , "Huang, Ying" , Rafael Aquini , Linus Torvalds Subject: [PATCH 4.14 038/148] page-flags: fix a crash at SetPageError(THP_SWAP) Date: Wed, 1 Apr 2020 18:17:10 +0200 Message-Id: <20200401161556.412268483@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200401161552.245876366@linuxfoundation.org> References: <20200401161552.245876366@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qian Cai commit d72520ad004a8ce18a6ba6cde317f0081b27365a upstream. Commit bd4c82c22c36 ("mm, THP, swap: delay splitting THP after swapped out") supported writing THP to a swap device but forgot to upgrade an older commit df8c94d13c7e ("page-flags: define behavior of FS/IO-related flags on compound pages") which could trigger a crash during THP swapping out with DEBUG_VM_PGFLAGS=y, kernel BUG at include/linux/page-flags.h:317! page dumped because: VM_BUG_ON_PAGE(1 && PageCompound(page)) page:fffff3b2ec3a8000 refcount:512 mapcount:0 mapping:000000009eb0338c index:0x7f6e58200 head:fffff3b2ec3a8000 order:9 compound_mapcount:0 compound_pincount:0 anon flags: 0x45fffe0000d8454(uptodate|lru|workingset|owner_priv_1|writeback|head|reclaim|swapbacked) end_swap_bio_write() SetPageError(page) VM_BUG_ON_PAGE(1 && PageCompound(page)) bio_endio+0x297/0x560 dec_pending+0x218/0x430 [dm_mod] clone_endio+0xe4/0x2c0 [dm_mod] bio_endio+0x297/0x560 blk_update_request+0x201/0x920 scsi_end_request+0x6b/0x4b0 scsi_io_completion+0x509/0x7e0 scsi_finish_command+0x1ed/0x2a0 scsi_softirq_done+0x1c9/0x1d0 __blk_mqnterrupt+0xf/0x20 Fix by checking PF_NO_TAIL in those places instead. Fixes: bd4c82c22c36 ("mm, THP, swap: delay splitting THP after swapped out") Signed-off-by: Qian Cai Signed-off-by: Andrew Morton Reviewed-by: David Hildenbrand Acked-by: "Huang, Ying" Acked-by: Rafael Aquini Cc: Link: http://lkml.kernel.org/r/20200310235846.1319-1-cai@lca.pw Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- include/linux/page-flags.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h @@ -264,7 +264,7 @@ static inline int TestClearPage##uname(s __PAGEFLAG(Locked, locked, PF_NO_TAIL) PAGEFLAG(Waiters, waiters, PF_ONLY_HEAD) __CLEARPAGEFLAG(Waiters, waiters, PF_ONLY_HEAD) -PAGEFLAG(Error, error, PF_NO_COMPOUND) TESTCLEARFLAG(Error, error, PF_NO_COMPOUND) +PAGEFLAG(Error, error, PF_NO_TAIL) TESTCLEARFLAG(Error, error, PF_NO_TAIL) PAGEFLAG(Referenced, referenced, PF_HEAD) TESTCLEARFLAG(Referenced, referenced, PF_HEAD) __SETPAGEFLAG(Referenced, referenced, PF_HEAD)