Received: by 2002:a17:90a:1609:0:0:0:0 with SMTP id n9csp847700pja; Wed, 1 Apr 2020 09:46:41 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsvFLHuxiNFWU/3VOM2rEwwUI8YMHCRzgcgeZk/oCncMh5q7/nyvwDuIy4D9He3P9IsIhxp X-Received: by 2002:a9d:c61:: with SMTP id 88mr18104344otr.144.1585759600904; Wed, 01 Apr 2020 09:46:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585759600; cv=none; d=google.com; s=arc-20160816; b=hjZTgNZJxDyFwv21rDUwdZ2VZff9rLgjQBAMY+Wl7S9LF259DPjO0qREEJhKxCeSwg igDzitZ0a6zV2fTIPaZlhIw2zddJqEIMXz6aTpYamHCsyPnamQJ7I1Z5JU4HSM+XEU0p erPdTnl5HF3FVnEKi8jY9fq67OJCqzF9jKzjPqUgbhJwyzFXvQGkCaxJ/IXDHqBQ+3nl 6kdTwCMcjzPqMgTtZxuKw/ej/pv3LuHwr6ANvHkvG6yOR4dZAJxoNALYH8eM7f1+5bAd VPZhAH55oVPN0s7vs62KNhqlzx/kSyRbO3DMBLKws/jrsSN2MjJABhIhuqhuZnHy65QB STtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Z4cUGpPz7joRwRhRMNq7tWMOY6U7PwFx/4TgAFnLUHo=; b=mEWN2Uj0lTgxPd9JE1/jBVf9jZ5oETgQcGk4bOlniW4h9kjykoCfcLDvyFNMztb4p8 ZDuk6AB/BPWlt3JdCnuo4PU2r1ugtEOEeE3qYj/MMuYyuv/RbpriAqm7vCwRKIuEWpNu IBiRo0M3dYNnHvpz9aEsqoqexxA+9UFnXi78wLHJi7lJHMOF2nVRSO4vhbctTvyX+Joz 07xg+Z/00B6/PVKzZXsywc3rznVXELu4NEUFvsFMyOFtCbUfEQF5c97VfZ4sE1k/JHY1 AWGb6je+sPXEYjIURKBGunq9y+RBqC2d4CL4DuQng00lONEBC1ZdjSTbmIGSiAyU/KYM 3WnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qX9+qXvq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w12si985806otq.75.2020.04.01.09.46.27; Wed, 01 Apr 2020 09:46:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=qX9+qXvq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389654AbgDAQp2 (ORCPT + 99 others); Wed, 1 Apr 2020 12:45:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:46592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389381AbgDAQpY (ORCPT ); Wed, 1 Apr 2020 12:45:24 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1EF1C2063A; Wed, 1 Apr 2020 16:45:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585759522; bh=ZDPHBtkxjWBCJfLD83zSGZwyF1XKuPlHYCYz5wy7g+o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qX9+qXvqf6nSRk6kiVj6xjsN+14T0BA9USNJfFU4VMmGW2sLVxQMVx2JVGIIZYwEW ETSEGaGE5NLX3MZEFFn9b08uMowbUTwsrSzBNnPaFjVrEtDMw+6C4iaxzy3XwGuQIU QLL344lSUi2csML+G9t4yDaO0TR22FCvDDHLtSno= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Maor Gottlieb , Leon Romanovsky , Jason Gunthorpe Subject: [PATCH 4.14 105/148] RDMA/mlx5: Block delay drop to unprivileged users Date: Wed, 1 Apr 2020 18:18:17 +0200 Message-Id: <20200401161602.786784403@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200401161552.245876366@linuxfoundation.org> References: <20200401161552.245876366@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Maor Gottlieb commit ba80013fba656b9830ef45cd40a6a1e44707f47a upstream. It has been discovered that this feature can globally block the RX port, so it should be allowed for highly privileged users only. Fixes: 03404e8ae652("IB/mlx5: Add support to dropless RQ") Link: https://lore.kernel.org/r/20200322124906.1173790-1-leon@kernel.org Signed-off-by: Maor Gottlieb Signed-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/hw/mlx5/qp.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/infiniband/hw/mlx5/qp.c +++ b/drivers/infiniband/hw/mlx5/qp.c @@ -4896,6 +4896,10 @@ struct ib_wq *mlx5_ib_create_wq(struct i if (udata->outlen && udata->outlen < min_resp_len) return ERR_PTR(-EINVAL); + if (!capable(CAP_SYS_RAWIO) && + init_attr->create_flags & IB_WQ_FLAGS_DELAY_DROP) + return ERR_PTR(-EPERM); + dev = to_mdev(pd->device); switch (init_attr->wq_type) { case IB_WQT_RQ: