Received: by 2002:a17:90a:1609:0:0:0:0 with SMTP id n9csp848071pja; Wed, 1 Apr 2020 09:47:05 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvDv4MNZcCE4lS3AkZh6CUkWsrJRJprV3Q1i+H8qo1t227XDa2MTtSaP3U62qmQlA3Mv1Fg X-Received: by 2002:a9d:5787:: with SMTP id q7mr16622197oth.137.1585759624879; Wed, 01 Apr 2020 09:47:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585759624; cv=none; d=google.com; s=arc-20160816; b=laMsn8XvYDjxPXAbf3AoNcIZkk2WIYCn/bPoXc3nr2jwP6nXQlzBmAseIJWKORAwTh kavLCeSiYd1CvspFE1xAkAgOdXA1JieutMJmvFDu8oQ+zQ9eEw/S2JYgMPPT5H6MxwVq JzANvOj87aG44T6ZxBP+XztpZmkJRoTCNkPwszhgdyED2yyIvUIiT7AgAA9tmAszOE8h 0jGMeUV31d3zYQ6FrbaKSLLYP0Ux+Iwq+74Z8NjAbz1t8RVzGapWK961wkdUPaPLPZpu BszWFgDtZ5ETn6rioTKsJruYzAmJeZq+ucwbr46fW5b4tE9hCSPRtK7lVuC0sB/XTSGi QsAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=+/NB4a7PHvljqWUdv40QsNy7g8gc9uCzC1M5kVeeVJY=; b=GU/YYY3ZeAS1y+2otkGsAmh0ypOQUKbCDVGZuLr5xudZW1mJ7Zw1bfnuRfytbLiurG B93Wvjdyvbak3mUJaK3F3KB+c1Sciy8z31LbWxprCCC4Ev2goA/LiiImZq+3kDOWmETB cr/0EiEP4osd+S0Zo8iHgp0oFAbezozVlvCxcQUAulBRSCbovUgSm3MyWVARKt/0KNXi ier8Y0xH27nbDRagMxEaKn+bUePk2xx0XHUu6Vvj5Voh4Fk305jOfu1zZjKNLRdezIDD VYXVJf+u/0ZjLzhJ+354zqaxeeQrCCZ+Gd4MLtDjNtF9rneCfrqGg8e8bKo6WMfaZu68 9y7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=m5QgcH5a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z62si1116984oiz.23.2020.04.01.09.46.51; Wed, 01 Apr 2020 09:47:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=m5QgcH5a; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389876AbgDAQpu (ORCPT + 99 others); Wed, 1 Apr 2020 12:45:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:47018 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389403AbgDAQpq (ORCPT ); Wed, 1 Apr 2020 12:45:46 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7743C206E9; Wed, 1 Apr 2020 16:45:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585759545; bh=XtbEDCWV1Co2ctckCRyI2TREL9BJPN0Qv3Cmf1RhQoY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=m5QgcH5a2it4E9pPKezDNxrEepDAaV27FzNL2MNBl0BzUHaE+9MnGZWThMHSDxgbY 4pu055OsIYsGHqfxZitLBvi2YEeyoYT0Bv2gWc6isbVcUsIyXDsNhAB3vCv+nOcuRs stNL9RhgFB0o34ENl/9RXP/xEqd/ef9/kHA93e8k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Dmitry Torokhov , Sasha Levin Subject: [PATCH 4.14 112/148] Input: raydium_i2c_ts - fix error codes in raydium_i2c_boot_trigger() Date: Wed, 1 Apr 2020 18:18:24 +0200 Message-Id: <20200401161603.288053167@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200401161552.245876366@linuxfoundation.org> References: <20200401161552.245876366@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit 32cf3a610c35cb21e3157f4bbf29d89960e30a36 ] These functions are supposed to return negative error codes but instead it returns true on failure and false on success. The error codes are eventually propagated back to user space. Fixes: 48a2b783483b ("Input: add Raydium I2C touchscreen driver") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/20200303101306.4potflz7na2nn3od@kili.mountain Cc: stable@vger.kernel.org Signed-off-by: Dmitry Torokhov Signed-off-by: Sasha Levin --- drivers/input/touchscreen/raydium_i2c_ts.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/input/touchscreen/raydium_i2c_ts.c b/drivers/input/touchscreen/raydium_i2c_ts.c index 172f66e9da2d1..7da44956555e5 100644 --- a/drivers/input/touchscreen/raydium_i2c_ts.c +++ b/drivers/input/touchscreen/raydium_i2c_ts.c @@ -441,7 +441,7 @@ static int raydium_i2c_write_object(struct i2c_client *client, return 0; } -static bool raydium_i2c_boot_trigger(struct i2c_client *client) +static int raydium_i2c_boot_trigger(struct i2c_client *client) { static const u8 cmd[7][6] = { { 0x08, 0x0C, 0x09, 0x00, 0x50, 0xD7 }, @@ -466,10 +466,10 @@ static bool raydium_i2c_boot_trigger(struct i2c_client *client) } } - return false; + return 0; } -static bool raydium_i2c_fw_trigger(struct i2c_client *client) +static int raydium_i2c_fw_trigger(struct i2c_client *client) { static const u8 cmd[5][11] = { { 0, 0x09, 0x71, 0x0C, 0x09, 0x00, 0x50, 0xD7, 0, 0, 0 }, @@ -492,7 +492,7 @@ static bool raydium_i2c_fw_trigger(struct i2c_client *client) } } - return false; + return 0; } static int raydium_i2c_check_path(struct i2c_client *client) -- 2.20.1