Received: by 2002:a17:90a:1609:0:0:0:0 with SMTP id n9csp848205pja; Wed, 1 Apr 2020 09:47:14 -0700 (PDT) X-Google-Smtp-Source: APiQypIX/p3/zZpgUG9CSR5hEFtciC47nfxWBDtm01Is2cynMy736xuQa5hFcuLPeN20ImsgDMWD X-Received: by 2002:a05:6808:43:: with SMTP id v3mr3583011oic.59.1585759634745; Wed, 01 Apr 2020 09:47:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585759634; cv=none; d=google.com; s=arc-20160816; b=it31g0LkQ3qd1+RBVJ92tb4WrgCbXs1poNDogPRnm/b/PydJbCarMxEK9jGj6FbfU6 W8p1IdWvKFR3c1bPAlVyNiAw1JUlpTmDctyZfCHkMs9s4qP480pUumtkfM2CDMK5WjQm aQ3K77Fm2nH0IfHyiwWyXzkHyp7AgwGXPWwmMaI4caE00w33CU4DBid9U95slgXCVnqa RMyX/8Ec+pjh4ytLsCYUe/udEj+hHuevszbHmfxnMKN7IEeSQNbOG837URUz+EUaiHQI sMawqXDNvLXziFHq0lVB2vSkT5evp8CkXhosYiQh9dkaltdCvcYDxdn1K4MbkeMYt+3B 28EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SKG92D+BlRAfvzq6xK5tUiPeusUHcCam4FjjhoAr85Q=; b=GiIvyn7XHvjFwhvFzKYXss6Y/WjJjPcUAv7bJJmS7EjcUMM9vEboP9JEw30QKjUIQj prFecCC2w7ubSB00Z1+TRSpAjbYemETneAyzfO54d2ZeXXgEwcUpkbe4Ru4mP3jMogdl +6pU/tpxy85NnJN7NZ/lPdABpgoIS8e2I1VzmIhQKcWPjjdUfrM7m7R5rOLvBMjZnJgL U2QyGRAX6bJdRcRRrOgKrAZX0ustWlFONJJ44wjbsx9lVBBO7/LsPAA7Pp3EITGXQ+RF fTxXcZID0APH33/llMKOUxi0zt9/UDgZd4p5k709V5jamvZiPh//u9vDPZaoRnjzMUgl MB7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TUua4RUm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x12si1068677otq.38.2020.04.01.09.47.01; Wed, 01 Apr 2020 09:47:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TUua4RUm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389808AbgDAQpG (ORCPT + 99 others); Wed, 1 Apr 2020 12:45:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:46286 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389527AbgDAQpE (ORCPT ); Wed, 1 Apr 2020 12:45:04 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C20FE2071A; Wed, 1 Apr 2020 16:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585759503; bh=MfcDThaTPKmBvoit5K+m3YHIT6p5iRuI/Pc5lZ+tk3o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TUua4RUml5lUdav+A2wV7f0t04j1fituV3zoCWa8BTV5xkpjUwJ06RF/0dNZAGMfY cS0YdzwxIMwJFVrbjJyw980S3LUUEt1bYmlyaNRODFt4kY9m5kcw08gqKlqpi2RPl1 2+SAIzbumccprkTb/zjrK1C2a9H7rMndI87e1wyU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans de Goede , Mika Westerberg , Linus Walleij Subject: [PATCH 4.14 100/148] gpiolib: acpi: Add quirk to ignore EC wakeups on HP x2 10 BYT + AXP288 model Date: Wed, 1 Apr 2020 18:18:12 +0200 Message-Id: <20200401161602.404317194@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200401161552.245876366@linuxfoundation.org> References: <20200401161552.245876366@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hans de Goede commit 0e91506ba00730f088961a8d39f8693b0f8e3fea upstream. Commit aa23ca3d98f7 ("gpiolib: acpi: Add honor_wakeup module-option + quirk mechanism") was added to deal with spurious wakeups on one specific model of the HP x2 10 series. In the mean time I have learned that there are at least 3 different HP x2 10 models: Bay Trail SoC + AXP288 PMIC Cherry Trail SoC + AXP288 PMIC Cherry Trail SoC + TI PMIC And the original quirk is only correct for (and only matches the) Cherry Trail SoC + TI PMIC model. The Bay Trail SoC + AXP288 PMIC model has different DMI strings, has the external EC interrupt on a different GPIO pin and only needs to ignore wakeups on the EC interrupt, the INT0002 device works fine on this model. This commit adds an extra DMI based quirk for the HP x2 10 BYT + AXP288 model, ignoring wakeups for ACPI GPIO events on the EC interrupt pin on this model. This fixes spurious wakeups from suspend on this model. Fixes: aa23ca3d98f7 ("gpiolib: acpi: Add honor_wakeup module-option + quirk mechanism") Signed-off-by: Hans de Goede Link: https://lore.kernel.org/r/20200302111225.6641-3-hdegoede@redhat.com Acked-by: Mika Westerberg Signed-off-by: Linus Walleij Signed-off-by: Greg Kroah-Hartman --- drivers/gpio/gpiolib-acpi.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) --- a/drivers/gpio/gpiolib-acpi.c +++ b/drivers/gpio/gpiolib-acpi.c @@ -1425,6 +1425,21 @@ static const struct dmi_system_id gpioli .ignore_wake = "INT33FF:01@0,INT0002:00@2", }, }, + { + /* + * HP X2 10 models with Bay Trail SoC + AXP288 PMIC use an + * external embedded-controller connected via I2C + an ACPI GPIO + * event handler on INT33FC:02 pin 28, causing spurious wakeups. + */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), + DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion x2 Detachable"), + DMI_MATCH(DMI_BOARD_NAME, "815D"), + }, + .driver_data = &(struct acpi_gpiolib_dmi_quirk) { + .ignore_wake = "INT33FC:02@28", + }, + }, {} /* Terminating entry */ };