Received: by 2002:a17:90a:1609:0:0:0:0 with SMTP id n9csp848520pja; Wed, 1 Apr 2020 09:47:36 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuhLWdWrmjzDZLSm04u2NmuITHitbeahmpzrmEZkywMb/RPufsUHDWhtr0sTC9t7U6vtw4Y X-Received: by 2002:a9d:2004:: with SMTP id n4mr8180297ota.74.1585759656768; Wed, 01 Apr 2020 09:47:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585759656; cv=none; d=google.com; s=arc-20160816; b=Vyg2HcBWCZzMNFpMQKwqDvdv18wTWlzcCQ+rspzG2c+WYqB+rZkdEIflV4T3YneezI zSRt/9tDzqIfDZ8KfiphP+guilebeF/gfjc8oGZilcXZPPF36muYQtVAPvBXkawQ5blz eRE/ioo0lBPGhvlj1QKUZzNPC9/431LXdBM85WlX0y/4XwFNVGSwtcZMXvfQEVkJeXW3 RN03cUcGhNcQ+rlT5GYxmRJwnooN2yDqoFDy915kt6eaB/kCdM3/tqEbNhdHIPXNJ4wY pJdhfLxKs80cA1QsSwQUZ2Wcy/tStaSo/BzjurqyQz053SdMszoiQYLfrPbDqME3gJqq aM6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=56vq12fp8/XFA+2nPYoRy/667+m3GusFPI1UoYTcmiI=; b=c6jUASLYQ7jvercPCiQLBAUcxvggCaUvHwnkyWmV0745iusBENonrVuRVoviC66xtM NvmRG5s0wtc2GLmSANCnE2ORapjXxckyFlNK0cN5cnpK1Dm496wcy8Ll1vMC5SePjpKR hDFmkYCSwICgh1F/ACm/Smann0Hae8NKnWm2ZOZwqgXp95bfpgGxaydY6DH47LlggcVB 6psFCWOuJtF2UuPEhoM32QVrn7qqHmlOI6NAIEDDGK9wPJT415UiiWh6KLXKAJSk0hSW Pb2hqLN5/ZRFKv2vlYF9/5gnC5wNVWeu1p6LcHO9/UfdGaS4TfBlGTB8D3iPPGbCQNjw cy0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iKB8cuUk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w65si1048614ooa.42.2020.04.01.09.47.23; Wed, 01 Apr 2020 09:47:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iKB8cuUk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389305AbgDAQqX (ORCPT + 99 others); Wed, 1 Apr 2020 12:46:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:47724 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732692AbgDAQqV (ORCPT ); Wed, 1 Apr 2020 12:46:21 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ABF4520705; Wed, 1 Apr 2020 16:46:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585759581; bh=Ueg9Zw03/bC0jrpPrYe2uRa++2Dy+9cvjAOMfNFrvYU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iKB8cuUkB3O9RAKfkIQg8OfyB7FIA9nVzgNBfIawuBwMgdy/MtGTZJZOsxw1ksGtM WMssZsTDsiaYmNryMDmPyhE5hN8xWrd1Gjkb1h5FaZ13+ul0TnEY+AHT0B0/uWl8uc KiK7sf2Cuas4cuf6T5tKpyYVCtdMqfjjFUAd2IyE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dominik Czarnota , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 084/148] sxgbe: Fix off by one in samsung driver strncpy size arg Date: Wed, 1 Apr 2020 18:17:56 +0200 Message-Id: <20200401161601.195347861@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200401161552.245876366@linuxfoundation.org> References: <20200401161552.245876366@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dominik Czarnota [ Upstream commit f3cc008bf6d59b8d93b4190e01d3e557b0040e15 ] This patch fixes an off-by-one error in strncpy size argument in drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c. The issue is that in: strncmp(opt, "eee_timer:", 6) the passed string literal: "eee_timer:" has 10 bytes (without the NULL byte) and the passed size argument is 6. As a result, the logic will also accept other, malformed strings, e.g. "eee_tiXXX:". This bug doesn't seem to have any security impact since its present in module's cmdline parsing code. Signed-off-by: Dominik Czarnota Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c index 89831adb8eb75..6d27eec85fcef 100644 --- a/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c +++ b/drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c @@ -2284,7 +2284,7 @@ static int __init sxgbe_cmdline_opt(char *str) if (!str || !*str) return -EINVAL; while ((opt = strsep(&str, ",")) != NULL) { - if (!strncmp(opt, "eee_timer:", 6)) { + if (!strncmp(opt, "eee_timer:", 10)) { if (kstrtoint(opt + 10, 0, &eee_timer)) goto err; } -- 2.20.1