Received: by 2002:a17:90a:1609:0:0:0:0 with SMTP id n9csp849328pja; Wed, 1 Apr 2020 09:48:31 -0700 (PDT) X-Google-Smtp-Source: APiQypLwR0X95aXtoWcIIUZGhjcgOT3CeO5i+7KCcSy2oUdrUIrvw6RrBY90BluGvfx/j3H/j3XM X-Received: by 2002:aca:bb83:: with SMTP id l125mr3424880oif.122.1585759711626; Wed, 01 Apr 2020 09:48:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585759711; cv=none; d=google.com; s=arc-20160816; b=YefejdOTLG2kzKK9T3IHwfX8uIVZdA6/onTw0RfGI8ZQl5YsoT3IL5MVunGN2sLP5a X2ZB/9k6s9KN8kpxYfxDmeV6cm9F1SVFmofPGdhp+GpJfW4ac9NHcWPi6U2eaG9enGhi jQQyVKBI4QqmiKQ2wGKS3xL81Ai9ty9+sNKnaL++H2JW29WSeC1NgYjIgGI7GEvy3ceL I38g02JH8OJqgi57nrA0nw+dj1/gVG9UAb2jSdk8FSbCnMnz14QYh0ZGDaGmfrQ1jxeW 3JPaEB+AhHSZU82ZEOeVWT0gRS44hZ7B1GwmWhY/K3VjSdJ5eD13ERvDPLEAjtLcydA9 CctA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=S6R+soK+Hd0uVaaW/9nme0YZOYAAYnjoSkNotCAms3c=; b=Kb4xlaJwSFTwYR5DgXbpZzbmGavlDe2jkDkjsgWeuD+miwXVd6h1GoGgrBh35GqM7T RPnbw1s7FratkULxfRbr4PNroL8F8OEN8w96adUmLIOIfNjlOyKgfLVRvsqDvhtNujSX 1fON3TKzZGltesSq3BdSfoXBgdIvQ2zR8wXFyT1Umyc1/SluLG+KNKBqqiTtvr051cRK D8s6Em483++xWyo0Ecb+c7GtS33WH0WWgiteYAondEfXGLqXQT2Ow5tcUXSE7v5YhIeH EXuVNIm6AADh+M+D9SgygYj1PWirIayMnelyN7l3SBFOwpW1KcE6XUX6b0hnAJAXrzde W8kQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BBMLrGJD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r184si1050289oie.79.2020.04.01.09.48.18; Wed, 01 Apr 2020 09:48:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BBMLrGJD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390042AbgDAQrO (ORCPT + 99 others); Wed, 1 Apr 2020 12:47:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:48898 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732274AbgDAQrM (ORCPT ); Wed, 1 Apr 2020 12:47:12 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6BB992063A; Wed, 1 Apr 2020 16:47:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585759631; bh=DAS1rLQ3QSU+5gze+VIMU7IUfWNog+pgb4x5vO0n5vc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BBMLrGJDJq/8FoHS208v+NNBRnfrcmgjSj3g//wM4xN6nv0kb7v6Q89KoOUMTZN0r Z974TQc0C37DX4J9qwz0A+dkr741jFe9Xg3kCsD6movtfhw57OHoMdTVOIKP7NOYRl LHGxTOH8riTqxnaR6nwtgOn85E1MToTiwW4KOgh4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans de Goede , Mika Westerberg , Linus Walleij , Marc Lehmann Subject: [PATCH 4.14 141/148] gpiolib: acpi: Add quirk to ignore EC wakeups on HP x2 10 CHT + AXP288 model Date: Wed, 1 Apr 2020 18:18:53 +0200 Message-Id: <20200401161605.690398479@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200401161552.245876366@linuxfoundation.org> References: <20200401161552.245876366@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hans de Goede commit 0c625ccfe6f754d0896b8881f5c85bcb81699f1f upstream. There are at least 3 models of the HP x2 10 models: Bay Trail SoC + AXP288 PMIC Cherry Trail SoC + AXP288 PMIC Cherry Trail SoC + TI PMIC Like on the other HP x2 10 models we need to ignore wakeup for ACPI GPIO events on the external embedded-controller pin to avoid spurious wakeups on the HP x2 10 CHT + AXP288 model too. This commit adds an extra DMI based quirk for the HP x2 10 CHT + AXP288 model, ignoring wakeups for ACPI GPIO events on the EC interrupt pin on this model. This fixes spurious wakeups from suspend on this model. Fixes: aa23ca3d98f7 ("gpiolib: acpi: Add honor_wakeup module-option + quirk mechanism") Reported-and-tested-by: Marc Lehmann Signed-off-by: Hans de Goede Link: https://lore.kernel.org/r/20200302111225.6641-4-hdegoede@redhat.com Acked-by: Mika Westerberg Signed-off-by: Linus Walleij Signed-off-by: Greg Kroah-Hartman --- drivers/gpio/gpiolib-acpi.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) --- a/drivers/gpio/gpiolib-acpi.c +++ b/drivers/gpio/gpiolib-acpi.c @@ -1440,6 +1440,21 @@ static const struct dmi_system_id gpioli .ignore_wake = "INT33FC:02@28", }, }, + { + /* + * HP X2 10 models with Cherry Trail SoC + AXP288 PMIC use an + * external embedded-controller connected via I2C + an ACPI GPIO + * event handler on INT33FF:01 pin 0, causing spurious wakeups. + */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "HP"), + DMI_MATCH(DMI_PRODUCT_NAME, "HP Pavilion x2 Detachable"), + DMI_MATCH(DMI_BOARD_NAME, "813E"), + }, + .driver_data = &(struct acpi_gpiolib_dmi_quirk) { + .ignore_wake = "INT33FF:01@0", + }, + }, {} /* Terminating entry */ };