Received: by 2002:a17:90a:1609:0:0:0:0 with SMTP id n9csp849477pja; Wed, 1 Apr 2020 09:48:42 -0700 (PDT) X-Google-Smtp-Source: APiQypIzTf3S311iMHUzI2qN4dxmLCh2N+fUWA9xKvLZ4f9vHbUrGy+nx6ehsUU1bpyK5bq2pZ7+ X-Received: by 2002:aca:7213:: with SMTP id p19mr3612409oic.159.1585759722302; Wed, 01 Apr 2020 09:48:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585759722; cv=none; d=google.com; s=arc-20160816; b=zKjJLZbSbXjl+CDfbyjnUM6xrA4lLzQhD6lUHpVs2qekvHQJ2ZaCDjggzSFaOxAsPE cL/IMEaLO8eZEZYpKgTtV1kxceF9h0XYDN1AA5OTzXvK91Ru6nh88ziqxCX1FK9M9ESd LKcaU9TqIY5j9hP1T7mWy+QrI092+JfRPurDbuBO5pZ6PD5TD12Ct+bbtYkrblkpauvr OqNtZaPsZrwRpDxU7xWRo3UCsbOTNGiRTz37u3Zv0KVNfbYUacHTOx9n52a4E6nA/Apn +fwdwf0vXgt3BeVi9WE1DAcXDv3fVuD3gkgnGcfUGtYetwP1ganwhea8FcwmZajAcuYf 32CA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=pJfkQ78MIpLUgfAmGGGXg67648hTM9ag50wh9+P4NTk=; b=DDOtF34Pe60Cs2T86i2dnz0mjWwVrVYI1fiNN1OT1CPEEv8K5v/RA3tN6rxpXQVkvv EznMu2pOa/5L7w19BxOp4FGpwOp7GTAFUsmGYDAx2GzZcbRs7R1briguutCXbqvOB16C Z9PP8orKdxNWPsqRR7v8Q/BN3XIzIRGuvV1eVO2d1L4mRY2dF3qhE4M2YOtv0deBQ8mA jhddI/InDXPoE7O1NZ1pZM9EXYVAX1YiGAlcREFhFaXdYFsbtB0G8EmQGedxoiXet0Yr E21nbKN0/y7t7phtCHUyPbN70zcRZKm3vS2ZwOn7h5DFDXGmqAGlA2KFtf7kRqhjs+B9 kdrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dOaYJCg0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s4si1017619oom.84.2020.04.01.09.48.29; Wed, 01 Apr 2020 09:48:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dOaYJCg0; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389827AbgDAQrW (ORCPT + 99 others); Wed, 1 Apr 2020 12:47:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:49086 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389743AbgDAQrU (ORCPT ); Wed, 1 Apr 2020 12:47:20 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 98C32206E9; Wed, 1 Apr 2020 16:47:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585759640; bh=2s1dfWokLE+QvZy6uWmoeW9BrczpJ9Zz5y4oHMEf5J8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dOaYJCg0RtHi/hEqu8E6vlHKiPx1TgOls3egRhIYFuEoGOB5R2qrSMJFslUw8T/kK 6Nux189/nYhRT0HMShSu2Jcsc/0bWqnDaIeId+r+nSJh/wTKV4ihj4m4PvLYf0EDbe uktTsAdLzkoXp2uhE4jouBEWHCXXU2WlRdF1GoWo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, disconnect3d , Alexander Shishkin , Changbin Du , Jiri Olsa , John Keeping , Mark Rutland , Michael Lentine , Namhyung Kim , Peter Zijlstra , Song Liu , Stephane Eranian , Arnaldo Carvalho de Melo Subject: [PATCH 4.14 144/148] perf map: Fix off by one in strncpy() size argument Date: Wed, 1 Apr 2020 18:18:56 +0200 Message-Id: <20200401161605.909751564@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200401161552.245876366@linuxfoundation.org> References: <20200401161552.245876366@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: disconnect3d commit db2c549407d4a76563c579e4768f7d6d32afefba upstream. This patch fixes an off-by-one error in strncpy size argument in tools/perf/util/map.c. The issue is that in: strncmp(filename, "/system/lib/", 11) the passed string literal: "/system/lib/" has 12 bytes (without the NULL byte) and the passed size argument is 11. As a result, the logic won't match the ending "/" byte and will pass filepaths that are stored in other directories e.g. "/system/libmalicious/bin" or just "/system/libmalicious". This functionality seems to be present only on Android. I assume the /system/ directory is only writable by the root user, so I don't think this bug has much (or any) security impact. Fixes: eca818369996 ("perf tools: Add automatic remapping of Android libraries") Signed-off-by: disconnect3d Cc: Alexander Shishkin Cc: Changbin Du Cc: Jiri Olsa Cc: John Keeping Cc: Mark Rutland Cc: Michael Lentine Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Song Liu Cc: Stephane Eranian Link: http://lore.kernel.org/lkml/20200309104855.3775-1-dominik.b.czarnota@gmail.com Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Greg Kroah-Hartman --- tools/perf/util/map.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/tools/perf/util/map.c +++ b/tools/perf/util/map.c @@ -90,7 +90,7 @@ static inline bool replace_android_lib(c return true; } - if (!strncmp(filename, "/system/lib/", 11)) { + if (!strncmp(filename, "/system/lib/", 12)) { char *ndk, *app; const char *arch; size_t ndk_length;