Received: by 2002:a17:90a:1609:0:0:0:0 with SMTP id n9csp849609pja; Wed, 1 Apr 2020 09:48:51 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtOR4DcdE7bFoVI7iL1dn9beQpt9UvOhHi2Tqv9XrzHovY4Vhtbv8vFcj+rRpGugZIy4tWv X-Received: by 2002:a9d:798a:: with SMTP id h10mr17033225otm.367.1585759731011; Wed, 01 Apr 2020 09:48:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585759731; cv=none; d=google.com; s=arc-20160816; b=Dqd/BBRSXTumv3JiaOP3mDBH2Ab6RHi7QDQffMJvPWM6H0YLpB6hUc01R6jOfuVho2 8JQroEQMCwQgAIP2LqI6/Xi44ePG2jVDphgrR6Tn5JKbUBCcYvp5Nbc4gLqny9F5V+4J lqGLflO8ytsetJRRRDoa8ftY7xEvkOvKJVfVQ5uOEcs8Z3BcegbSdxOf9I6JFd8X0bnj uSxj7yBbWSkIq6tuUgbe+CQNj0OQXUMuUYlnUoU86CMH+WipyIgSthYUm6ya8ShbINL5 E/sfA5UO4pQKdRfKiA7ScQRsdFIrAoTpB7N7Fv3+h40WBzMjYEseyOZGRfPJocyJRoA8 pVLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hq7UYeEqfPWPsXBbnzAu0bVac0GHvqDZbW5ck/SfZ44=; b=rT31fqRwqSgtuKcFpIsmS6rjy1OoW5tG3R6ivMnPE+l/KNh63gi8W63Nn69uV1usFZ /1ieJZRrBX6BpX1AN2O0mghiDQJ9N4sQXqkB5JcmmUwG/uHBcZ4AYwAh8aG+LbHTG5w2 xtzaHW2qTW0t4zZjjZPgVY5SOruJYZ9wR5VzKSaJsPTu+fIn6XNyGtljpyy3zMPPA4MO i5tHoKYvpOctFbNOqjm1W1HfCbSjCSPpEMx5hiyPd4zKevpcLte/T6gowXQNVg5+s9Fm 7f4mFeU6GMPTIPo2CEnVbEOG5tpQCfRYnGc46UorhSgp0yVhH4P3s1bXV4Nj8YR3O8jU 8dyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0SWfBJfx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e53si1032311ote.156.2020.04.01.09.48.38; Wed, 01 Apr 2020 09:48:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0SWfBJfx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389359AbgDAQre (ORCPT + 99 others); Wed, 1 Apr 2020 12:47:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:49312 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387584AbgDAQrb (ORCPT ); Wed, 1 Apr 2020 12:47:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EC9CA206E9; Wed, 1 Apr 2020 16:47:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585759651; bh=Op48cop4jbFJ8CRSjIoNwXhE6DUpal4AaiXbOY4VzOs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0SWfBJfxujv+yaJJuMWDDHsiKpZtISadF8OI9N+khZMwUQwvI/6SnAnCPtM7vqO/G ZpMgIAHkQN2EiWyhAvkwd2QBnzwccHSMBZYS//AIFG1eBdB/YsmthKPlLmO4nHMYoC hz9Fh24TrqQL+Kw/WWT80FYShXNVURlEP1V/k3Ew= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Madalin Bucur , "David S. Miller" Subject: [PATCH 4.14 147/148] arm64: dts: ls1043a-rdb: correct RGMII delay mode to rgmii-id Date: Wed, 1 Apr 2020 18:18:59 +0200 Message-Id: <20200401161606.129079026@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200401161552.245876366@linuxfoundation.org> References: <20200401161552.245876366@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Madalin Bucur commit 4022d808c45277693ea86478fab1f081ebf997e8 upstream. The correct setting for the RGMII ports on LS1043ARDB is to enable delay on both Rx and Tx so the interface mode used must be PHY_INTERFACE_MODE_RGMII_ID. Since commit 1b3047b5208a80 ("net: phy: realtek: add support for configuring the RX delay on RTL8211F") the Realtek 8211F PHY driver has control over the RGMII RX delay and it is disabling it for RGMII_TXID. The LS1043ARDB uses two such PHYs in RGMII_ID mode but in the device tree the mode was described as "rgmii_txid". This issue was not apparent at the time as the PHY driver took the same action for RGMII_TXID and RGMII_ID back then but it became visible (RX no longer working) after the above patch. Changing the phy-connection-type to "rgmii-id" to address the issue. Fixes: bf02f2ffe59c ("arm64: dts: add LS1043A DPAA FMan support") Signed-off-by: Madalin Bucur Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dts @@ -155,12 +155,12 @@ ethernet@e4000 { phy-handle = <&rgmii_phy1>; - phy-connection-type = "rgmii-txid"; + phy-connection-type = "rgmii-id"; }; ethernet@e6000 { phy-handle = <&rgmii_phy2>; - phy-connection-type = "rgmii-txid"; + phy-connection-type = "rgmii-id"; }; ethernet@e8000 {