Received: by 2002:a17:90a:1609:0:0:0:0 with SMTP id n9csp849802pja; Wed, 1 Apr 2020 09:49:04 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsUpeDF9U99hSbHo7J6jA2M7TzZkGdgWbG9t3dzfAefi2n+1UGWebSFgMZMb9UsbrRjJlM0 X-Received: by 2002:a05:6830:1bc9:: with SMTP id v9mr16671169ota.169.1585759743916; Wed, 01 Apr 2020 09:49:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585759743; cv=none; d=google.com; s=arc-20160816; b=bYDbAkknvMltNNRUJs7wpV5fZgVbW1KUWYsTWbCMFg4HP+0m/Np2wuTsOaioT/cayc ffJy/W8sGn2yF2Bf8zmhb3I1QeCA43slV0DjCyhEqli1JPHecavxG7ovrc58rbY9IP0k wyq9ZtqSlfWg/cm/D0z1fUyGwrLp6diI13eJAjBrP0qCTwVCG5ol9eKq7YApVXsk7oMz AUlMeLiP0j3cx79Vyzl844oRTM38witfUYusI0hwS9ZlfxR0hQLDdGQsvTVRw3oz1L3L 3XxZ/5xjXghH4LQyqEr4rZ+kLBsbl/TMK4onjXC3Ykw5TwqmaZRGEB0DERWW7zqLfUYB JtJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=JK10eYPTN8MkIqa0ddCX5cTZ7ULqEJ+cvNuG5/0VK0E=; b=WIAuxK0Z1ZDTco0sEbf6MTuGAAWlNq2ik9La0Mt3OAvwNnHU/PWeuhpfarrSmF6NOL KHjJ6SQhT5k3IqZo+VA2wflkP0IXYJFqmcMRbCmJDUn1xem1k4mqDgg9HAbMWyAOWjVt ekqcEwlIfUdcFF0PtctNbGOtVPSIveznFdCtrPGvx5DStQjxHM0R5b6ISfmC5NWUqzwf 5c99erx5Witg9Uj1A8sgefLirKBccUb8VV6J6IgpO1vh14/M3FfY1gTkuCLm9QjQLQ/H UhQ3D7HiSASj+byDOqdAB99OE8dGur9RwLi2cDY0YYqrVEFMdSCTa8I2fU66CKTfDfR7 aj/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=z9Y5uNCm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j9si1030625oif.164.2020.04.01.09.48.50; Wed, 01 Apr 2020 09:49:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=z9Y5uNCm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390091AbgDAQrt (ORCPT + 99 others); Wed, 1 Apr 2020 12:47:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:49644 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389876AbgDAQrr (ORCPT ); Wed, 1 Apr 2020 12:47:47 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0734420705; Wed, 1 Apr 2020 16:47:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585759666; bh=v8v86mcqKebP1xNYBWqT+A+ourgd6/xxVqfLpQwzu+I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=z9Y5uNCmU464vJifY+8vocR75C2awCa74p5IwHhLDS4OpapeHBgtnreuvoCQKncaG b/qSRmlBW6N48XGEm9jksHlQRrs/wx0E+7W26Ts5u2zgBo+mMrPHoX04msyQYWl82x 7vWT4XT9o8sFXW3eUqL6LZBws62mj4GEs3C/PbKg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Qiujun Huang , syzbot+7d42d68643a35f71ac8a@syzkaller.appspotmail.com Subject: [PATCH 4.14 124/148] staging: wlan-ng: fix use-after-free Read in hfa384x_usbin_callback Date: Wed, 1 Apr 2020 18:18:36 +0200 Message-Id: <20200401161604.328283327@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200401161552.245876366@linuxfoundation.org> References: <20200401161552.245876366@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qiujun Huang commit 1165dd73e811a07d947aee218510571f516081f6 upstream. We can't handle the case length > WLAN_DATA_MAXLEN. Because the size of rxfrm->data is WLAN_DATA_MAXLEN(2312), and we can't read more than that. Thanks-to: Hillf Danton Reported-and-tested-by: syzbot+7d42d68643a35f71ac8a@syzkaller.appspotmail.com Signed-off-by: Qiujun Huang Cc: stable Link: https://lore.kernel.org/r/20200326131850.17711-1-hqjagain@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/wlan-ng/hfa384x_usb.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/staging/wlan-ng/hfa384x_usb.c +++ b/drivers/staging/wlan-ng/hfa384x_usb.c @@ -3495,6 +3495,8 @@ static void hfa384x_int_rxmonitor(struct WLAN_HDR_A4_LEN + WLAN_DATA_MAXLEN + WLAN_CRC_LEN)) { pr_debug("overlen frm: len=%zd\n", skblen - sizeof(struct p80211_caphdr)); + + return; } skb = dev_alloc_skb(skblen);