Received: by 2002:a17:90a:1609:0:0:0:0 with SMTP id n9csp850344pja; Wed, 1 Apr 2020 09:49:36 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuTe+Yw0sv5pRCoKzI92wSkVEyWl2vn3im2dEk49sXK+/bwMhFcaMh4y0Gpc8TUxfw1pcZU X-Received: by 2002:a9d:5ad:: with SMTP id 42mr18739762otd.231.1585759776232; Wed, 01 Apr 2020 09:49:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585759776; cv=none; d=google.com; s=arc-20160816; b=bxJu0qm9fpiCfesp8EAQs48YljemuolspYGsmVwMPYnBLFHuv5XtgTsKmf1lXtdyjx JBjGWWIx5wVAi+2O7ViGdBQjH3T8zscyuwcdYbMGASJVQ+uDN6EphGSYda51qUB8c2E6 wJrY9gvQpszJ24Z5ekzXEMC31KRn/LI9zKYcWdkdF9tpuSWFeeXN2Zk0b9IVMzLZ4qgP ZTR0bljU7oDCqXdf+X+AAQCOCcSaA3U357EzNznVhwSJG4RztQZ8KlaIqwvuwyBnzy67 rM8T/FjbBPpQesRvaRL/fVYJ6GCQgFgk5QAsfyX4kQ2aBjCKys7G36VIpfYI4Tn3u506 lNzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jmJPDz1ifDlmOb6t3Fw/BAtNvsqxGODCCqaGTNfzyO4=; b=Ajx52NGfiIkngG7ca/fPpqotjcOxJXNiwgWdynwu0ZxUQsbJgbQBkwK3y0m6dLU5Io /Ya27CC24lV2V2kA4uCScg96kaZ7Uk6rZYdwMwg78MrhZb4MRm1ZQ9iRZqCfw4aGXG7q LeMD/VOb8fOjRs+wx0ZhGWaQXwjTEhcdHczO1mlj/Y3AlM0C33nuR/a9ateS6oTPHyuK BTbFIWh4EhvZ5dMesHmkX6GWAoqHTlp9dg2F5EFyfoGju3jN+hMbmzRXVmBT9WXp/o8Q hWdgvz9yR6ZYXm5ZfkNAshdsAjS+1/pEdsdNP4h7iP+SrHg/bweWOVMFvMs/92diltII a2sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=v1bMtr9g; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z9si1055169oih.157.2020.04.01.09.49.23; Wed, 01 Apr 2020 09:49:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=v1bMtr9g; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389792AbgDAQrr (ORCPT + 99 others); Wed, 1 Apr 2020 12:47:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:49574 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389882AbgDAQrm (ORCPT ); Wed, 1 Apr 2020 12:47:42 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9E0B6206E9; Wed, 1 Apr 2020 16:47:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585759662; bh=QQ6ebnUvoHQNHZ6qn9BQCIRm9XiS9wC5bt9itZPaTN4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=v1bMtr9gt0xOtdKTYpstzN59/gl2qsxJCgihYtqKieU5L5n1ITKRlymjq8hWxTlCc fjEs/pOI79fGoHjbLb74vtxbMKvpTSWEtXC9TK+St2vnphSW/2e7+48h7GM6TJKcA8 jCS0QkU/EpVHDjAQz1YbXU2trmhQozCezDKvKzzI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+6d2e7f6fa90e27be9d62@syzkaller.appspotmail.com, Qiujun Huang Subject: [PATCH 4.14 123/148] staging: wlan-ng: fix ODEBUG bug in prism2sta_disconnect_usb Date: Wed, 1 Apr 2020 18:18:35 +0200 Message-Id: <20200401161604.241662319@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200401161552.245876366@linuxfoundation.org> References: <20200401161552.245876366@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qiujun Huang commit a1f165a6b738f0c9d744bad4af7a53909278f5fc upstream. We should cancel hw->usb_work before kfree(hw). Reported-by: syzbot+6d2e7f6fa90e27be9d62@syzkaller.appspotmail.com Signed-off-by: Qiujun Huang Cc: stable Link: https://lore.kernel.org/r/1585120006-30042-1-git-send-email-hqjagain@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/wlan-ng/prism2usb.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/staging/wlan-ng/prism2usb.c +++ b/drivers/staging/wlan-ng/prism2usb.c @@ -180,6 +180,7 @@ static void prism2sta_disconnect_usb(str cancel_work_sync(&hw->link_bh); cancel_work_sync(&hw->commsqual_bh); + cancel_work_sync(&hw->usb_work); /* Now we complete any outstanding commands * and tell everyone who is waiting for their