Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp898057ybb; Wed, 1 Apr 2020 11:40:14 -0700 (PDT) X-Google-Smtp-Source: APiQypJRElPRo86xsOgqHbRc9wD6qRiCtPLEKnEjcjA6eiGEydSx6kMBo+NDs8Bs0tvRh9+ek+sE X-Received: by 2002:aca:4a56:: with SMTP id x83mr3985987oia.166.1585766414402; Wed, 01 Apr 2020 11:40:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585766414; cv=none; d=google.com; s=arc-20160816; b=FuBYi6YaX8L18gUXyglo2gpCePJwRl/gtErJOOKqIdkf0bHIy9uALzkiqkRh1uVOsX H38gKOCw/GJ51cV0us1lGemtvYACMWQdnJ05TFU4teXWtViR5YZ+NztoV4HsQsekkE4B RbHjxYSajtHGvDQVqCVCqFK960FZ5Vsz1OiRVnezksqcYf8e8L64VmLccNLXqCSJ6ird YtE5ndcRE4UWDxyN4dyrWQt1t1XpSIb1xOIWUB+g2tMjOlyWZD7Q9BSIqrcBf/ZHosEJ 9zi6TE70L3nVpIbPkQDN5+5poSSkjjO5pwgwZIzO2p1ugHlKWe+EQNJNKl1aaJOZ4uBg XhBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=+cML1l3ZXp0pkybAZO1Fx341XpHD1EAtfDw5B8n91tA=; b=qsmflc6lYxupyZLYmuzZaCBzAVHE5w/GH8pO78+j8I41CIs0BoJxBQeoJHS9lroMHM VjcH197WMvXGJ4qYimBl5hLF1Jyu7Qqm6BjKyScbds5k6LPA6qYAar6B4fF0X8/ShGlK dDJv4L9+aFhCs1UPdWlEK02ZOjusDUx+Bo1BEiV4gl1AysoOOgFAG+0u+QRLl+tWdHG1 OxfjW1to5s/EOsIx1LBf/swsNv+WGCu75BPk0A6r5q+vsY2S6LKieHuJw6FxSAVJ2N2Z H6Mmuy2npAL2ncxMl9T/JTPQX5717wC+MmvNVjFeMkey6k2pGZ3igO/69CTHHTDSpa7V hJvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="PX2jvi5/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l25si1185885otb.234.2020.04.01.11.40.01; Wed, 01 Apr 2020 11:40:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="PX2jvi5/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732819AbgDARrH (ORCPT + 99 others); Wed, 1 Apr 2020 13:47:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:40734 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732328AbgDARrG (ORCPT ); Wed, 1 Apr 2020 13:47:06 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 95D7820784; Wed, 1 Apr 2020 17:47:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585763226; bh=pSIBaD4+b+O8FNdmNyWvEINRgzApDBhx/6Kuu3tMRp4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=PX2jvi5/L/tyYNgbVT33eJrZ6Kl3dvqqGooWnn0Pffl/OUuILH++8UCg+URc3P50O UNHR/jeMTYFJn+9OPnDOAcNZXKhbDQsNw0bEld7tXLJgMQVhSdgxEYbQp9tZ/tjSVo hB1fZaKfpxczh/7FPOjFTftUtl8bp7BHfd9tYLvc= Subject: Re: [PATCH v8 kunit-next 1/4] kunit: add debugfs /sys/kernel/debug/kunit//results display To: Alan Maguire , brendanhiggins@google.com, frowand.list@gmail.com, gregkh@linuxfoundation.org, linux-kselftest@vger.kernel.org Cc: corbet@lwn.net, linux-kernel@vger.kernel.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, shuah References: <1585232710-322-1-git-send-email-alan.maguire@oracle.com> <1585232710-322-2-git-send-email-alan.maguire@oracle.com> From: shuah Message-ID: <0d310181-a172-dec9-19aa-337ece9d7380@kernel.org> Date: Wed, 1 Apr 2020 11:47:05 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <1585232710-322-2-git-send-email-alan.maguire@oracle.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alan, On 3/26/20 8:25 AM, Alan Maguire wrote: > add debugfs support for displaying kunit test suite results; this is > especially useful for module-loaded tests to allow disentangling of > test result display from other dmesg events. debugfs support is > provided if CONFIG_KUNIT_DEBUGFS=y. > > As well as printk()ing messages, we append them to a per-test log. > > Signed-off-by: Alan Maguire > Reviewed-by: Brendan Higgins > Reviewed-by: Frank Rowand > --- > include/kunit/test.h | 54 +++++++++++++++--- > lib/kunit/Kconfig | 8 +++ Missing defaults for config options? > lib/kunit/Makefile | 4 ++ > lib/kunit/debugfs.c | 116 ++++++++++++++++++++++++++++++++++++++ > lib/kunit/debugfs.h | 30 ++++++++++ > lib/kunit/kunit-test.c | 4 +- > lib/kunit/test.c | 147 ++++++++++++++++++++++++++++++++++++++----------- > 7 files changed, 322 insertions(+), 41 deletions(-) > create mode 100644 lib/kunit/debugfs.c > create mode 100644 lib/kunit/debugfs.h > snip > diff --git a/lib/kunit/Kconfig b/lib/kunit/Kconfig > index 065aa16..95d12e3 100644 > --- a/lib/kunit/Kconfig > +++ b/lib/kunit/Kconfig > @@ -14,6 +14,14 @@ menuconfig KUNIT > > if KUNIT > > +config KUNIT_DEBUGFS > + bool "KUnit - Enable /sys/kernel/debug/kunit debugfs representation" > + help > + Enable debugfs representation for kunit. Currently this consists > + of /sys/kernel/debug/kunit//results files for each > + test suite, which allow users to see results of the last test suite > + run that occurred. > + Any reason why there is default for this option? Same for all other options. I am sending pull request for now without defaults. Would like to see this fixed for rc2. thanks, -- Shuah