Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Benoit HOUYERE <benoit.houyere@st.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
        "amirmizi6@gmail.com" <amirmizi6@gmail.com>
CC:     "Eyal.Cohen@nuvoton.com" <Eyal.Cohen@nuvoton.com>,
        "oshrialkoby85@gmail.com" <oshrialkoby85@gmail.com>,
        "alexander.steffen@infineon.com" <alexander.steffen@infineon.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "mark.rutland@arm.com" <mark.rutland@arm.com>,
        "peterhuewe@gmx.de" <peterhuewe@gmx.de>,
        "jgg@ziepe.ca" <jgg@ziepe.ca>, "arnd@arndb.de" <arnd@arndb.de>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-integrity@vger.kernel.org" <linux-integrity@vger.kernel.org>,
        "oshri.alkoby@nuvoton.com" <oshri.alkoby@nuvoton.com>,
        "tmaimon77@gmail.com" <tmaimon77@gmail.com>,
        "gcwilson@us.ibm.com" <gcwilson@us.ibm.com>,
        "kgoldman@us.ibm.com" <kgoldman@us.ibm.com>,
        "Dan.Morav@nuvoton.com" <Dan.Morav@nuvoton.com>,
        "oren.tanami@nuvoton.com" <oren.tanami@nuvoton.com>,
        "shmulik.hager@nuvoton.com" <shmulik.hager@nuvoton.com>,
        "amir.mizinski@nuvoton.com" <amir.mizinski@nuvoton.com>,
        Christophe Richard <hristophe-h.ricard@st.com>
Subject: RE: [PATCH v4 2/7] tpm: tpm_tis: Add check_data handle to
 tpm_tis_phy_ops in order to check data integrity
Thread-Topic: [PATCH v4 2/7] tpm: tpm_tis: Add check_data handle to
 tpm_tis_phy_ops in order to check data integrity
Thread-Index: AQHWB/5sTOWTIuzRBUKbjmfl723Xlqhks7pQ
Date:   Wed, 1 Apr 2020 20:18:14 +0000
Message-ID: <173e4e392b9648b7afeb09680d8073b5@SFHDAG3NODE3.st.com>
References: <20200331113207.107080-1-amirmizi6@gmail.com>
 <20200331113207.107080-3-amirmizi6@gmail.com>
 <20200401082019.GB17325@linux.intel.com>
In-Reply-To: <20200401082019.GB17325@linux.intel.com>
Accept-Language: fr-FR, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

>>On Tue, Mar 31, 2020 at 02:32:02PM +0300, amirmizi6@gmail.com wrote:
>> From: Amir Mizinski <amirmizi6@gmail.com>
>>=20
>> In order to compute the crc over the data sent in lower layer  (I2C=20
>> for instance), tpm_tis_check_data() calls an operation (if available) =20
>> to check data integrity. If data integrity cannot be verified, a retry =
=20
>> attempt to save the sent/received data is implemented.
>>=20
>> The current steps are done when sending a command:
>>     1. Host writes to TPM_STS.commandReady.
>>     2. Host writes command.
>>     3. Host checks that TPM received data is valid.
>>     4. If data is currupted go to step 1.
>>=20
>> When receiving data:
>>     1. Host checks that TPM_STS.dataAvail is set.
>>     2. Host saves received data.
>>     3. Host checks that received data is correct.
>>     4. If data is currupted Host writes to TPM_STS.responseRetry and go =
to
>>         step 1.
>>=20
>> Co-developed-by: Christophe Richard <hristophe-h.ricard@st.com>
>> Signed-off-by: Christophe Richard <hristophe-h.ricard@st.com>
>> Signed-off-by: Amir Mizinski <amirmizi6@gmail.com>

>The email is malformed.

>So.. How did Christophe participate on writing this patch? I haven't seen =
him shouting anything about the subject and still his SOB is there.

>/Jarkko

Christophe sent patch to support I2C TCG TPM driver tpm_tis_i2c (https://pa=
tchwork.kernel.org/patch/8628681/) in the same time that tpm_tis_spi. This =
function was named tpm_tis_i2c_check_data.

Best Regards,