Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1011464ybb; Wed, 1 Apr 2020 13:56:31 -0700 (PDT) X-Google-Smtp-Source: APiQypI7o43YeQOBlGK8jzJ3yy4RYZdlDHUGRqpzwy8tC5Fn4F031kavd0yLX+aiEDvh9JFPxq0q X-Received: by 2002:aca:bd0b:: with SMTP id n11mr209018oif.90.1585774590953; Wed, 01 Apr 2020 13:56:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585774590; cv=none; d=google.com; s=arc-20160816; b=yAgFrYCGc3HDw74ynHz9ilii0JBP8L+Nf7XzroGmK/lGahGnuVXUR+P6hDAROdD7AF y9oE9C0StRFkpzogE/YpZ7nIbkAy02RwEy4/QKCMixkMxq8TGSpVVKhlX4XW3GJOZlDz EW9KAg5SV6s1fzLdzSOqpPf9DpqNjl3g+73FcxqAumMmaalj7rbe0wGuokwSUmvEi3rm Y5k6QbUmJCRcyEhCCeXVCroaeF2TedcMh2l3zAoiz4hDtbW8oey6ys0G+g/V7/njO+Zx XNa2kaAe+i0GLDMn6zBwVfLZ3bEqmOJoBPyqgwbBayJy/SvQDfU1SLQ3414YYQY4hA8W ZNAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=yuHnHVGl5Hl/LCLky/lKRjfVSplQ/H5ogoCU1HMx1e8=; b=yGbp3oOGln2ZBnwzXcuBUoEScBUHRAYDLHlhv00eJJUlTiPYR8bPdW9h7OOUimKUIw x+2VmqSKL5vqy0/w3HIZQwnlV/XLxRUieQmSdi3SENibRKO8KDQb79Cxgrb2KkzcGm3C raLzp3hlZKQgh86gewtE1WEOSUoZNXEP6ha3JN6Zv9O7hkm4Y//+39jBI9WuXlwonZ+t M/UG//ZNdBCayz9GoAlje5hKuWVj/A9QvD+x9/+bWiwuaMOSyRQfnnRjAdrJDfB9Fxr3 Bfj67hoE5Wln8al1GCVx8HBDks5ZZXd7SUOmKAOJ6fmxRnKg6g3fu8QoxKhc3ieV8ljc phkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=WWbKUEBx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m67si1293865oib.215.2020.04.01.13.56.17; Wed, 01 Apr 2020 13:56:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=WWbKUEBx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732888AbgDAUze (ORCPT + 99 others); Wed, 1 Apr 2020 16:55:34 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:33971 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732793AbgDAUze (ORCPT ); Wed, 1 Apr 2020 16:55:34 -0400 Received: by mail-lf1-f65.google.com with SMTP id e7so935163lfq.1 for ; Wed, 01 Apr 2020 13:55:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yuHnHVGl5Hl/LCLky/lKRjfVSplQ/H5ogoCU1HMx1e8=; b=WWbKUEBx25usiEQ2sOtMr/aJGGNl/SWad/qB+6BBXRmLdbbOPDw+0Em7vvCLC8KHwE L0cmqvLGhMWA3DKwcIP/ALfr/FFFkSk9t8gs4fHWuRB/MEmppOKWwLyW0SIfro25/I7O JCyragl/0Fvlx0Ib8Kr7EkEmR2XWHQ4+fVTn8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yuHnHVGl5Hl/LCLky/lKRjfVSplQ/H5ogoCU1HMx1e8=; b=CrTA14XQ0++K7Cn++trb9Zvm3UIekHYWJEs4rKmAhTAX1vqSR/QrG+HeN2j89avFBS cw/fWIvhwcmqtZhcBrLyHxsFkTOhvWXSIFCCyIBuQQ7pJ0q2Aiu3gsDVcymABmTDvgtX vH7ZjMRVp0AxfS4QdBQaVJ7m937N/C6VIU1coAPR8uK43e63Q/9LBZGAtzepJRqMhOvn x6Zgz+XO6V5r+XwOaAHCiAEkc+5nevPMM4ReEG8ceQSQFFq10Tk1GLOdcBsVU/oLrvrI KN4WpO3iPxGpLDsirog8EDIAGi5a4g/7DE9E5CNHzGF6aaN6PNcWVlckglq+6AfWLDzV xp3A== X-Gm-Message-State: AGi0PuZJmO/Wo9T2gkprwuvMFkzxE758//LscLPJV3OkwneO9wW5Qx+B X9LiHO0j6/KwEd5xVTAyPQQGYze8ldo= X-Received: by 2002:a05:6512:3189:: with SMTP id i9mr43969lfe.178.1585774529140; Wed, 01 Apr 2020 13:55:29 -0700 (PDT) Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com. [209.85.208.175]) by smtp.gmail.com with ESMTPSA id q22sm1909898ljh.3.2020.04.01.13.55.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Apr 2020 13:55:28 -0700 (PDT) Received: by mail-lj1-f175.google.com with SMTP id r24so974792ljd.4 for ; Wed, 01 Apr 2020 13:55:27 -0700 (PDT) X-Received: by 2002:a2e:8652:: with SMTP id i18mr62644ljj.265.1585774527625; Wed, 01 Apr 2020 13:55:27 -0700 (PDT) MIME-Version: 1.0 References: <20200324215049.GA3710@pi3.com.pl> <202003291528.730A329@keescook> <87zhbvlyq7.fsf_-_@x220.int.ebiederm.org> In-Reply-To: <87zhbvlyq7.fsf_-_@x220.int.ebiederm.org> From: Linus Torvalds Date: Wed, 1 Apr 2020 13:55:11 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] signal: Extend exec_id to 64bits To: "Eric W. Biederman" Cc: Adam Zabrocki , Linux Kernel Mailing List , Kernel Hardening , Jann Horn , Oleg Nesterov , Andy Lutomirski , Bernd Edlinger , Kees Cook , Andrew Morton , stable Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 1, 2020 at 1:50 PM Eric W. Biederman wrote: > > I have updated the update of exec_id on exec to use WRITE_ONCE > and the read of exec_id in do_notify_parent to use READ_ONCE > to make it clear that there is no locking between these two > locations. Ack, makes sense to me. Just put it in your branch, this doesn't look urgent, considering that it's something that has been around forever. Linus