Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1116164ybb; Wed, 1 Apr 2020 16:12:31 -0700 (PDT) X-Google-Smtp-Source: APiQypLNFRNpWI5u81x2arf8DNUoe87MmBH2sC3wtXqfp5FPDKv/l7lgQ+qiABI+W5QCrxR6zvfV X-Received: by 2002:aca:fd0d:: with SMTP id b13mr248772oii.179.1585782751053; Wed, 01 Apr 2020 16:12:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585782751; cv=none; d=google.com; s=arc-20160816; b=Yf/piyEDphBI5RUwsSpxPK9SZTYNxjx5Gr7o5IrdFkrmoyuduua7yT6qq9CTDMEJHX wz/aNeKgPHc2P5ZBPhRbaRf/H1juZQbbEZYi4cRqVegMj2v2k4ngckZ4p+lPXJhx6jAl JLCqTDHCjrDRVuYC7QE+tDXCOSyRAzZdt5ntmhIOTB3uQk+roVE6viBJECynJq41CYWH iPvPlavImK2AKIVF6EnRQACMM4yzFGB4trzp3HYcqyc/u9iVtt/ufnqcnyHiR1OcwiCt ERRMuQkyBtt7Qg8nTBEWTNg8aK+9GDo2TVDyTqPC7tf8XR0rZrZPYqt1MTQQeZBP9CTh 7r3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=lmBPkGbucE+VEUuY3qo4WsVWD9KDT07YlPGt04lu+Q0=; b=yAmjfihhxG3kUYrxZBpbjUXeR9KZxI+QBGFUTWmXa5rqY+Gix9+LiES0T12ddzDb7O hBj/Nx+9BRL+oT02xsG02Ywale5zGzZThwD0HdcivtxKgKyHAJhkvSPaD13hZjIp1NeD 5BPP++Gt11+LSHHd7oWn7XcRd7uGh57qRBIu9zs/PnoUbNGOvv9MDIgxbm3VkACODW9D QM+0tf47wrzV5r5nghTUfAejvNxxGXjWzq1uYWCqvgf8uSajU3wTDQl/WDqSvUlAe7x8 8cQa4f6emHIqCruApbIBtKj7zVdKfve+0gMwB0oO/+RrTNZLntOSu76nKfxGJfJZDAxM xGrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mOb+cGJ7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v17si1492402otq.250.2020.04.01.16.12.18; Wed, 01 Apr 2020 16:12:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mOb+cGJ7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733193AbgDAW6d (ORCPT + 99 others); Wed, 1 Apr 2020 18:58:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:56520 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732537AbgDAW6c (ORCPT ); Wed, 1 Apr 2020 18:58:32 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C90F6206E9; Wed, 1 Apr 2020 22:58:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585781912; bh=Kh5mNuBzVwAUptRbGYaW4hwn1mM92cXaa8ZH4GIqyjI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mOb+cGJ7ozCiEGTcffpZLjjIhX/YfB87UB79kLOqNXD9sin9Cz/8lhnY3QO1BzwYm NtfIJodLgwn/VC52YbQgVigMxgejaxGtrf9PvJcN268SqE31KE/lmPnnklVAlHdxZe 6FhtA2DePSOteTR8L+1/YbllmSydqyteDpGR0FH8= Date: Wed, 1 Apr 2020 15:58:31 -0700 From: Andrew Morton To: Stephen Rothwell Cc: Linux Next Mailing List , Linux Kernel Mailing List , Longpeng , Jason Gunthorpe , Mike Kravetz , Jason Gunthorpe , Matthew Wilcox , Sean Christopherson Subject: Re: linux-next: build warning after merge of the akpm-current tree Message-Id: <20200401155831.24aa79ebbb14c654a2bee8c0@linux-foundation.org> In-Reply-To: <20200331195612.64c06485@canb.auug.org.au> References: <20200331195612.64c06485@canb.auug.org.au> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 Mar 2020 19:56:12 +1100 Stephen Rothwell wrote: > Hi all, > > After merging the akpm-current tree, today's linux-next build (i386 > defconfig) produced this warning: > > mm/hugetlb.c: In function 'huge_pte_offset': > cc1: warning: function may return address of local variable [-Wreturn-local-addr] > mm/hugetlb.c:5361:14: note: declared here > 5361 | pud_t *pud, pud_entry; > | ^~~~~~~~~ > cc1: warning: function may return address of local variable [-Wreturn-local-addr] > mm/hugetlb.c:5360:14: note: declared here > 5360 | p4d_t *p4d, p4d_entry; > | ^~~~~~~~~ > > Introduced by commit > > 826ddc88e2cf ("mm/hugetlb: fix a addressing exception caused by huge_pte_offset") I can reproduce this (i386 defconfig, gcc-7.2.0). I can see no way in which this makes any sense. Hopefully it's a gcc bug but it's hard to see how it could have messed up this fairly simple code.