Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932547AbWBXVag (ORCPT ); Fri, 24 Feb 2006 16:30:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932562AbWBXVaf (ORCPT ); Fri, 24 Feb 2006 16:30:35 -0500 Received: from dsl093-016-182.msp1.dsl.speakeasy.net ([66.93.16.182]:58804 "EHLO cinder.waste.org") by vger.kernel.org with ESMTP id S932547AbWBXVae (ORCPT ); Fri, 24 Feb 2006 16:30:34 -0500 Date: Fri, 24 Feb 2006 15:30:34 -0600 From: Matt Mackall To: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/7] inflate pt1: refactor boot-time inflate code Message-ID: <20060224213034.GC13116@waste.org> References: <1.399206195@selenic.com> <20060224205626.GB28855@flint.arm.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060224205626.GB28855@flint.arm.linux.org.uk> User-Agent: Mutt/1.5.11+cvs20060126 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1886 Lines: 42 On Fri, Feb 24, 2006 at 08:56:26PM +0000, Russell King wrote: > On Fri, Feb 24, 2006 at 02:12:15PM -0600, Matt Mackall wrote: > > This is a refactored version of the lib/inflate.c: > > > > - clean up some really ugly code > > - clean up atrocities like '#include "../../../lib/inflate.c"' > > - drop a ton of cut and paste code from the kernel boot > > - move towards making the boot decompressor pluggable > > - move towards unifying the multiple inflate implementations > > - save space > > > > I'm sending this out in three batches. This first batch is core > > clean-ups without arch-specific changes. > > > > (This work was sponsored in part by the CE Linux Forum.) > > ISTR something like this was posted months back, but I don't remember > what the status of it was. Hence, I might be repeating myself in this > reply, but I feel it's better to mention this than not to. > > There's a comment at the top of arch/arm/boot/compressed/misc.c which > describes the use of the inflate code on ARM - for the kernel it's a > special case where the decompressor is run from ROM. > > There's also another twist to it though - our relocatable zImage > requires us to build all files in the executable part of zImage > without _any_ static variables. If there's one or more static > variables, this feature breaks horribly (and silently in the non- > relocated cases.) I think I addressed all those issues last time around, and none of them should be present in this batch anyway. But it's possible I've missed something. If you'd like, I can send the whole set to you for testing. -- Mathematics is the supreme nostalgia of our time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/