Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 2 Apr 2020 11:03:47 +0800
From:   Leo Yan <leo.yan@linaro.org>
To:     Adrian Hunter <adrian.hunter@intel.com>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>, Andi Kleen <ak@linux.intel.com>,
        linux-kernel@vger.kernel.org, Kim Phillips <kim.phillips@arm.com>
Subject: Re: [PATCH 04/16] perf arm-spe: Implement ->evsel_is_auxtrace()
 callback
Message-ID: <20200402030347.GA11494@leoy-ThinkPad-X240s>
References: <20200401101613.6201-1-adrian.hunter@intel.com>
 <20200401101613.6201-5-adrian.hunter@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200401101613.6201-5-adrian.hunter@intel.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 01, 2020 at 01:16:01PM +0300, Adrian Hunter wrote:
> Implement ->evsel_is_auxtrace() callback.
> 
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Kim Phillips <kim.phillips@arm.com>
> ---
>  tools/perf/util/arm-spe.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c
> index 53be12b23ff4..b30cc74d0fb4 100644
> --- a/tools/perf/util/arm-spe.c
> +++ b/tools/perf/util/arm-spe.c
> @@ -176,6 +176,15 @@ static void arm_spe_free(struct perf_session *session)
>  	free(spe);
>  }
>  
> +static bool arm_spe_evsel_is_auxtrace(struct perf_session *session,
> +				      struct evsel *evsel)
> +{
> +	struct arm_spe *spe = container_of(session->auxtrace, struct arm_spe,
> +					     auxtrace);
> +
> +	return evsel->core.attr.type == spe->pmu_type;
> +}
> +
>  static const char * const arm_spe_info_fmts[] = {
>  	[ARM_SPE_PMU_TYPE]		= "  PMU Type           %"PRId64"\n",
>  };
> @@ -218,6 +227,7 @@ int arm_spe_process_auxtrace_info(union perf_event *event,
>  	spe->auxtrace.flush_events = arm_spe_flush;
>  	spe->auxtrace.free_events = arm_spe_free_events;
>  	spe->auxtrace.free = arm_spe_free;
> +	spe->auxtrace.evsel_is_auxtrace = arm_spe_evsel_is_auxtrace;
>  	session->auxtrace = &spe->auxtrace;

Reviewed-by: Leo Yan <leo.yan@linaro.org>

>  	arm_spe_print_info(&auxtrace_info->priv[0]);
> -- 
> 2.17.1
>