Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1451691ybb; Thu, 2 Apr 2020 00:41:49 -0700 (PDT) X-Google-Smtp-Source: APiQypKy1NIUQZndYAe6CgHef6v10NWEyaiQgScskqZ7yTD3NDwp/FX+56krhUpCXNhLMklPOB+0 X-Received: by 2002:a05:6830:1ad4:: with SMTP id r20mr1445165otc.316.1585813309410; Thu, 02 Apr 2020 00:41:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585813309; cv=none; d=google.com; s=arc-20160816; b=a0X8DfyCamU6hXpBt/8d3nk4aF9ogBEKLmPfzl2zi0R7/ThUkR5YuBxBw1iUzJi9tR TYXBQzSGedvt9iofDcu9+sP7YEoK41pmKc5lMj2KTDOs/D0ux3Fq4aUX0oXX0D6/lCUt AKixarwPnQRhQ+e8P62zV2J9kP7VaD9QfKf/QFXXOlgX4nAJnjjsDZXeRJ6mJEUEUh4H TCVaTg2s6b0uSeZug6+k1OpDxnsmJIBQYprG7EEFCbjFHPiEvR0s5xBMHdSwy3jEOh7+ 6P2i6bu1hM8KevamLJysDduH+IJ+e2+kdy96bcb6YgGq8pdC9wUHdxjcygWXzlQtcHY/ t5QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=rRniYv7RPwWHFWrPJUZ8iMNVA0tUTHJrCguWpqpN+6k=; b=T8kVQFYS+FfH77ci0lu0GMHPulmHjWQcnAO4d6EfSEjFRAJoVWk2qhdkRo3Co1LOrf plZL1VSyWwSEa/xHYW9vcLLtoojyXRfORquY+AyRQrVn2+GNRTvjNpKvQKW19FeNWu5S 2a4ZZtUBV1fzPah0kgNVukrcS0a4vtIRGQSkWcja6xCFM+X7jwybc5qhp7WAAA/0CUsh xVmbnYSYx57TUGq5eR5pnhbDY6zbhzltJvDI9yaBXLFcp4K1hh3DCvLg4yc7/LSG80r7 6jgqFnDHZDTw4HepInmo2V9Op9zBpS3LWWChsZPiLkITauw/AoAKjpoMvoXpAIllQOL4 eMYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ZgYWh0h+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w85si1995122oif.88.2020.04.02.00.41.35; Thu, 02 Apr 2020 00:41:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ZgYWh0h+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387616AbgDBHkx (ORCPT + 99 others); Thu, 2 Apr 2020 03:40:53 -0400 Received: from mail-pj1-f67.google.com ([209.85.216.67]:34942 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728135AbgDBHkx (ORCPT ); Thu, 2 Apr 2020 03:40:53 -0400 Received: by mail-pj1-f67.google.com with SMTP id g9so1196940pjp.0 for ; Thu, 02 Apr 2020 00:40:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rRniYv7RPwWHFWrPJUZ8iMNVA0tUTHJrCguWpqpN+6k=; b=ZgYWh0h+a5Hg2gYuDaf7bAJw/KFnrjKUiEuvbptyyu8Ds6OObwEJ9RIl0P+Ognz7ON aVcJvZkmoY5pTE9Oigwg6Rz73WgiRqYNakHvrmSrDodIpjaHrTg1KZr/8/65eN0WM5/I HNXT2GWnBGZf3TIUSbj5+3eAx6Fzc29HW0q/8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rRniYv7RPwWHFWrPJUZ8iMNVA0tUTHJrCguWpqpN+6k=; b=S37pUxMnPkCl0yG0BeBPFHXzEimh7qo9wT+QYsF7wa2MKKneL+4vyq/CykXkALlB6T Ri7aDgHF0+SnZbOSdZxFZA3881BCXj5wqz2HpipbBj4F3C/5p585WofY5TxecPTiXUi3 Pnku6EeKkHVI4B8z4l5SMQS118TBbyJsKI1x7NUIiCBzhaJKZnH8U0MKbm+Z8Q7R4zfG DB/ttZtMB6mcry6764ctEKDKQAOMgUqSyjBe4I9uSEK1r25N7GAgdGqqr8F4SkVlIHe+ 3zikYXgztRH2y1Y01kZE7B9k7xaUH2yg8hZx6w3lbzJF//7gdoKPpLmrVdFftB0HE9+w 3/HA== X-Gm-Message-State: AGi0Puar32GydKmfNTwS3SkaqBhk7JXQ1P+Oep1VwUugHiQPHjOSyD98 mxlws1wXC06M73i8dOyXAKqLew== X-Received: by 2002:a17:902:a706:: with SMTP id w6mr1769890plq.79.1585813251785; Thu, 02 Apr 2020 00:40:51 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 8sm3137514pfy.130.2020.04.02.00.40.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2020 00:40:50 -0700 (PDT) Date: Thu, 2 Apr 2020 00:40:09 -0700 From: Kees Cook To: Matthew Wilcox Cc: Bernd Edlinger , "Eric W. Biederman" , Greg Kroah-Hartman , Kirill Tkhai , Christian Brauner , Jann Horn , Jonathan Corbet , Alexander Viro , Andrew Morton , Alexey Dobriyan , Thomas Gleixner , Oleg Nesterov , Frederic Weisbecker , Andrei Vagin , Ingo Molnar , "Peter Zijlstra (Intel)" , Yuyang Du , David Hildenbrand , Sebastian Andrzej Siewior , Anshuman Khandual , David Howells , James Morris , Shakeel Butt , Jason Gunthorpe , Christian Kellner , Andrea Arcangeli , Aleksa Sarai , "Dmitry V. Levin" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-mm@kvack.org" , "stable@vger.kernel.org" , "linux-api@vger.kernel.org" Subject: Re: [PATCH v6 00/16] Infrastructure to allow fixing exec deadlocks Message-ID: <202004020037.67ED66C8B6@keescook> References: <871rpg8o7v.fsf@x220.int.ebiederm.org> <202003282041.A2639091@keescook> <20200330201459.GF22483@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200330201459.GF22483@bombadil.infradead.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 30, 2020 at 01:14:59PM -0700, Matthew Wilcox wrote: > On Mon, Mar 30, 2020 at 10:12:02PM +0200, Bernd Edlinger wrote: > > On 3/29/20 5:44 AM, Kees Cook wrote: > > > On Sat, Mar 28, 2020 at 11:32:35PM +0100, Bernd Edlinger wrote: > > >> Oh, do I understand you right, that I can add a From: in the > > >> *body* of the mail, and then the From: in the MIME header part > > >> which I cannot change is ignored, so I can make you the author? > > > > > > Correct. (If you use "git send-email" it'll do this automatically.) > > > > > > e.g., trimmed from my workflow: > > > > > > git format-patch -n --to "$to" --cover-letter -o outgoing/ \ > > > --subject-prefix "PATCH v$version" "$SHA" > > > edit outgoing/0000-* > > > git send-email --transfer-encoding=8bit --8bit-encoding=UTF-8 \ > > > --from="$ME" --to="$to" --cc="$ME" --cc="...more..." outgoing/* > > > > > > > > > > Okay, thanks, I see that is very helpful information for me, and in > > this case I had also fixed a small bug in one of Eric's patches, which > > was initially overlooked (aquiring mutexes in wrong order, > > releasing an unlocked mutex in some error paths). > > I am completely unexperienced, and something that complex was not > > expected to happen :-) so this is just to make sure I can handle it > > correctly if something like this happens again. > > > > In the case of PATCH v6 05/16 I removed the Reviewd-by: Bernd Edlinger > > since it is now somehow two authors and reviewing own code is obviously > > not ok, instead I added a Signed-off-by: Bernd Edlinger (and posted the > > whole series on Eric's behalf (after asking Eric's permissing per off-list > > e-mail, which probably ended in his spam folder) > > > > Is this having two Signed-off-by: for mutliple authors the > > correct way to handle a shared authorship? > > If the patch comes through you, then Reviewed-by: is inappropriate. > Instead, you should use Signed-off-by: in the second sense of > Documentation/process/submitting-patches.rst > > This also documents how to handle "minor changes" that you make. And in the true case of multiple authors, have both SoBs, but also add a Co-developed-by: for the non-"git author" author. Specific details: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by -- Kees Cook