Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1452079ybb; Thu, 2 Apr 2020 00:42:29 -0700 (PDT) X-Google-Smtp-Source: APiQypK9BqiqHu/EfXLlPuleXWztDvM35wYEMVgXgWAKT4QBB+kHUmPuz7rKxBEKjmLqN12Gj59f X-Received: by 2002:a9d:2aca:: with SMTP id e68mr1414585otb.324.1585813348974; Thu, 02 Apr 2020 00:42:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585813348; cv=none; d=google.com; s=arc-20160816; b=yKgQ9YyasMO3d1sSFTdietTn1B5mp6EWHbuWEqLmdAJIpPcMXMaLHT/zgbfGYRHOCp sumEZD0RBElke5HMfFq9NavR0+LIJXRKu/7JRPFnxyi8QbYi1qq3fJPirTs5VpmuQFAF hcrCWPCdIl1/uCMSvJ08GntcZyFGivDKcyUYb0U/1wfINKRX2tsys2OlyUjZOWMrLas+ eSJ13M39WTQ4HRX1p3Hhm8rIZb2cW5mfoitpu+oOoeZBiOM2U0W7aduBWkyrUYsr/dCn 85HDK+VO9/yRodiZbuIB4Z1L7+p4JWPeAGcQxNFt14FK3O3zqQqwwOTYYo/bT1EqyKlu 2FdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=wxvF/+u7KELI/jIBwkyObWmgPCHKCclGo+byqnItBfc=; b=JVN66uVtdtrzuy8XpZJuUPNeiJRvJLJ0TBBKbuDI6F6HceWQ58ZXAOYt3sdQwj4Cfq /NeDlvp2go7Tf02acoya3pvC7nWdP/WVBOsfq6mAxztETEVW3En/TnPipnYM2q3IoJND e87MiAaFLaXq2yFjLseMBDLz4YCTYbNROPrpYbSuH/4qiQJLaQ+p3KH/lASh86f0vLrY vTXV4IVuzu/Ky2cbTXhNix3DEhLOO0guKoI1wlNipoJ8Ke4/dxGdqLL9i55YXnmocjNo CHPit895LUu+GxoCT2L5wjSmF0YUcIPyzNqEk6b80zQOdhIVrFyPYHFGSbcIZesUBxMx bDHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ACHfzrKp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m1si1986824ote.308.2020.04.02.00.42.16; Thu, 02 Apr 2020 00:42:28 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ACHfzrKp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387604AbgDBHkT (ORCPT + 99 others); Thu, 2 Apr 2020 03:40:19 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:41998 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728135AbgDBHkS (ORCPT ); Thu, 2 Apr 2020 03:40:18 -0400 Received: by mail-lj1-f196.google.com with SMTP id q19so2127226ljp.9 for ; Thu, 02 Apr 2020 00:40:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wxvF/+u7KELI/jIBwkyObWmgPCHKCclGo+byqnItBfc=; b=ACHfzrKps1Y4qZ9YwaFZz454GAI42WKp0MnKRH+8uzjnzI0AVl1GPC/yTcGOrmSQT7 WwN6Lov4ZzMLjFKKNJHUAFzcJd0+Jonx/0LeOu4FWrjASmB9WAZzy9dKY9ldaKMWqXZC ZGAbfVQlR+9zU1P2eWd6rzDyyv9o1jkBqBs4xI8Ifbk6tT8lIXjGA+EL06SSRftkz9fF prWVWRQncTwRVneP0UDZZkl/58ymlrYkh5+MCxr6f8td2KYmIhhEzD8eBEjqUQuw3rjk 2iHeZMh5rcmxyNZL9T8vMI1Q4JAMfFlYyYNtTJe6U0cN/uUYSOHDPCWNwWU0OjaqKSXX eWPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wxvF/+u7KELI/jIBwkyObWmgPCHKCclGo+byqnItBfc=; b=brpbfR23FD6gf/0hkHC0PBNr15YKeoS82NV4QRnu4/RO2OjFPWrQnKoPoHT+vSZdeN LvUWrNu9AGDzsh9DsBoxEgnlLuHHE/ECxem1T+6oHh/vTGanFr00R6jiTmsdMXDP00fT W+9Gq2SOZ84hSGUYXDOPeN9AQA535RcVuo2duBtzVIuLly7yMp1LhkVrPPi/+lvihdlg e2L+n9avBFDlYMlWYNQrpDRUHwJqLsmDHb3yWCFc0HtOsO1mSW0n6W/7X1Xp8FWIGl2d q25hyDpRYMRnE0zUpWabynXyp65XX7a8nCyeZ655mnaYVKuyf55/PChlznfDRR8gSCy3 2Cpg== X-Gm-Message-State: AGi0PuakmuOhm9+nki6703NWzgk/KekwGjCDTxStzmKUL4wUSXNuqNUn N/SlrNFfaQJoroXVt/PTo6cT72veq17LIOlIPT2llg== X-Received: by 2002:a2e:5048:: with SMTP id v8mr1117658ljd.99.1585813216416; Thu, 02 Apr 2020 00:40:16 -0700 (PDT) MIME-Version: 1.0 References: <8d3579f4b49bb675dc805035960f24852898be28.1585734060.git.baolin.wang7@gmail.com> In-Reply-To: <8d3579f4b49bb675dc805035960f24852898be28.1585734060.git.baolin.wang7@gmail.com> From: Linus Walleij Date: Thu, 2 Apr 2020 09:40:05 +0200 Message-ID: Subject: Re: [PATCH] Revert "gpio: eic-sprd: Use devm_platform_ioremap_resource()" To: Baolin Wang Cc: Bartosz Golaszewski , Orson Zhai , Lyra Zhang , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 1, 2020 at 11:59 AM Baolin Wang wrote: > This reverts commit 0f5cb8cc27a266c81e6523b436479802e9aafc9e. > > This commit will cause below warnings, since our EIC controller can support > differnt banks on different Spreadtrum SoCs, and each bank has its own base > address, we will get invalid resource warning if the bank number is less than > SPRD_EIC_MAX_BANK on some Spreadtrum SoCs. > > So we should not use devm_platform_ioremap_resource() here to remove the > warnings. > > [ 1.118508] sprd-eic 40210000.gpio: invalid resource > [ 1.118535] sprd-eic 40210000.gpio: invalid resource > [ 1.119034] sprd-eic 40210080.gpio: invalid resource > [ 1.119055] sprd-eic 40210080.gpio: invalid resource > [ 1.119462] sprd-eic 402100a0.gpio: invalid resource > [ 1.119482] sprd-eic 402100a0.gpio: invalid resource > [ 1.119893] sprd-eic 402100c0.gpio: invalid resource > [ 1.119913] sprd-eic 402100c0.gpio: invalid resource > > Signed-off-by: Baolin Wang Patch applied. Yours, Linus Walleij