Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1478126ybb; Thu, 2 Apr 2020 01:19:50 -0700 (PDT) X-Google-Smtp-Source: APiQypJYhhElsWwnQHSXSmQnpxIP3kgeIKVYspqU9DJzwymXTnq/vZAf0SYBDQWGDYDmkIs2Gkw1 X-Received: by 2002:a54:4797:: with SMTP id o23mr1315810oic.12.1585815589960; Thu, 02 Apr 2020 01:19:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1585815589; cv=none; d=google.com; s=arc-20160816; b=eXBwSUcCPpXvAgySLDWfobDsOocdjT/xKsllJ083BaMozrrT4hj2E98yz4cagew15u EVPH/0xK5uHYCAUFtSFQ2iNumb+TqZFbtVADzTqy+DQLWn8Uca3PhQkyUpTnaQo7GdC8 Wq76um594d+erpThVqfxH6Bm1IpOvRWmCSX1IVbr1zWcBiVXHXiGVEwvocPpAj+mjV7H XovoMbCpnOynMuA0i/RDgjFPeep5dA9kqWc5IIF0D43dLWxnt+gengEvQupsZQtDwSmY BbJbnZaMx4MpAFwHbyZgBQp6Jjr4jf2fhOQAaD+8R6qR8Q80pUlKF0C4gnnabHT2mQvd BvuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=MPDVtlakEiOSQRPk/nmtrNp/UKM5ykm3de68LlZszp8=; b=n8gg53alTY+jips8An0zI6uF66zWB660+qFa5hvZ2APxw1cQYuPn+r2B89Pg8PkzI+ t+DQYwErW/XqFx09K/pPKTMDc2XrZXNXjQmdFvRje63OC7sfl5L7sitmTxRwLqNYRyza NEXPba+FWhOgtvFd87HcTIClfagLThFrjNhnn8e5x79z1QOGyrrUmOL6bU9CX/ykJAyN RSg0aVnA9In37mBlKOkoZlCa5Qnh3X0gMZkBANdCanurCNK3bHfE72YlpI+g77GFOnXq J8Zn356PBFHiZSDyoSxk8CtjPXBu9J9WAdVsSwjgFqFTmhMdEQafbQ5X5n+S+yoClbVu hfZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=Yo0Eyhag; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w73si2045837oiw.206.2020.04.02.01.19.37; Thu, 02 Apr 2020 01:19:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=Yo0Eyhag; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387789AbgDBISn (ORCPT + 99 others); Thu, 2 Apr 2020 04:18:43 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:39206 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387705AbgDBISl (ORCPT ); Thu, 2 Apr 2020 04:18:41 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0328HfDr196549; Thu, 2 Apr 2020 08:18:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2020-01-29; bh=MPDVtlakEiOSQRPk/nmtrNp/UKM5ykm3de68LlZszp8=; b=Yo0Eyhag2YJGU264sdIMgp2QzQunzTeQo/PuUNxArQrjlTPwWIoZijLiIIVHwjA1RUV5 FHYrHVm9gmNOSuX8eH5pOkOeef688kC+UzIqZIiQp0QBYr8IsOQ8SKMQqcuwlwKtRjMu J1RtVdwFyAUkm4IpuMJvOyZ12cflmNGNO5RmXDXLc54MuorLXJwX5oLUvJelT2lmiADN +XrizNA9rMEBKRALczu+eWjly4upP9vpppAACknG6vkg5PwENSHflxYAu7KG38kaxOYY rU8Af4l/WXeXQOLZ2fRQBj31zQELVRjiqXPZGJ5o8yO0EYEtXr3FsFWfg00EW1RJ1gUH RA== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 303yunce45-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 Apr 2020 08:18:12 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0328H8nR126379; Thu, 2 Apr 2020 08:18:12 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 304sjnsshn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 02 Apr 2020 08:18:12 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0328IBL7003402; Thu, 2 Apr 2020 08:18:11 GMT Received: from linux-1.home (/92.157.90.160) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 02 Apr 2020 01:18:11 -0700 From: Alexandre Chartre To: x86@kernel.org Cc: linux-kernel@vger.kernel.org, jpoimboe@redhat.com, peterz@infradead.org, jthierry@redhat.com, tglx@linutronix.de, alexandre.chartre@oracle.com Subject: [PATCH 1/7] objtool: is_fentry_call() crashes if call has no destination Date: Thu, 2 Apr 2020 10:22:14 +0200 Message-Id: <20200402082220.808-2-alexandre.chartre@oracle.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200402082220.808-1-alexandre.chartre@oracle.com> References: <20200402082220.808-1-alexandre.chartre@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9578 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 mlxscore=0 malwarescore=0 phishscore=0 suspectscore=1 mlxlogscore=999 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004020075 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9578 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 priorityscore=1501 mlxlogscore=999 bulkscore=0 suspectscore=1 mlxscore=0 spamscore=0 impostorscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004020075 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix is_fentry_call() so that it works if a call has no destination set (call_dest). This needs to be done in order to support intra- function calls. Signed-off-by: Alexandre Chartre --- tools/objtool/check.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 4768d91c6d68..708562fb89e1 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -1363,7 +1363,7 @@ static int decode_sections(struct objtool_file *file) static bool is_fentry_call(struct instruction *insn) { - if (insn->type == INSN_CALL && + if (insn->type == INSN_CALL && insn->call_dest && insn->call_dest->type == STT_NOTYPE && !strcmp(insn->call_dest->name, "__fentry__")) return true; -- 2.18.2