Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] scsi: hisi_sas: Fix build error without SATA_HOST
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     john.garry@huawei.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, chenxiang66@hisilicon.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Message-ID: <c4e9d7a0-668a-5dee-2a15-5e5392c2f275@samsung.com>
Date:   Thu, 2 Apr 2020 11:08:06 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
        Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20200402085812.32948-1-yuehaibing@huawei.com>
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <20200402063021.34672-1-yuehaibing@huawei.com>
        <CGME20200402085851eucas1p2b2173a11582e32a73689d4fc98d94c6a@eucas1p2.samsung.com>
        <20200402085812.32948-1-yuehaibing@huawei.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 4/2/20 10:58 AM, YueHaibing wrote:
> If SATA_HOST is n, build fails:
> 
> drivers/scsi/hisi_sas/hisi_sas_main.o: In function `hisi_sas_fill_ata_reset_cmd':
> hisi_sas_main.c:(.text+0x2500): undefined reference to `ata_tf_to_fis'
> 
> Select SATA_HOST to fix this.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: bd322af15ce9 ("ata: make SATA_PMP option selectable only if any SATA host driver is enabled")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>

PS I have audited all drivers dependent on ATA again and this is
the only driver needing fixing.

> ---
> v2: use correct Fixes tag
> ---
>  drivers/scsi/hisi_sas/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig
> index 90a17452a50d..13ed9073fc72 100644
> --- a/drivers/scsi/hisi_sas/Kconfig
> +++ b/drivers/scsi/hisi_sas/Kconfig
> @@ -6,6 +6,7 @@ config SCSI_HISI_SAS
>  	select SCSI_SAS_LIBSAS
>  	select BLK_DEV_INTEGRITY
>  	depends on ATA
> +	select SATA_HOST
>  	help
>  		This driver supports HiSilicon's SAS HBA, including support based
>  		on platform device
> 

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics